Merge lp:~nskaggs/ubuntu-clock-app/update-test-layout into lp:ubuntu-clock-app
| Status: | Merged |
|---|---|
| Approved by: | Nicholas Skaggs on 2015-06-19 |
| Approved revision: | 291 |
| Merged at revision: | 284 |
| Proposed branch: | lp:~nskaggs/ubuntu-clock-app/update-test-layout |
| Merge into: | lp:ubuntu-clock-app |
| Diff against target: |
1516 lines (+750/-601) 8 files modified
README.autopilot (+13/-10) debian/changelog (+6/-0) tests/autopilot/ubuntu_clock_app/CMakePluginParser.py (+119/-0) tests/autopilot/ubuntu_clock_app/__init__.py (+545/-3) tests/autopilot/ubuntu_clock_app/emulators.py (+0/-546) tests/autopilot/ubuntu_clock_app/tests/__init__.py (+60/-35) tests/autopilot/ubuntu_clock_app/tests/test_alarm.py (+3/-3) tests/autopilot/ubuntu_clock_app/tests/test_clock.py (+4/-4) |
| To merge this branch: | bzr merge lp:~nskaggs/ubuntu-clock-app/update-test-layout |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Nekhelesh Ramananthan | 2015-06-17 | Approve on 2015-06-19 | |
| Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve on 2015-06-18 | |
|
Review via email:
|
|||
Commit Message
Update testing layout
Description of the Change
Update testing layout. This conforms more with the best practices we have today by removing the older naming of emulators. It also should now properly detect a cmake build, and not require you to build in a certain folder.
| Nekhelesh Ramananthan (nik90) wrote : | # |
Thanks Nicholas for the MP. Just a couple of minor things,
In your MP description you mention that "It also should now properly detect a cmake build, and not require you to build in a certain folder." .. I suppose you're talking about the lack of need to create builddir like it was mandatory to do before. However when I tried running the tests without creating a separate build dir, I wasn't able to run autopilot tests. The errors can be found at http://
On creating a builddir, cmake .. && make and then running the test, everything worked correctly. The readme still informs the user to create a builddir, so w.r.t everything is good.
Is this what you expected?
| Nekhelesh Ramananthan (nik90) wrote : | # |
Can you update the debian changelog pls?
- 285. By Nicholas Skaggs on 2015-06-18
-
Update testing layout. No longer require specific cmake build directory to run tests
- 286. By Nicholas Skaggs on 2015-06-18
-
bzr revert
- 287. By Nicholas Skaggs on 2015-06-18
-
remerge trunk
PASSED: Continuous integration, rev:285
http://
Executed test runs:
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
PASSED: Continuous integration, rev:287
http://
Executed test runs:
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
- 288. By Nicholas Skaggs on 2015-06-18
-
fix pathing for launch
FAILED: Continuous integration, rev:288
http://
Executed test runs:
FAILURE: http://
Click here to trigger a rebuild:
http://
- 289. By Nicholas Skaggs on 2015-06-18
-
fix cmake parser defaults
- 290. By Nicholas Skaggs on 2015-06-18
-
flake8
PASSED: Continuous integration, rev:290
http://
Executed test runs:
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
- 291. By Nicholas Skaggs on 2015-06-18
-
force builddir
PASSED: Continuous integration, rev:291
http://
Executed test runs:
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
| Nekhelesh Ramananthan (nik90) wrote : | # |
So on testing this morning, I observed the following,
- Creating a specific builddir and then running the tests works as expected
- Building using the Ubuntu SDK and then running the tests works as expected (improvement compared to what we have in trunk)
- Building in the root app directory and running the tests fail (http://
This is fine by me. If this accomplishes what you expected, feel free to top-approve.


PASSED: Continuous integration, rev:284 91.189. 93.70:8080/ job/ubuntu- clock-app- ci/668/ 91.189. 93.70:8080/ job/ubuntu- clock-app- vivid-amd64- ci/14 91.189. 93.70:8080/ job/ubuntu- clock-app- vivid-amd64- ci/14/artifact/ work/output/ *zip*/output. zip
http://
Executed test runs:
SUCCESS: http://
deb: http://
Click here to trigger a rebuild: 91.189. 93.70:8080/ job/ubuntu- clock-app- ci/668/ rebuild
http://