Merge lp:~nskaggs/ubuntu-clock-app/fix-ap-mainview into lp:ubuntu-clock-app

Proposed by Nicholas Skaggs
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 381
Merged at revision: 385
Proposed branch: lp:~nskaggs/ubuntu-clock-app/fix-ap-mainview
Merge into: lp:ubuntu-clock-app
Diff against target: 60 lines (+10/-4)
2 files modified
app/ubuntu-clock-app.qml (+1/-1)
tests/autopilot/ubuntu_clock_app/__init__.py (+9/-3)
To merge this branch: bzr merge lp:~nskaggs/ubuntu-clock-app/fix-ap-mainview
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Nekhelesh Ramananthan Approve
Review via email: mp+271029@code.launchpad.net

Commit message

Fix Mainview12 issue

Description of the change

Probably should at least land this change so anyone can work off of it.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

LGTM! Thnx for the fix Nicholas!

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-clock-app-autolanding/317/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/ubuntu-clock-app-vivid-amd64-autolanding/74/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/ubuntu-clock-app.qml'
2--- app/ubuntu-clock-app.qml 2015-08-26 23:35:50 +0000
3+++ app/ubuntu-clock-app.qml 2015-09-14 20:53:59 +0000
4@@ -30,7 +30,7 @@
5 property bool applicationState: Qt.application.active
6
7 // objectName for functional testing purposes (autopilot-qt5)
8- objectName: "clock"
9+ objectName: "clockMainView"
10
11 // applicationName for click packages (used as an unique app identifier)
12 applicationName: "com.ubuntu.clock"
13
14=== modified file 'tests/autopilot/ubuntu_clock_app/__init__.py'
15--- tests/autopilot/ubuntu_clock_app/__init__.py 2015-06-17 21:03:43 +0000
16+++ tests/autopilot/ubuntu_clock_app/__init__.py 2015-09-14 20:53:59 +0000
17@@ -49,6 +49,11 @@
18
19 class MainView(ubuntuuitoolkit.MainView):
20
21+ # bug 1341671 means AP sees this as MainView12
22+ @classmethod
23+ def get_type_query_name(cls):
24+ return 'MainView12'
25+
26 @autopilot_logging.log_action(logger.info)
27 def open_clock(self):
28 """Open the Clock Page.
29@@ -68,7 +73,7 @@
30 clockPage = self.open_clock()
31 clockPage.reveal_bottom_edge_page()
32 self.get_header().visible.wait_for(True)
33- return self.wait_select_single(Page11)
34+ return self.wait_select_single(AlarmPage)
35
36 def get_AlarmList(self):
37 """ Get the AlarmList object. """
38@@ -92,11 +97,12 @@
39 self.main_view = self.get_root_instance().select_single(MainView)
40
41
42-class PageWithBottomEdge(MainView):
43+class PageWithBottomEdge(Page):
44 """
45 An emulator class that makes it easy to interact with the bottom edge
46 swipe page
47 """
48+
49 def __init__(self, *args):
50 super(PageWithBottomEdge, self).__init__(*args)
51
52@@ -191,7 +197,7 @@
53 self.pointing_device.click_object(deleteButton)
54
55
56-class Page11(Page):
57+class AlarmPage(Page):
58 """Autopilot helper for the Alarm page."""
59
60 @autopilot_logging.log_action(logger.info)

Subscribers

People subscribed via source and target branches