Merge lp:~nskaggs/ubuntu-clock-app/add-cmake into lp:ubuntu-clock-app/saucy

Proposed by Nicholas Skaggs
Status: Merged
Approved by: Nicholas Skaggs
Approved revision: 339
Merged at revision: 339
Proposed branch: lp:~nskaggs/ubuntu-clock-app/add-cmake
Merge into: lp:ubuntu-clock-app/saucy
Diff against target: 275 lines (+124/-42)
12 files modified
CMakeLists.txt (+65/-0)
click/CMakeLists.txt (+8/-0)
com.ubuntu.clock_clock.desktop.in (+3/-3)
debian/control (+8/-8)
debian/rules (+0/-13)
debian/ubuntu-clock-app-autopilot.install (+1/-1)
debian/ubuntu-clock-app.install (+2/-11)
po/CMakeLists.txt (+25/-0)
tests/CMakeLists.txt (+1/-0)
tests/autopilot/CMakeLists.txt (+8/-0)
tests/autopilot/ubuntu_clock_app/tests/__init__.py (+1/-5)
ubuntu-clock-app.in (+2/-1)
To merge this branch: bzr merge lp:~nskaggs/ubuntu-clock-app/add-cmake
Reviewer Review Type Date Requested Status
Sergio Schvezov (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Ubuntu Clock Developers Pending
Review via email: mp+204326@code.launchpad.net

Commit message

Add cmake build
fix OSK from not be re-enabled after testing

Description of the change

Add cmake build
fix OSK from not be re-enabled after testing

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
315. By Launchpad Translations on behalf of ubuntu-clock-dev

Launchpad automatic translations update.

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Please find someone to do the testing of this MP since I have absolutely no knowledge of CMAKE. Hence I wouldn't be able to review the MP.

316. By Victor Thompson

Force active focus of SearchBox text field. Fixes: https://bugs.launchpad.net/bugs/1274710.

Approved by Nekhelesh Ramananthan, Ubuntu Phone Apps Jenkins Bot.

317. By Victor Thompson

Increment/decrement hours count by winding clock in alarm. Fixes: https://bugs.launchpad.net/bugs/1274075.

Approved by Nekhelesh Ramananthan, Ubuntu Phone Apps Jenkins Bot.

318. By Victor Thompson

Propagate space key when pressed. Fixes: https://bugs.launchpad.net/bugs/1275084.

Approved by Ubuntu Phone Apps Jenkins Bot, Nekhelesh Ramananthan.

319. By Nekhelesh Ramananthan

Updated copyright of files that were changed this year 2014. Added missing copyright information to Blip and Settings files.

Approved by Riccardo Padovani, Ubuntu Phone Apps Jenkins Bot.

320. By Launchpad Translations on behalf of ubuntu-clock-dev

Launchpad automatic translations update.

321. By Launchpad Translations on behalf of ubuntu-clock-dev

Launchpad automatic translations update.

322. By Michal Predotka

Make timer hands snap to digits. Do not show 60 value for minutes and seconds in timer. Fixes: https://bugs.launchpad.net/bugs/1274127, https://bugs.launchpad.net/bugs/1274270.

Approved by Ubuntu Phone Apps Jenkins Bot, Nekhelesh Ramananthan.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
323. By Nekhelesh Ramananthan

Transitioned sunrise/sunset times cache from LocalStorage to U1db. Fixes: https://bugs.launchpad.net/bugs/1269159.

Approved by Ubuntu Phone Apps Jenkins Bot, Andrew Hayzen.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
324. By Nekhelesh Ramananthan

Fixes the issue of overflowing labels in the clock, alarm and timer tabs. Also rearranges the alarm column to maintain consistency with other tabs. Fixes: https://bugs.launchpad.net/bugs/1275720.

Approved by Riccardo Padovani, Ubuntu Phone Apps Jenkins Bot.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
325. By Nekhelesh Ramananthan

Transitions timer preset list storage from LocalStorage to U1db. Fixes: https://bugs.launchpad.net/bugs/1276111.

Approved by Andrew Hayzen, Ubuntu Phone Apps Jenkins Bot.

326. By Launchpad Translations on behalf of ubuntu-clock-dev

Launchpad automatic translations update.

327. By Launchpad Translations on behalf of ubuntu-clock-dev

Launchpad automatic translations update.

328. By Launchpad Translations on behalf of ubuntu-clock-dev

Launchpad automatic translations update.

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

sergiusens@rivendell:~/source/apps/clock/add-cmake$ bzr diff
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2014-02-04 19:18:22 +0000
+++ CMakeLists.txt 2014-02-08 18:30:56 +0000
@@ -10,14 +10,14 @@
 set(APP_NAME clock)
 set(DESKTOP_FILE "${PROJECT_NAME}_${APP_NAME}.desktop")
 set(URLS_FILE "${PROJECT_NAME}_${APP_NAME}.url-dispatcher")
+set(APP_HARDCODE ubuntu-clock-app)
 set(MAIN_QML ${APP_HARDCODE}.qml)
 set(ICON clock64.png)
 set(AUTOPILOT_DIR ubuntu_clock_app)
-set(APP_HARDCODE ubuntu-clock-app)

 if(CLICK_MODE)
     if(NOT DEFINED BZR_SOURCE)
- set(BZR_SOURCE "lp:ubuntu-${APP_HARDCODE}")
+ set(BZR_SOURCE "lp:${APP_HARDCODE}")
         message("-- Setting BZR_SOURCE to ${BZR_SOURCE}")
     endif(NOT DEFINED BZR_SOURCE)
     set(CMAKE_INSTALL_PREFIX /)
@@ -48,6 +48,7 @@
      RELATIVE ${CMAKE_CURRENT_SOURCE_DIR}
      *.qml *.js *.png *.js)
 install(FILES ${SRC_FILES} DESTINATION ${DATA_DIR})
+install(DIRECTORY alarm clock common images stopwatch timer DESTINATION ${DATA_DIR})

 configure_file(${DESKTOP_FILE}.in ${CMAKE_CURRENT_BINARY_DIR}/${DESKTOP_FILE})
 install(FILES ${CMAKE_CURRENT_BINARY_DIR}/${DESKTOP_FILE} DESTINATION ${DESKTOP_DIR})

review: Needs Fixing
329. By Nekhelesh Ramananthan

Transitions the storage of world clocks and current location of user from LocalStorage to U1db.

Approved by Ubuntu Phone Apps Jenkins Bot, Riccardo Padovani.

330. By Launchpad Translations on behalf of ubuntu-clock-dev

Launchpad automatic translations update.

331. By Launchpad Translations on behalf of ubuntu-clock-dev

Launchpad automatic translations update.

332. By Michal Predotka

Added snap to digit feature and also automatically change AM/PM indicator when going past teh 12 hour mark. Fixes: https://bugs.launchpad.net/bugs/1274077, https://bugs.launchpad.net/bugs/1274127.

Approved by Ubuntu Phone Apps Jenkins Bot, Nekhelesh Ramananthan.

333. By Nekhelesh Ramananthan

Updated autopilot sqlite_dir location in light of the recent transition to u1db for local storage.

Approved by Leo Arias, Ubuntu Phone Apps Jenkins Bot.

334. By Riccardo Padovani

Updated list of cities available offline. Fixes: https://bugs.launchpad.net/bugs/1203649.

Approved by Ubuntu Phone Apps Jenkins Bot, Nekhelesh Ramananthan.

335. By Nicholas Skaggs

add sergio's tweaks to enable cmake

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
336. By Nicholas Skaggs

cmake build tweaks

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

please run wrap-and-sort -t -a to fix the whitespacing et.al. in the packaging

review: Needs Fixing
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

54 +install(DIRECTORY alarm click common images stopwatch timer DESTINATION ${DATA_DIR})

The 'click' in there is actually wrong ;-)

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

add an install file rule for ubuntu-clock-app.qml

review: Needs Fixing
337. By Nicholas Skaggs

fix packaging whitespace, sort. tweak cmake install

338. By Nicholas Skaggs

XXXth tie is the charm for cmake?

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
339. By Nicholas Skaggs

order is important for cmake. cmake is not declarative, cmake is not declarative, say it with me

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

tests seems a bit flaky, but nik90 has some tweaks he'll be landing. we'll evaluate after

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

great!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'CMakeLists.txt'
2--- CMakeLists.txt 1970-01-01 00:00:00 +0000
3+++ CMakeLists.txt 2014-02-12 23:37:01 +0000
4@@ -0,0 +1,65 @@
5+project(com.ubuntu.clock)
6+cmake_minimum_required(VERSION 2.8.9)
7+
8+# Standard install paths
9+include(GNUInstallDirs)
10+
11+option(INSTALL_TESTS "Install the tests on make install" on)
12+option(CLICK_MODE "Installs to a contained location" off)
13+
14+set(APP_NAME clock)
15+set(DESKTOP_FILE "${PROJECT_NAME}_${APP_NAME}.desktop")
16+set(URLS_FILE "${PROJECT_NAME}_${APP_NAME}.url-dispatcher")
17+set(APP_HARDCODE ubuntu-clock-app)
18+set(MAIN_QML ${APP_HARDCODE}.qml)
19+set(ICON clock64.png)
20+set(AUTOPILOT_DIR ubuntu_clock_app)
21+
22+if(CLICK_MODE)
23+ if(NOT DEFINED BZR_SOURCE)
24+ set(BZR_SOURCE "lp:${APP_HARDCODE}")
25+ message("-- Setting BZR_SOURCE to ${BZR_SOURCE}")
26+ endif(NOT DEFINED BZR_SOURCE)
27+ set(CMAKE_INSTALL_PREFIX /)
28+ set(CMAKE_INSTALL_BINDIR /)
29+ set(DATA_DIR /)
30+ set(EXEC "qmlscene ${MAIN_QML}")
31+ set(DESKTOP_DIR ${DATA_DIR})
32+ set(URLS_DIR ${DATA_DIR})
33+else(CLICK_MODE)
34+ set(DATA_DIR ${CMAKE_INSTALL_DATADIR}/${APP_HARDCODE})
35+ set(EXEC ${APP_HARDCODE})
36+ set(ICON ${CMAKE_INSTALL_PREFIX}/${DATA_DIR}/${ICON})
37+ configure_file(${APP_HARDCODE}.in
38+ ${CMAKE_CURRENT_BINARY_DIR}/${APP_HARDCODE})
39+ install(PROGRAMS ${CMAKE_CURRENT_BINARY_DIR}/${APP_HARDCODE}
40+ DESTINATION ${CMAKE_INSTALL_BINDIR})
41+ set(DESKTOP_DIR ${CMAKE_INSTALL_DATADIR}/applications)
42+ set(URLS_DIR ${CMAKE_INSTALL_DATADIR}/url-dispatcher/urls)
43+endif(CLICK_MODE)
44+
45+file(GLOB_RECURSE I18N_SRC_FILES
46+ RELATIVE ${CMAKE_CURRENT_SOURCE_DIR}
47+ rc/**.qml desktop/**.desktop.in)
48+list(SORT I18N_SRC_FILES)
49+
50+
51+file(GLOB SRC_FILES
52+ RELATIVE ${CMAKE_CURRENT_SOURCE_DIR}
53+ *.qml *.js *.png *.js)
54+install(DIRECTORY alarm clock common images stopwatch timer
55+ DESTINATION ${DATA_DIR})
56+install(FILES ${MAIN_QML} DESTINATION ${DATA_DIR})
57+
58+configure_file(${DESKTOP_FILE}.in ${CMAKE_CURRENT_BINARY_DIR}/${DESKTOP_FILE})
59+install(FILES ${CMAKE_CURRENT_BINARY_DIR}/${DESKTOP_FILE}
60+ DESTINATION ${DESKTOP_DIR})
61+
62+install(FILES ${URLS_FILE} DESTINATION ${URLS_DIR})
63+
64+# Tests
65+enable_testing()
66+
67+add_subdirectory(click)
68+add_subdirectory(po)
69+add_subdirectory(tests)
70
71=== removed directory 'apparmor'
72=== added directory 'click'
73=== added file 'click/CMakeLists.txt'
74--- click/CMakeLists.txt 1970-01-01 00:00:00 +0000
75+++ click/CMakeLists.txt 2014-02-12 23:37:01 +0000
76@@ -0,0 +1,8 @@
77+if(CLICK_MODE)
78+ if(NOT BZR_REVNO)
79+ set(BZR_REVNO "latest")
80+ endif(NOT BZR_REVNO)
81+ configure_file(manifest.json.in ${CMAKE_CURRENT_BINARY_DIR}/manifest.json)
82+ install(FILES ${CMAKE_CURRENT_BINARY_DIR}/manifest.json apparmor.json
83+ DESTINATION ${CMAKE_INSTALL_PREFIX})
84+endif(CLICK_MODE)
85
86=== renamed file 'apparmor/clock.json' => 'click/apparmor.json'
87=== renamed file 'manifest.json' => 'click/manifest.json.in'
88=== renamed file 'ubuntu-clock-app.desktop' => 'com.ubuntu.clock_clock.desktop.in'
89--- ubuntu-clock-app.desktop 2013-10-11 22:36:12 +0000
90+++ com.ubuntu.clock_clock.desktop.in 2014-02-12 23:37:01 +0000
91@@ -2,9 +2,9 @@
92 Version=1.0
93 Type=Application
94 Terminal=false
95-Exec=qmlscene /usr/share/ubuntu-clock-app/ubuntu-clock-app.qml
96-Icon=/usr/share/ubuntu-clock-app/clock64.png
97+Exec=@EXEC@
98+Icon=@ICON@
99 Name=Clock
100 X-Ubuntu-Touch=true
101 X-Ubuntu-StageHint=SideStage
102-X-Ubuntu-Gettext-Domain=com.ubuntu.clock
103+X-Ubuntu-Gettext-Domain=@PROJECT_NAME@
104
105=== renamed file 'ubuntu-clock-app.url-dispatcher' => 'com.ubuntu.clock_clock.url-dispatcher'
106=== modified file 'debian/control'
107--- debian/control 2014-01-12 00:57:48 +0000
108+++ debian/control 2014-02-12 23:37:01 +0000
109@@ -1,7 +1,8 @@
110 Source: ubuntu-clock-app
111 Priority: extra
112 Maintainer: Ubuntu App Cats <ubuntu-touch-coreapps@lists.launchpad.net>
113-Build-Depends: debhelper (>= 9),
114+Build-Depends: cmake,
115+ debhelper (>= 9),
116 gettext,
117 Standards-Version: 3.9.4
118 Section: misc
119@@ -11,13 +12,13 @@
120 Package: ubuntu-clock-app
121 Section: misc
122 Architecture: all
123-Depends: ${misc:Depends},
124- qmlscene,
125- qtdeclarative5-ubuntu-ui-toolkit-plugin | qt-components-ubuntu,
126+Depends: qmlscene,
127 qtdeclarative5-localstorage-plugin,
128- qtdeclarative5-u1db1.0,
129 qtdeclarative5-qtquick2-plugin,
130- qtdeclarative5-xmllistmodel-plugin,
131+ qtdeclarative5-u1db1.0,
132+ qtdeclarative5-ubuntu-ui-toolkit-plugin | qt-components-ubuntu,
133+ qtdeclarative5-xmllistmodel-plugin,
134+ ${misc:Depends},
135 Description: Clock application
136 Ubuntu Core Clock application which provides Stopwatch, Timer, Alarm and Clock functionalities.
137
138@@ -25,8 +26,7 @@
139 Architecture: all
140 Depends: libautopilot-qt,
141 libqt5test5,
142+ ubuntu-clock-app (= ${source:Version}),
143 ubuntu-ui-toolkit-autopilot,
144- ubuntu-clock-app (= ${source:Version}),
145 Description: Autopilot tests for Ubuntu Clock Application
146 This package contains autopilot tests for the Ubuntu Clock application.
147-
148
149=== modified file 'debian/rules'
150--- debian/rules 2013-10-10 20:29:38 +0000
151+++ debian/rules 2014-02-12 23:37:01 +0000
152@@ -6,16 +6,3 @@
153
154 %:
155 dh $@
156-
157-override_dh_install:
158- dh_install --fail-missing
159- appname=com.ubuntu.clock; \
160- debname=ubuntu-clock-app; \
161- for pofile in $(shell find ./po -name "*.po"); do \
162- pofilename="$${pofile##*/}"; \
163- langcode="$${pofilename%.*}"; \
164- localedir="debian/$$debname/usr/share/locale/$$langcode/LC_MESSAGES"; \
165- mkdir -p $$localedir; \
166- mofile="$$localedir/$$appname.mo"; \
167- msgfmt -o $$mofile $$pofile; \
168- done
169
170=== modified file 'debian/ubuntu-clock-app-autopilot.install'
171--- debian/ubuntu-clock-app-autopilot.install 2013-05-27 07:43:41 +0000
172+++ debian/ubuntu-clock-app-autopilot.install 2014-02-12 23:37:01 +0000
173@@ -1,1 +1,1 @@
174-tests/autopilot/ubuntu_clock_app/* usr/lib/python2.7/dist-packages/ubuntu_clock_app/
175+usr/lib/*/dist-packages/ubuntu_clock_app/*
176
177=== modified file 'debian/ubuntu-clock-app.install'
178--- debian/ubuntu-clock-app.install 2014-01-14 20:26:17 +0000
179+++ debian/ubuntu-clock-app.install 2014-02-12 23:37:01 +0000
180@@ -1,11 +1,2 @@
181-ubuntu-clock-app usr/bin/
182-ubuntu-clock-app.desktop usr/share/applications/
183-ubuntu-clock-app.url-dispatcher usr/share/url-dispatcher/urls/
184-*.qml usr/share/ubuntu-clock-app/
185-*.png usr/share/ubuntu-clock-app/
186-alarm usr/share/ubuntu-clock-app/
187-clock usr/share/ubuntu-clock-app/
188-common usr/share/ubuntu-clock-app/
189-images usr/share/ubuntu-clock-app/
190-stopwatch usr/share/ubuntu-clock-app/
191-timer usr/share/ubuntu-clock-app/
192+usr/bin/*
193+usr/share/*
194
195=== added file 'po/CMakeLists.txt'
196--- po/CMakeLists.txt 1970-01-01 00:00:00 +0000
197+++ po/CMakeLists.txt 2014-02-12 23:37:01 +0000
198@@ -0,0 +1,25 @@
199+include(FindGettext)
200+find_program(GETTEXT_XGETTEXT_EXECUTABLE xgettext)
201+
202+set(DOMAIN ${PROJECT_NAME})
203+set(POT_FILE ${DOMAIN}.pot)
204+file(GLOB PO_FILES *.po)
205+
206+add_custom_target(${POT_FILE}
207+ COMMAND ${GETTEXT_XGETTEXT_EXECUTABLE} -o ${POT_FILE}
208+ -D ${CMAKE_SOURCE_DIR}
209+ --from-code=UTF-8
210+ --c++ --qt --add-comments=TRANSLATORS
211+ --keyword=tr --keyword=tr:1,2
212+ --package-name='${PROJECT}'
213+ --copyright-holder='Canonical Ltd.'
214+ ${I18N_SRC_FILES})
215+
216+foreach(PO_FILE ${PO_FILES})
217+ get_filename_component(LANG ${PO_FILE} NAME_WE)
218+ gettext_process_po_files(${LANG} ALL PO_FILES ${PO_FILE})
219+ set(INSTALL_DIR ${CMAKE_INSTALL_LOCALEDIR}/${LANG}/LC_MESSAGES)
220+ install(FILES ${CMAKE_CURRENT_BINARY_DIR}/${LANG}.gmo
221+ DESTINATION ${INSTALL_DIR}
222+ RENAME ${DOMAIN}.mo)
223+endforeach(PO_FILE)
224
225=== added file 'tests/CMakeLists.txt'
226--- tests/CMakeLists.txt 1970-01-01 00:00:00 +0000
227+++ tests/CMakeLists.txt 2014-02-12 23:37:01 +0000
228@@ -0,0 +1,1 @@
229+add_subdirectory(autopilot)
230
231=== added file 'tests/autopilot/CMakeLists.txt'
232--- tests/autopilot/CMakeLists.txt 1970-01-01 00:00:00 +0000
233+++ tests/autopilot/CMakeLists.txt 2014-02-12 23:37:01 +0000
234@@ -0,0 +1,8 @@
235+if(INSTALL_TESTS)
236+execute_process(COMMAND python -c "from distutils.sysconfig import get_python_lib; print get_python_lib()"
237+ OUTPUT_VARIABLE PYTHON_PACKAGE_DIR OUTPUT_STRIP_TRAILING_WHITESPACE)
238+
239+install(DIRECTORY ${AUTOPILOT_DIR}
240+ DESTINATION ${PYTHON_PACKAGE_DIR}
241+ )
242+endif(INSTALL_TESTS)
243
244=== modified file 'tests/autopilot/ubuntu_clock_app/tests/__init__.py'
245--- tests/autopilot/ubuntu_clock_app/tests/__init__.py 2014-02-09 16:48:28 +0000
246+++ tests/autopilot/ubuntu_clock_app/tests/__init__.py 2014-02-12 23:37:01 +0000
247@@ -59,9 +59,7 @@
248 #turn off the OSK so it doesn't block screen elements
249 if model() != 'Desktop':
250 os.system("stop maliit-server")
251- # adding cleanup step seems to restart
252- # service immediately; disabling for now
253- # self.addCleanup(os.system("start maliit-server"))
254+ self.addCleanup(os.system,"start maliit-server")
255
256 if os.path.exists(self.local_location):
257 self.launch_test_local()
258@@ -81,8 +79,6 @@
259 self.app = self.launch_test_application(
260 base.get_qmlscene_launch_command(),
261 self.installed_location,
262- "--desktop_file_hint=/usr/share/applications/"
263- "ubuntu-clock-app.desktop",
264 app_type='qt',
265 emulator_base=toolkit_emulators.UbuntuUIToolkitEmulatorBase)
266
267
268=== renamed file 'ubuntu-clock-app' => 'ubuntu-clock-app.in'
269--- ubuntu-clock-app 2013-03-11 11:32:05 +0000
270+++ ubuntu-clock-app.in 2014-02-12 23:37:01 +0000
271@@ -1,2 +1,3 @@
272 #!/bin/bash
273-qmlscene /usr/share/ubuntu-clock-app/ubuntu-clock-app.qml
274+export QT_SELECT=qt5
275+qmlscene @CMAKE_INSTALL_PREFIX@/@DATA_DIR@/@MAIN_QML@

Subscribers

People subscribed via source and target branches