Merge lp:~nskaggs/ubuntu-calendar-app/skip-edit-test into lp:ubuntu-calendar-app

Proposed by Nicholas Skaggs
Status: Merged
Approved by: Leo Arias
Approved revision: 406
Merged at revision: 407
Proposed branch: lp:~nskaggs/ubuntu-calendar-app/skip-edit-test
Merge into: lp:ubuntu-calendar-app
Diff against target: 19 lines (+3/-0)
1 file modified
tests/autopilot/calendar_app/tests/test_new_event.py (+3/-0)
To merge this branch: bzr merge lp:~nskaggs/ubuntu-calendar-app/skip-edit-test
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Ubuntu Calendar Developers Pending
Review via email: mp+231606@code.launchpad.net

Commit message

Skip edit test except on desktop

Description of the change

Skip edit test except on desktop

To post a comment you must log in.
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Do not merge this mp unless a workaround is unable to be found.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)
Revision history for this message
Mihir Soni (mihirsoni) wrote :

How did this got merged ?

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Mihir this was causing the tests to loop infinitely in jenkins. We had to disable this for the image promotion #203.

Revision history for this message
Leo Arias (elopio) wrote :

I approved it because the solution took longer than expected, and it was on the toolkit so we need to wait for the next toolkit landing.

I've just reopened the calendar bug task: https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1359167

You will see linked to that bug the branch on the toolkit with the fix, and a blueprint where we track tests that are removed so we don't forget about re-adding them.

Sorry for the mess.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/calendar_app/tests/test_new_event.py'
2--- tests/autopilot/calendar_app/tests/test_new_event.py 2014-08-13 01:23:12 +0000
3+++ tests/autopilot/calendar_app/tests/test_new_event.py 2014-08-20 18:36:29 +0000
4@@ -22,6 +22,8 @@
5
6 from autopilot.matchers import Eventually
7 from testtools.matchers import Equals, NotEquals
8+from unittest import skipUnless
9+from autopilot.platform import model
10
11 from calendar_app import data
12 from calendar_app.tests import CalendarTestCase
13@@ -126,6 +128,7 @@
14 test_event.name), Eventually(
15 Equals(False)))
16
17+ @skipUnless(model() == 'Desktop', 'skipping, bug 1359167')
18 def test_edit_event_with_default_values(self):
19 """Test editing an event change unique values of an event."""
20

Subscribers

People subscribed via source and target branches

to status/vote changes: