Merge lp:~nskaggs/ubuntu-calendar-app/fix-db-path into lp:ubuntu-calendar-app

Proposed by Nicholas Skaggs
Status: Merged
Approved by: Nicholas Skaggs
Approved revision: 132
Merged at revision: 133
Proposed branch: lp:~nskaggs/ubuntu-calendar-app/fix-db-path
Merge into: lp:ubuntu-calendar-app
Diff against target: 13 lines (+1/-2)
1 file modified
tests/autopilot/calendar_app/tests/__init__.py (+1/-2)
To merge this branch: bzr merge lp:~nskaggs/ubuntu-calendar-app/fix-db-path
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Ubuntu Calendar Developers Pending
Review via email: mp+189140@code.launchpad.net

Commit message

update the hardcoded db path so autopilot tests can continue to work

Description of the change

Fix https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1234544, update the hardcoded db path so autopilot tests can continue to work

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Loïc Minier (lool) wrote :

Could you get the name from Qt/SDK instead of harcoding it? Otherwise we have to ensure the test and the updated SDK land at exactly the same time, and if the location changes again, it will break again.

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Loïc, long term the plan is to push this as a property into the uitk emulator, along with much of the other stuff in the __init__.py file (hopefully!).

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/calendar_app/tests/__init__.py'
2--- tests/autopilot/calendar_app/tests/__init__.py 2013-10-01 17:38:51 +0000
3+++ tests/autopilot/calendar_app/tests/__init__.py 2013-10-03 17:28:41 +0000
4@@ -45,8 +45,7 @@
5
6 local_location = "../../calendar.qml"
7 installed_location = "/usr/share/calendar-app/calendar.qml"
8- sqlite_dir = os.path.expanduser(
9- "~/.local/share/Qt Project/QtQmlViewer/QML/OfflineStorage/Databases")
10+ sqlite_dir = os.path.expanduser("~/.local/share/calendar-app/Databases")
11 backup_dir = sqlite_dir + ".backup"
12
13 def setUp(self):

Subscribers

People subscribed via source and target branches

to status/vote changes: