Ubuntu Calendar App

Merge lp:~nskaggs/ubuntu-calendar-app/add-waits-for-selects into lp:ubuntu-calendar-app

  1. add-waits-for-selects
  2. Merge into trunk
Proposed by Nicholas Skaggs
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 🦄
Approved revision: 652
Merged at revision: 651
Proposed branch: lp:~nskaggs/ubuntu-calendar-app/add-waits-for-selects
Merge into: lp:ubuntu-calendar-app
Diff against target: 56 lines (+13/-9)
1 file modified
tests/autopilot/calendar_app/__init__.py (+13/-9)
To merge this branch: bzr merge lp:~nskaggs/ubuntu-calendar-app/add-waits-for-selects
Reviewer Review Type Date Requested Status
Alan Pope 🍺🐧🐱 🦄 (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+259932@code.launchpad.net

Commit message

Fix for object not found when changing UI

Description of the change

Fix for object not found when changing UI

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:652
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1172/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2807
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2807/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/643
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/169

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1172/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/calendar_app/__init__.py'
2--- tests/autopilot/calendar_app/__init__.py 2015-04-29 19:59:13 +0000
3+++ tests/autopilot/calendar_app/__init__.py 2015-05-22 14:33:59 +0000
4@@ -174,39 +174,43 @@
5 def get_event_view(self, parent_object=None):
6 if parent_object is None:
7 parent_object = self
8- return parent_object.select_single("EventView")
9+ return parent_object.wait_select_single("EventView")
10
11 def get_event_details(self, parent_object=None):
12 if parent_object is None:
13 parent_object = self
14- return parent_object.select_single(EventDetails,
15- objectName='eventDetails')
16+ return parent_object.wait_select_single(EventDetails,
17+ objectName='eventDetails')
18
19 def get_month_view(self, parent_object=None):
20 if parent_object is None:
21 parent_object = self
22- return parent_object.select_single(MonthView,
23- objectName='monthViewPage')
24+ return parent_object.wait_select_single(MonthView,
25+ objectName='monthViewPage')
26
27 def get_year_view(self, parent_object=None):
28 if parent_object is None:
29 parent_object = self
30- return parent_object.select_single(YearView, objectName='yearViewPage')
31+ return parent_object.wait_select_single(YearView,
32+ objectName='yearViewPage')
33
34 def get_day_view(self, parent_object=None):
35 if parent_object is None:
36 parent_object = self
37- return parent_object.select_single(DayView, objectName='dayViewPage')
38+ return parent_object.wait_select_single(DayView,
39+ objectName='dayViewPage')
40
41 def get_week_view(self, parent_object=None):
42 if parent_object is None:
43 parent_object = self
44- return parent_object.select_single(WeekView, objectName='weekViewPage')
45+ return parent_object.wait_select_single(WeekView,
46+ objectName='weekViewPage')
47
48 def get_agenda_view(self, parent_object=None):
49 if parent_object is None:
50 parent_object = self
51- return parent_object.select_single(AgendaView, objectName='AgendaView')
52+ return parent_object.wait_select_single(AgendaView,
53+ objectName='AgendaView')
54
55 def get_label_with_text(self, text, root=None):
56 if root is None:

Subscribers

People subscribed via source and target branches

to status/vote changes: