Ubuntu Calculator App

Merge lp:~nskaggs/ubuntu-calculator-app/disable-osk-autopilot into lp:~ubuntu-calculator-dev/ubuntu-calculator-app/old_trunk

Proposed by Nicholas Skaggs on 2013-09-17

Status:	Merged
Approved by:	Riccardo Padovani on 2013-09-17
Approved revision:	154
Merged at revision:	153
Proposed branch:	lp:~nskaggs/ubuntu-calculator-app/disable-osk-autopilot
Merge into:	lp:~ubuntu-calculator-dev/ubuntu-calculator-app/old_trunk
Diff against target:	17 lines (+7/-0) 1 file modified tests/autopilot/ubuntu_calculator_app/tests/__init__.py (+7/-0)
To merge this branch:	bzr merge lp:~nskaggs/ubuntu-calculator-app/disable-osk-autopilot
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Riccardo Padovani		2013-09-17	Approve on 2013-09-17
Ubuntu Phone Apps Jenkins Bot	continuous-integration		Approve on 2013-09-17
Review via email: mp+186042@code.launchpad.net

Prevent autopilot tests from failing due to OSK bugs on actual devices by disabling OSK during runtime

Prevent autopilot tests from failing due to OSK bugs on actual devices by disabling OSK during runtime

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2013-09-17:

review: Needs Fixing (continuous-integration)

154. By Nicholas Skaggs on 2013-09-17: make sure pyflakes and pep8 are happy :-)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2013-09-17:

FAILED: Continuous integration, rev:154
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/96/
Executed test runs:

review: Needs Fixing (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2013-09-17:

review: Approve (continuous-integration)

Revision history for this message

Riccardo Padovani (rpadovani) wrote on 2013-09-17:

Thanks :)

review: Approve

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

People subscribed via source and target branches

to all changes:

 === modified file 'tests/autopilot/ubuntu_calculator_app/tests/__init__.py'
 --- tests/autopilot/ubuntu_calculator_app/tests/__init__.py	2013-08-23 17:28:52 +0000
 +++ tests/autopilot/ubuntu_calculator_app/tests/__init__.py	2013-09-17 14:24:48 +0000
@@ -43,6 +43,13 @@
          self.temp_move_sqlite_db()
          self.addCleanup(self.restore_sqlite_db)
++        #turn off the OSK so it doesn't block screen elements
++        if model() != 'Desktop':
++            os.system("stop maliit-server")
++            #adding cleanup step seems to restart service immeadiately
++            #disabling for now
++            #self.addCleanup(os.system("start maliit-server"))
++
          if os.path.exists(self.local_location):
              self.launch_test_local()
          else: