Merge lp:~nskaggs/ubuntu-calculator-app/add-min-press-time into lp:ubuntu-calculator-app

[Nicholas Skaggs]

add min press duration so tests don't randomly fail

Make Riccardo happy :-)

Ohh, and also add a min press duration so tests don't randomly fail.

I believe what is sometimes happening is that the press time is/was effectively microseconds long and the UI doesn't have a chance to respond. Likely the migration to bignumber showed this as it seemed to occur for me when hitting '='. I assume the slightly longer overhead for calculations showed through causing bignumber to fail, while the original did not, despite the only difference being the math engine.

[Riccardo Padovani (rpadovani)]

Makes sense, thanks :-)

review: Approve

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

review: Approve (continuous-integration)

=== modified file 'app/tests/autopilot/ubuntu_calculator_app/__init__.py'
--- app/tests/autopilot/ubuntu_calculator_app/__init__.py	2015-01-13 15:42:30 +0000
+++ app/tests/autopilot/ubuntu_calculator_app/__init__.py	2015-01-29 22:25:50 +0000
@@ -17,6 +17,7 @@
 """Calculator app autopilot emulators."""
 
 import ubuntuuitoolkit
+from time import sleep
 
 
 class CalculatorApp(object):
@@ -98,10 +99,11 @@
         # using a larger press_duration for click_object would be inferior
         # as it would cause longer delays (we are forced to arbitrarily decide
         # how long to press each time) and potentially fail.
-        # Also, https://bugs.launchpad.net/autopilot/+bug/1366949
-        # causes press_duration argument to be ignored currently
-        # balloons 2014-09-08
+        # balloons 2015-01-29
         self.pointing_device.press()
+        # this sleeps represents our minimum press time,
+        # should button_area.pressed be true without any wait
+        sleep(0.3)
         button_area.pressed.wait_for(True)
         self.pointing_device.release()