Merge lp:~nskaggs/ubuntu-calculator-app/1324476 into lp:~ubuntu-calculator-dev/ubuntu-calculator-app/old_trunk

Proposed by Nicholas Skaggs
Status: Merged
Approved by: Nicholas Skaggs
Approved revision: 277
Merged at revision: 276
Proposed branch: lp:~nskaggs/ubuntu-calculator-app/1324476
Merge into: lp:~ubuntu-calculator-dev/ubuntu-calculator-app/old_trunk
Diff against target: 17 lines (+3/-6)
1 file modified
tests/autopilot/ubuntu_calculator_app/emulators.py (+3/-6)
To merge this branch: bzr merge lp:~nskaggs/ubuntu-calculator-app/1324476
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Nicholas Skaggs Pending
Ubuntu Phone Apps Jenkins Bot continuous-integration Pending
Review via email: mp+221572@code.launchpad.net

This proposal supersedes a proposal from 2014-05-29.

Commit message

Fixed an AP test that didn't work on devices

Description of the change

Fixed an AP test that didn't work on devices
Also fix flake8 error from original MP :-)

To post a comment you must log in.
Revision history for this message
Nicholas Skaggs (nskaggs) wrote : Posted in a previous version of this proposal

Fixes the swipe issue on my device.

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.
https://code.launchpad.net/~nskaggs/ubuntu-calculator-app/1324476/+merge/221572/+edit-commit-message

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/ubuntu_calculator_app/emulators.py'
2--- tests/autopilot/ubuntu_calculator_app/emulators.py 2014-05-22 15:02:19 +0000
3+++ tests/autopilot/ubuntu_calculator_app/emulators.py 2014-05-30 17:40:33 +0000
4@@ -268,10 +268,7 @@
5
6 def confirm_delete(self):
7 """Confirm the deletion of the calculation."""
8- """Move on the icon to click"""
9- x, y, w, h = self.globalRect
10- tx = x + (w - w / 3)
11- ty = y + (h / 2)
12- self.pointing_device.move(tx, ty)
13+ delete_item = self.select_single(
14+ 'QQuickItem', objectName='confirmRemovalDialog')
15 """Click the icon"""
16- self.pointing_device.click()
17+ self.pointing_device.click_object(delete_item)

Subscribers

People subscribed via source and target branches