Merge lp:~nskaggs/sudoku-app/settings-ap-fix into lp:sudoku-app

Proposed by Nicholas Skaggs
Status: Merged
Approved by: Nicholas Skaggs
Approved revision: 173
Merged at revision: 172
Proposed branch: lp:~nskaggs/sudoku-app/settings-ap-fix
Merge into: lp:sudoku-app
Diff against target: 23 lines (+3/-1)
1 file modified
tests/autopilot/sudoku_app/tests/test_sudoku.py (+3/-1)
To merge this branch: bzr merge lp:~nskaggs/sudoku-app/settings-ap-fix
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Sudoku Touch developers Pending
Review via email: mp+210945@code.launchpad.net

Commit message

add wait to avoid issue with clicking manage profile button during testing

Description of the change

Properly fix timing bug for AP tests

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/sudoku_app/tests/test_sudoku.py'
2--- tests/autopilot/sudoku_app/tests/test_sudoku.py 2014-03-13 21:04:56 +0000
3+++ tests/autopilot/sudoku_app/tests/test_sudoku.py 2014-03-14 00:16:00 +0000
4@@ -275,6 +275,8 @@
5 sudokuAddProfile = self.main_view.get_add_profile()
6 self.pointing_device.click_object(sudokuAddProfile)
7
8+ sudokuAddProfileDialog = self.main_view.get_add_profile_dialog()
9+
10 #insert Lastname
11 lastName = self.main_view.get_add_profile_Lastname_field()
12 self.pointing_device.click_object(lastName)
13@@ -295,10 +297,10 @@
14 OKButton = self.main_view.get_add_profile_OKbutton()
15 self.assertThat(OKButton.buttonText, Eventually(Equals("OK")))
16 self.pointing_device.click_object(OKButton)
17+ sudokuAddProfileDialog.wait_until_destroyed()
18
19 #******** check manage profiles ********
20 #select manage profile
21- self.main_view.switch_to_tab("settingsTab")
22 manageProfile = self.main_view.get_manage_profiles()
23 self.pointing_device.click_object(manageProfile)
24

Subscribers

People subscribed via source and target branches