Merge lp:~nskaggs/reminders-app/fix-new-pep8 into lp:reminders-app

[Nicholas Skaggs]

Update pep8 compliance

Update pep8 compliance

[Leo Arias (elopio)]

review: Approve

[Leo Arias (elopio)]

Sorry for the bad review.

According to pep257, There's no blank line either before or after the docstring.

review: Needs Fixing

[Leo Arias (elopio)]

It also says:
Insert a blank line before and after all docstrings (one-line or multi-line) that document a class

I need a break :D

review: Approve

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/reminders-app-autolanding/164/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/649
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/649/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-autolanding/56

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:166
http://91.189.93.70:8080/job/reminders-app-ci/415/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/653
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/653/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/110

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/415/rebuild

review: Approve (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/reminders-app-autolanding/165/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/654
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/654/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-autolanding/57

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

review: Approve (continuous-integration)

=== modified file 'tests/autopilot/reminders/__init__.py'
--- tests/autopilot/reminders/__init__.py	2014-06-24 00:01:51 +0000
+++ tests/autopilot/reminders/__init__.py	2014-06-25 23:03:01 +0000
@@ -33,10 +33,12 @@
 
 
 class RemindersAppException(Exception):
+
     """Exception raised when there's an error in the Reminders App."""
 
 
 class RemindersApp(object):
+
     """Autopilot helper object for the Reminders application."""
 
     def __init__(self, app_proxy):
@@ -55,6 +57,7 @@
 
 
 class MainView(toolkit_emulators.MainView):
+
     """Autopilot custom proxy object for the MainView."""
 
     def __init__(self, *args):
@@ -76,6 +79,7 @@
 
 
 class NoAccountDialog(toolkit_emulators.UbuntuUIToolkitEmulatorBase):
+
     """Autopilot custom proxy object for the no account dialog."""
 
     @classmethod
@@ -110,10 +114,12 @@
 
 
 class PulldownListView(ubuntuuitoolkit.QQuickListView):
+
     """Autopilot custom proxy object for the PulldownListView."""
 
 
 class NotebooksPage(_Page):
+
     """Autopilot custom proxy object for the Notebooks page."""
 
     def add_notebook(self, title):
@@ -164,6 +170,7 @@
 
 
 class NotebooksDelegate(toolkit_emulators.UbuntuUIToolkitEmulatorBase):
+
     """Autopilot custom proxy object for the NotebooksDelegate."""
 
     def get_title(self):

=== modified file 'tests/autopilot/reminders/credentials.py'
--- tests/autopilot/reminders/credentials.py	2014-05-14 16:18:22 +0000
+++ tests/autopilot/reminders/credentials.py	2014-06-25 23:03:01 +0000
@@ -21,10 +21,12 @@
 
 
 class CredentialsException(Exception):
+
     """Exception for credentials problems."""
 
 
 class AccountManager(object):
+
     """Manager for online accounts."""
 
     def __init__(self):

=== modified file 'tests/autopilot/reminders/evernote.py'
--- tests/autopilot/reminders/evernote.py	2014-05-15 07:02:41 +0000
+++ tests/autopilot/reminders/evernote.py	2014-06-25 23:03:01 +0000
@@ -30,6 +30,7 @@
 
 
 class SandboxEvernoteClient(client.EvernoteClient):
+
     """Client to access the Evernote API on the sandbox server."""
 
     def __init__(self):

=== modified file 'tests/autopilot/reminders/fake_services.py'
--- tests/autopilot/reminders/fake_services.py	2014-04-24 19:26:51 +0000
+++ tests/autopilot/reminders/fake_services.py	2014-06-25 23:03:01 +0000
@@ -25,6 +25,7 @@
 
 
 class FakeURLDispatcherService(object):
+
     """Fake URL Dispatcher service using a dbusmock interface."""
 
     def __init__(self):

=== modified file 'tests/autopilot/reminders/tests/__init__.py'
--- tests/autopilot/reminders/tests/__init__.py	2014-05-23 07:11:23 +0000
+++ tests/autopilot/reminders/tests/__init__.py	2014-06-25 23:03:01 +0000
@@ -36,6 +36,7 @@
 
 
 class RemindersAppTestCase(AutopilotTestCase):
+
     """A common test case class that provides several useful methods for
        reminders-app tests."""
 
@@ -90,14 +91,14 @@
         temp_dir = temp_dir_fixture.path
         temp_xdg_config_home = os.path.join(temp_dir, '.config')
 
-        #If running under xvfb, as jenkins does,
-        #xsession will fail to start without xauthority file
-        #Thus if the Xauthority file is in the home directory
-        #make sure we copy it to our temp home directory
+        # If running under xvfb, as jenkins does,
+        # xsession will fail to start without xauthority file
+        # Thus if the Xauthority file is in the home directory
+        # make sure we copy it to our temp home directory
         self._copy_xauthority_file(temp_dir)
 
-        #click requires using initctl env (upstart), but the desktop can set
-        #an environment variable instead
+        # click requires using initctl env (upstart), but the desktop can set
+        # an environment variable instead
         if test_type == 'click':
             self.useFixture(
                 toolkit_fixtures.InitctlEnvironmentVariable(

=== modified file 'tests/autopilot/reminders/tests/test_evernote.py'
--- tests/autopilot/reminders/tests/test_evernote.py	2014-05-15 07:02:41 +0000
+++ tests/autopilot/reminders/tests/test_evernote.py	2014-06-25 23:03:01 +0000
@@ -24,6 +24,7 @@
 
 
 class EvernoteTestCase(testtools.TestCase):
+
     """Test the evernote access with the SDK."""
 
     def setUp(self):

=== modified file 'tests/autopilot/reminders/tests/test_reminders.py'
--- tests/autopilot/reminders/tests/test_reminders.py	2014-05-15 07:02:41 +0000
+++ tests/autopilot/reminders/tests/test_reminders.py	2014-06-25 23:03:01 +0000
@@ -96,7 +96,7 @@
         # TODO there's a bug with the last updated value: http://pad.lv/1318751
         # so we can't check the full tuple. Uncomment this as soon as the bug
         # is fixed. --elopio - 2014-05-12
-        #self.assertEqual(
+        # self.assertEqual(
         #    last_notebook,
         #    (test_notebook_title, 'Last edited today', 'Private', 0))
         self.assertEqual(last_notebook[0], test_notebook_title)