Merge lp:~nskaggs/reminders-app/fix-1347905 into lp:reminders-app

[Nicholas Skaggs]

Re-enable tests for running on device

Add account-plugin-evernote-sandbox as depends for autopilot tests, re-enable testcases

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:205
http://91.189.93.70:8080/job/reminders-app-ci/473/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1207
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1207/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/169

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/473/rebuild

review: Approve (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:206
http://91.189.93.70:8080/job/reminders-app-ci/474/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1213
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1213/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/170

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/474/rebuild

review: Approve (continuous-integration)

[Omer Akram (om26er)]

tests are failing on my desktop, though I guess not really related to this branch ?

http://paste.ubuntu.com/7952459/

[David Planella (dpm)]

Omer, the tests failing might be related to bug 1351041

On Mon, Aug 4, 2014 at 4:48 PM, Omer Akram <email address hidden> wrote:

> tests are failing on my desktop, though I guess not really related to this
> branch ?
>
> http://paste.ubuntu.com/7952459/
> --
> https://code.launchpad.net/~nskaggs/reminders-app/fix-1347905/+merge/228917
> Your team Ubuntu Reminders app developers is requested to review the
> proposed merge of lp:~nskaggs/reminders-app/fix-1347905 into
> lp:reminders-app.
>

[Nicholas Skaggs (nskaggs)]

Wow, what timing. Thanks for the link and heads up David.

[Omer Akram (om26er)]

change looks good.

review: Approve (code)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/reminders-app-autolanding/231/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1280
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1280/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-autolanding/123

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

review: Approve (continuous-integration)

=== modified file 'debian/control'
--- debian/control	2014-07-03 18:40:37 +0000
+++ debian/control	2014-07-30 21:30:35 +0000
@@ -72,5 +72,6 @@
          python3-oauthlib,
          python3-requests-oauthlib,
          ubuntu-ui-toolkit-autopilot,
+         account-plugin-evernote-sandbox
 Description: Test package for the Reminders app
  Autopilot tests for the Reminders app package

=== modified file 'manifest.json'
--- manifest.json	2014-07-24 06:54:22 +0000
+++ manifest.json	2014-07-30 21:30:35 +0000
@@ -20,7 +20,7 @@
    "x-test": {
            "autopilot": {
                 "autopilot_module": "@AUTOPILOT_DIR@",
-                "depends": ["python3-dbus", "python3-dbusmock", "python3-fixtures", "python3-oauthlib", "python3-requests-oauthlib"]
+                "depends": ["python3-dbus", "python3-dbusmock", "python3-fixtures", "python3-oauthlib", "python3-requests-oauthlib", "account-plugin-evernote-sandbox"]
             }
    }
 }

=== modified file 'tests/autopilot/reminders/tests/test_credentials.py'
--- tests/autopilot/reminders/tests/test_credentials.py	2014-07-24 21:30:46 +0000
+++ tests/autopilot/reminders/tests/test_credentials.py	2014-07-30 21:30:35 +0000
@@ -18,7 +18,6 @@
 
 from gi.repository import Accounts
 from testtools.matchers import HasLength
-from autopilot import platform
 
 from reminders import credentials, evernote, tests
 
@@ -29,9 +28,6 @@
 class EvernoteCredentialsTestCase(tests.BaseTestCaseWithTempHome):
 
     def setUp(self):
-        # bug https://bugs.launchpad.net/reminders-app/+bug/1347905
-        if platform.model() != 'Desktop':
-            self.skipTest("Fake Account failure bug 1347905")
         super(EvernoteCredentialsTestCase, self).setUp()
         self.account_manager = credentials.AccountManager()
 

=== modified file 'tests/autopilot/reminders/tests/test_reminders.py'
--- tests/autopilot/reminders/tests/test_reminders.py	2014-07-25 17:27:49 +0000
+++ tests/autopilot/reminders/tests/test_reminders.py	2014-07-30 21:30:35 +0000
@@ -64,9 +64,6 @@
 class RemindersTestCaseWithAccount(tests.RemindersAppTestCase):
 
     def setUp(self):
-        # bug https://bugs.launchpad.net/reminders-app/+bug/1347905
-        if platform.model() != 'Desktop':
-            self.skipTest("Fake Account failure bug 1347905")
         super(RemindersTestCaseWithAccount, self).setUp()
         no_account_dialog = self.app.main_view.no_account_dialog
         self.add_evernote_account()