Code review comment for lp:~nskaggs/phablet-tools/fix-1371241

17:14 <brendand> cjwatson, i *think* you approve?
17:14 <cjwatson> brendand: no, the second half makes sense now but I remain unconvinced by the first half
17:14 <cjwatson> see the bit where I say "*not*"
17:15 <brendand> cjwatson, so why do we care about a package already in the image?
17:15 <cjwatson> that's the question I asked
17:15 <brendand> cjwatson, we want to get the tarball of autopilot tests which match that version
17:16 <cjwatson> brendand: That makes sense for get_source_package_tests. What about get_python_binary_package?
17:16 <cjwatson> There are two quite different functions being changed here.
17:16 <cjwatson> get_python_binary_package does not nominate a specific version, so there is clearly no version-matching going on.
17:17 <cjwatson> It looks to me as though get_python_binary_package just wants basically the latest published thing that apt would give you. If that's correct then removing these restrictions is wrong.
17:19 <brendand> cjwatson, i wasn't expecting get_python_binary_package to be changed so i overlooked that
17:19 <cjwatson> (Because it's possible for a newer version to be removed and then deleted; or for a version to be in -proposed that hasn't yet made it to the release pocket because it fails autopkgtests or something; or ...)
17:19 <brendand> cjwatson, perhaps balloons_ can comment on that
17:19 <cjwatson> I'll copy and paste this into the MP to clarify