Code review comment for lp:~nskaggs/phablet-tools/fix-1371241

Revision history for this message
Colin Watson (cjwatson) wrote :

Removing those filters entirely usually isn't a good idea. This looks as though it's potentially going to have some bad consequences, including:

 * fetching packages from -proposed that have not yet been promoted to release
 * fetching deleted packages

Judging from the bug report, you just need to make sure that you get status="Pending" publications as well. Have a look at the find_newest_publication function in http://bazaar.launchpad.net/~ubuntu-archive/ubuntu-archive-tools/trunk/view/head:/lputils.py - that might be a better approach.

review: Needs Fixing

« Back to merge proposal