Merge lp:~nskaggs/music-app/manual-tests into lp:music-app
| Status: | Merged |
|---|---|
| Approved by: | Victor Thompson on 2016-01-04 |
| Approved revision: | 956 |
| Merged at revision: | 959 |
| Proposed branch: | lp:~nskaggs/music-app/manual-tests |
| Merge into: | lp:music-app |
| Diff against target: |
427 lines (+364/-0) 11 files modified
tests/manual/2015.com.ubuntu.music:music-tests/jobs/music-external.pxu (+62/-0) tests/manual/2015.com.ubuntu.music:music-tests/jobs/music-library.pxu (+131/-0) tests/manual/2015.com.ubuntu.music:music-tests/jobs/music-playlists.pxu (+73/-0) tests/manual/2015.com.ubuntu.music:music-tests/jobs/music-queue.pxu (+44/-0) tests/manual/2015.com.ubuntu.music:music-tests/jobs/music-recent.pxu (+28/-0) tests/manual/2015.com.ubuntu.music:music-tests/manage.py (+21/-0) tests/manual/2015.com.ubuntu.music:music-tests/whitelists/music-external.whitelist (+1/-0) tests/manual/2015.com.ubuntu.music:music-tests/whitelists/music-library.whitelist (+1/-0) tests/manual/2015.com.ubuntu.music:music-tests/whitelists/music-playlists.whitelist (+1/-0) tests/manual/2015.com.ubuntu.music:music-tests/whitelists/music-queue.whitelist (+1/-0) tests/manual/2015.com.ubuntu.music:music-tests/whitelists/music-recent.whitelist (+1/-0) |
| To merge this branch: | bzr merge lp:~nskaggs/music-app/manual-tests |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jenkins Bot | continuous-integration | 2015-12-16 | Approve on 2016-01-04 |
| Victor Thompson | 2015-12-16 | Approve on 2016-01-04 | |
| Andrew Hayzen | Approve on 2016-01-04 | ||
| Ubuntu Phone Apps Jenkins Bot | continuous-integration | 2015-12-16 | Pending |
| Nicholas Skaggs | Pending | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2015-09-23.
Commit Message
* Add manual tests in checkbox format to repo
Description of the Change
* Add manual tests in checkbox format to repo
This has been directly copied from the old manual tests [0]
Note that the durations are all 600 and that any notes/prerequisites I've currently put in the 1.
0 - http://
---
Andrew, this is the version that shipped with Pilot. The ideas about inline images, etc, still stands. Something to take more about with the checkbox team if we can't get it to work. For now however, these work well.
| Victor Thompson (vthompson) wrote : | # |
I noticed a few small things, but otherwise this lgtm.
| Andrew Hayzen (ahayzen) wrote : | # |
* Modify tests that use SD card to not mention krillin and include the 'only applicable'
* Add capitalisation
Please retest :-)
PASSED: Continuous integration, rev:919
http://
Executed test runs:
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Victor Thompson (vthompson) wrote : | # |
This looks good to me. I'd like to get balloon's final opinion prior to merging, however.
| Nicholas Skaggs (nskaggs) wrote : | # |
These are fine, but will need a provider and folder layout to make them plug and play. I'll bundle them and try them before providing a diff.
It's not crystal clear if we do want to include the provider in here, so perhaps these will be a-ok.
| Nicholas Skaggs (nskaggs) wrote : | # |
Prefix the tests file names with 'music-'
You are missing a colon
s/_description/
Still deciding on the provider / no provider bit.
| Nicholas Skaggs (nskaggs) wrote : | # |
Ohh my, I didn't notice the embedded links for results! Those won't play nice on the phone. Not sure what to do with them right now, other than to ensure there is text to go along with them.
It is possible to embed the image, but we are limited to text because of how QA stores the tests and processes them. It may be possible to embed them anyway though :p
| Nicholas Skaggs (nskaggs) wrote : | # |
Leaving a note on how the images would have to be embedded. We would have to change the job type, as well as package the images and reference them.
use qml type of job
include $your_file.png in the 'data' dir of the provider
reference it as Qt.resolvedUrl(
| Victor Thompson (vthompson) wrote : | # |
I'm going to hold off on reviewing this for now. Andrew, could you look into balloon's concerns?
FAILED: Continuous integration, rev:919
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
PASSED: Continuous integration, rev:956
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
| Andrew Hayzen (ahayzen) wrote : | # |
LGTM! As discussed for now we'll merge this with the image links so that Pilot can be 'in-sync' :-)


PASSED: Continuous integration, rev:918 91.189. 93.70:8080/ job/music- app-ci/ 1381/ 91.189. 93.70:8080/ job/music- app-vivid- amd64-ci/ 233
http://
Executed test runs:
SUCCESS: http://
Click here to trigger a rebuild: 91.189. 93.70:8080/ job/music- app-ci/ 1381/rebuild
http://