juju-ci-tools

Merge lp:~nskaggs/juju-ci-tools/pexpect-version-fix into lp:juju-ci-tools

  1. pexpect-version-fix
  2. Merge into trunk
Proposed by Nicholas Skaggs
Status: Merged
Merged at revision: 1408
Proposed branch: lp:~nskaggs/juju-ci-tools/pexpect-version-fix
Merge into: lp:juju-ci-tools
Diff against target: 12 lines (+1/-1)
1 file modified
requirements.txt (+1/-1)
To merge this branch: bzr merge lp:~nskaggs/juju-ci-tools/pexpect-version-fix
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email: mp+294646@code.launchpad.net

Description of the change

Add precise support by allowing lower version of pexpect

To post a comment you must log in.
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

My only question is if you prefer forcing the version, or if you are ok with versions being different according to support. I'm happy to set this as pexpect==2.4 instead.

Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'requirements.txt'
2--- requirements.txt 2016-05-06 21:31:31 +0000
3+++ requirements.txt 2016-05-13 14:08:49 +0000
4@@ -1,7 +1,7 @@
5 azure==0.8.0
6 # coverage==3.7.1
7 pywinrm==0.0.3
8-pexpect==4.0.1
9+pexpect>=2.4
10 # pyyaml==3.11
11 # mock==1.3.0
12 # launchpadlib==1.10.3

Subscribers

People subscribed via source and target branches