juju-ci-tools

Merge lp:~nskaggs/juju-ci-tools/add-grant-to-rep-tests into lp:juju-ci-tools

  1. add-grant-to-rep-tests
  2. Merge into trunk
Proposed by Nicholas Skaggs
Status: Merged
Merged at revision: 1778
Proposed branch: lp:~nskaggs/juju-ci-tools/add-grant-to-rep-tests
Merge into: lp:juju-ci-tools
Diff against target: 25 lines (+5/-1)
1 file modified
representative-tests.sh (+5/-1)
To merge this branch: bzr merge lp:~nskaggs/juju-ci-tools/add-grant-to-rep-tests
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email: mp+312183@code.launchpad.net

Description of the change

Just adding the grant revoke test to run with concurrently as part of merging. I did a quick check to ensure it will run properly: http://juju-ci.vapour.ws/view/Experiments/job/balloons-github-merge-juju/.

To post a comment you must log in.
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

We should be able to add other tests in a similar manner -- depending on what we see frequently breaks. It would be nice to have the many_operations test complete and run it in here.

Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'representative-tests.sh'
2--- representative-tests.sh 2016-10-18 21:01:35 +0000
3+++ representative-tests.sh 2016-11-30 17:18:21 +0000
4@@ -17,10 +17,13 @@
5 VERSION=$($JUJU_BIN version | cut -d '-' -f1)
6 if [[ $VERSION =~ 1\..* ]]; then
7 LXD="echo '1.x does not support lxd'"
8+ GRANT="echo '1.x does not support grant revoke'"
9 RACE="echo '1.x does not pass race unit tests'"
10 else
11 mkdir -p $WORKSPACE/artifacts/lxd
12- LXD="timeout -s INT 20m $SCRIPTS/deploy_job.py parallel-lxd $JUJU_BIN $WORKSPACE/artifacts/lxd merge-juju-lxd --series xenial --debug"
13+ mkdir -p $WORKSPACE/artifacts/grant
14+ LXD="timeout -s INT 20m $SCRIPTS/deploy_job.py parallel-lxd $JUJU_BIN $WORKSPACE/artifacts/lxd merge-juju-lxd --series xenial --debug"
15+ GRANT="timeout -s INT 20m $SCRIPTS/assess_user_grant_revoke.py parallel-lxd $JUJU_BIN $WORKSPACE/artifacts/grant merge-juju-grant --timeout 1500 --series xenial"
16 RACE="run-unit-tests m1.xlarge $XENIAL_AMI --force-archive --race --local $TARFILE_NAME --install-deps 'golang-1.6 juju-mongodb distro-info-data ca-certificates bzr git-core mercurial zip golang-1.6-race-detector-runtime'"
17 RACE="echo 'Skipping race unit tests.'"
18 fi
19@@ -28,5 +31,6 @@
20 trusty="$SCRIPTS/run-unit-tests c3.4xlarge $TRUSTY_AMI --local $TARFILE_NAME --use-tmpfs --force-archive" \
21 windows="$SCRIPTS/gotestwin.py developer-win-unit-tester.vapour.ws $TARFILE_NAME github.com/juju/juju/cmd" \
22 lxd="$LXD" \
23+ grant="$GRANT" \
24 race="$RACE"\
25 tarball="$SCRIPTS/check_tar.py $SCRIPTS/tested-public-clouds $TARFILE"

Subscribers

People subscribed via source and target branches