Merge lp:~nskaggs/help-app/functional-test-template into lp:help-app

[Nicholas Skaggs]

Add basic skeleton structure for adding functional tests

Add basic skeleton structure for adding functional tests

[lp:~nskaggs/help-app/functional-test-template]

144. By Nicholas Skaggs on 2015-05-26

fix unwanted whitespace diffs

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:144
http://91.189.93.70:8080/job/help-app-ci/35/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/help-app-utopic-amd64-ci/35/console
    FAILURE: http://91.189.93.70:8080/job/help-app-vivid-amd64-ci/37/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/help-app-ci/35/rebuild

review: Needs Fixing (continuous-integration)

[lp:~nskaggs/help-app/functional-test-template]

145. By Nicholas Skaggs on 2015-05-26

flake8 happiness

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:145
http://91.189.93.70:8080/job/help-app-ci/36/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/help-app-utopic-amd64-ci/36
    SUCCESS: http://91.189.93.70:8080/job/help-app-vivid-amd64-ci/38

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/help-app-ci/36/rebuild

review: Approve (continuous-integration)

[Daniel Holbach (dholbach)]

Hum... do you know if a newer version of selenium is being put into Ubuntu too?

[Daniel Holbach (dholbach)]

This generally looks good, we might just want to add selenium to build-deps, etc and run it as part of the build.

review: Needs Information

[Daniel Holbach (dholbach)]

Looks like https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=770232 is the way we're going.

[Nicholas Skaggs (nskaggs)]

Yes, the QA folks are trying to get properly updated packages into the archive so the ppa isn't needed.

I agree on running it as part of the build, and I'd also like to put the current tests into a 'unit' testing folder perhaps?

[Daniel Holbach (dholbach)]

Hum... where exactly would you like to move tests to?

[Nicholas Skaggs (nskaggs)]

internals/tests/*.py -> internals/tests/unit

[Daniel Holbach (dholbach)]

Is this going to make anything easier?

I had a bit of a hard time moving everything around because of imports and from which path certain scripts needed to be run.

[Daniel Holbach (dholbach)]

Please note: I'm not rejecting your idea, I'm just trying to understand which problem we're solving. :-)

[Nicholas Skaggs (nskaggs)]

Yes, not in this MP regardless, lol. I guess I'll stop talking. This MP has everything in it I'd like to merge at the moment :-)

[Daniel Holbach (dholbach)]

In the HACKING doc, the "cd /...." command isn't quite right, ie remove the leading '/'.

Also: http://pastebin.ubuntu.com/11413858/

Would this also work with launching the 'web' version?

review: Needs Fixing

[lp:~nskaggs/help-app/functional-test-template]

146. By Nicholas Skaggs on 2015-05-28

fix hacking guide

147. By Nicholas Skaggs on 2015-05-28

initial modification to add helper and multiple testsuites for web and app

148. By Nicholas Skaggs on 2015-05-28

initial version

149. By Nicholas Skaggs on 2015-05-28

flake8 happiness

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:149
http://91.189.93.70:8080/job/help-app-ci/37/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/help-app-utopic-amd64-ci/37
    SUCCESS: http://91.189.93.70:8080/job/help-app-vivid-amd64-ci/39

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/help-app-ci/37/rebuild

review: Approve (continuous-integration)

[Daniel Holbach (dholbach)]

How can the two sets of tests (app vs web) be launched separately from each other?

review: Needs Information

[Nicholas Skaggs (nskaggs)]

Yes, you can launch just app or web if you wish.

autopilot3 run help_app.tests.test_app_launch.LaunchTestApp
autopilot3 run help_app.tests.test_app_launch.LaunchTestWeb

However, this doesn't let you do

autopilot3 run help_app.tests.test_app
autopilot3 run help_app.tests.test_web

For that we would need to put them in separate source files. The downside is all the tests would end up in the same file.

[Daniel Holbach (dholbach)]

We had some code in the unit tests already to perform a 'web' or 'app' build in a tempdir already, so I attempted to make that available for the functional tests too, but it's not quite working yet... do you think you have some free cycles? lp:~dholbach/help-app/functional-test-template-improvements

[Daniel Holbach (dholbach)]

Coming to think of it... let's make this part of a separate bug.

review: Approve

[Daniel Holbach (dholbach)]

I filed bug 1461477 and bug 1461478.

=== modified file 'HACKING'
--- HACKING	2015-05-13 16:32:48 +0000
+++ HACKING	2015-05-28 20:32:44 +0000
@@ -163,6 +163,22 @@
 
 	make check
 
+Functional (autopilot / selenium) tests
+---------------------------------------
+
+Make sure that you have oxide-chromedriver and selenium installed:
+
+    sudo apt-get install oxideqt-chromedriver
+    sudo apt-add-repository ppa:canonical-platform-qa/selenium
+    sudo apt-get update
+    sudo apt-get install python3-selenium
+
+Run the tests:
+
+    cd internals/tests/functional
+    autopilot3 list help_app
+    autopilot3 run help_app
+
 Debugging
 ---------
 

=== added directory 'internals/tests/functional'
=== added directory 'internals/tests/functional/help_app'
=== added file 'internals/tests/functional/help_app/__init__.py'
--- internals/tests/functional/help_app/__init__.py	1970-01-01 00:00:00 +0000
+++ internals/tests/functional/help_app/__init__.py	2015-05-28 20:32:44 +0000
@@ -0,0 +1,14 @@
+# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
+
+
+class HelpApp(object):
+
+    """Autopilot helper object for the help app."""
+
+    def __init__(self, app_proxy):
+        self.app = app_proxy
+        self.webview = self.app.select_single('UbuntuWebView02')
+
+    @property
+    def pointing_device(self):
+        return self.app.pointing_device

=== added directory 'internals/tests/functional/help_app/tests'
=== added file 'internals/tests/functional/help_app/tests/__init__.py'
--- internals/tests/functional/help_app/tests/__init__.py	1970-01-01 00:00:00 +0000
+++ internals/tests/functional/help_app/tests/__init__.py	2015-05-28 20:32:44 +0000
@@ -0,0 +1,83 @@
+# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
+
+""" Autopilot tests """
+
+import os
+import subprocess
+
+from help_app import HelpApp
+
+from selenium import webdriver
+from selenium.webdriver.chrome.options import Options
+
+import ubuntuuitoolkit as uitk
+from ubuntuuitoolkit import fixture_setup
+
+from autopilot import platform
+from autopilot.testcase import AutopilotTestCase
+
+CURRENT_ARCHITECTURE = subprocess.check_output(
+    ["dpkg-architecture", "-qDEB_HOST_MULTIARCH"]).strip()
+CHROMEDRIVER_EXEC_PATH = \
+    "/usr/lib/{}/oxide-qt/chromedriver".format(
+        CURRENT_ARCHITECTURE.decode("utf-8"))
+DEFAULT_WEBVIEW_INSPECTOR_IP = '127.0.0.1'
+DEFAULT_WEBVIEW_INSPECTOR_PORT = 9221
+
+
+class HTML5TestCaseBase(AutopilotTestCase):
+    def setUp(self):
+        super(HTML5TestCaseBase, self).setUp()
+        if platform.model() == 'Desktop':
+            self.patch_environment(
+                'UBUNTU_WEBVIEW_DEVTOOLS_HOST',
+                DEFAULT_WEBVIEW_INSPECTOR_IP)
+            self.patch_environment(
+                'UBUNTU_WEBVIEW_DEVTOOLS_PORT',
+                str(DEFAULT_WEBVIEW_INSPECTOR_PORT))
+        else:
+            self.useFixture(fixture_setup.InitctlEnvironmentVariable(
+                global_=True,
+                UBUNTU_WEBVIEW_DEVTOOLS_HOST=DEFAULT_WEBVIEW_INSPECTOR_IP,
+                UBUNTU_WEBVIEW_DEVTOOLS_PORT=str(
+                    DEFAULT_WEBVIEW_INSPECTOR_PORT)
+            ))
+
+    def launch_webdriver(self):
+        options = Options()
+        options.binary_location = ''
+        options.debugger_address = '{}:{}'.format(
+            DEFAULT_WEBVIEW_INSPECTOR_IP,
+            DEFAULT_WEBVIEW_INSPECTOR_PORT)
+
+        return webdriver.Chrome(
+            executable_path=CHROMEDRIVER_EXEC_PATH,
+            chrome_options=options)
+
+    def launch_app(self, path):
+        return self.launch_test_application(
+            'ubuntu-html5-app-launcher',
+            '--www={}/{}'.format(
+                os.path.dirname(
+                    os.path.realpath(__file__)), path),
+            emulator_base=uitk.UbuntuUIToolkitCustomProxyObjectBase)
+
+
+class HelpAppTest(HTML5TestCaseBase):
+
+    """Testcase that launches the help app"""
+
+    def setUp(self):
+        super(HelpAppTest, self).setUp()
+        self.app = HelpApp(self.launch_app('../../../../../build/app/www'))
+        self.driver = self.launch_webdriver()
+
+
+class HelpWebTest(HTML5TestCaseBase):
+
+    """Testcase that launches the help web version"""
+
+    def setUp(self):
+        super(HelpWebTest, self).setUp()
+        self.app = HelpApp(self.launch_app('../../../../../build/web/www'))
+        self.driver = self.launch_webdriver()

=== added file 'internals/tests/functional/help_app/tests/test_app_launch.py'
--- internals/tests/functional/help_app/tests/test_app_launch.py	1970-01-01 00:00:00 +0000
+++ internals/tests/functional/help_app/tests/test_app_launch.py	2015-05-28 20:32:44 +0000
@@ -0,0 +1,16 @@
+# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
+
+from help_app.tests import HelpAppTest, HelpWebTest
+from testtools.matchers import NotEquals
+
+
+class LaunchTestApp(HelpAppTest):
+
+    def test_basic_launch(self):
+        self.assertThat(self.app, NotEquals(None))
+
+
+class LaunchTestWeb(HelpWebTest):
+
+    def test_basic_launch(self):
+        self.assertThat(self.app, NotEquals(None))