Ubuntu

Merge lp:~nottheoilrig/ubuntu/quantal/python-gnutls/fix-for-1013798 into lp:ubuntu/quantal/python-gnutls

Proposed by Jack Bates on 2013-03-21
Status: Merged
Merge reported by: Martin Pitt
Merged at revision: not available
Proposed branch: lp:~nottheoilrig/ubuntu/quantal/python-gnutls/fix-for-1013798
Merge into: lp:ubuntu/quantal/python-gnutls
Diff against target: 27 lines (+9/-0) 2 files modified
To merge this branch: bzr merge lp:~nottheoilrig/ubuntu/quantal/python-gnutls/fix-for-1013798
Reviewer Review Type Date Requested Status
Jamie Strandboge Needs Information on 2013-04-01
Dmitry Shachnev (community) Needs Information on 2013-03-21
Ubuntu branches 2013-03-21 Pending
Review via email: mp+154767@code.launchpad.net

Description of the Change

I think this bug is a problem in the Python wrapper for the GnuTLS library. The Libgcrypt manual states that:

> The function gcry_check_version initializes some subsystems used by Libgcrypt
> and must be invoked before any other function in the library, with the exception of
> the GCRYCTL_SET_THREAD_CBS command (called via the gcry_control function).

Properly initializing the library resolves this bug.

To post a comment you must log in.
Dmitry Shachnev (mitya57) wrote :

Thanks for your work here! Have you forwarded this fix to Debian/upstream?

Also, the distribution in debian/changelog should be raring, not unstable.

review: Needs Information
Jamie Strandboge (jdstrand) wrote :

Any news from upstream?

review: Needs Information
Jack Bates (nottheoilrig) wrote :

> Any news from upstream?

Hi, upstream wrote last week that they will look into it. By the way here is a blog post about this issue, and the other issue with Libgcrypt (LP: #423252)

Thanks for your help!

Jack Bates (nottheoilrig) wrote :

Hi, upstream wrote last week that they will look into it. By the way here is a blog post about this issue, and the other issue with Libgcrypt (LP: #423252)

http://jdbates.blogspot.ca/2013/04/its-crazy-how-much-time-and-effort-one.html

Thanks for your help!

Preview Diff

1=== modified file 'debian/changelog'
2--- debian/changelog 2012-04-26 21:39:12 +0000
3+++ debian/changelog 2013-03-21 17:35:24 +0000
4@@ -1,3 +1,11 @@
5+python-gnutls (1.2.4-2) unstable; urgency=low
6+
7+ * gcry_check_version must be invoked before any other function in the
8+ library, with the exception of the GCRYCTL_SET_THREAD_CBS command (called
9+ via the gcry_control function). (LP: #1013798)
10+
11+ -- Jack Bates <jack@nottheoilrig.com> Thu, 21 Mar 2013 09:56:47 -0700
12+
13 python-gnutls (1.2.4-1) unstable; urgency=low
14
15 * New upstream version.
16
17=== modified file 'gnutls/library/__init__.py'
18--- gnutls/library/__init__.py 2012-04-26 21:39:12 +0000
19+++ gnutls/library/__init__.py 2013-03-21 17:35:24 +0000
20@@ -107,6 +107,7 @@
21 gcry_control = libgnutls.gcry_control
22
23 gcry_control(GCRYCTL_SET_THREAD_CBS, c_void_p(gcrypt_thread_callbacks_ptr))
24+ libgnutls.gcry_check_version('1.2.4') # GNUTLS_MIN_LIBGCRYPT_VERSION
25 if system == 'cygwin':
26 gcry_control(GCRYCTL_DISABLE_SECMEM, 0)
27 else:

Subscribers

People subscribed via source and target branches

to all changes: