Merge lp:~notmyname/swift/simplify_setup into lp:~hudson-openstack/swift/trunk

Proposed by John Dickinson
Status: Merged
Approved by: gholt
Approved revision: 346
Merged at revision: 346
Proposed branch: lp:~notmyname/swift/simplify_setup
Merge into: lp:~hudson-openstack/swift/trunk
Diff against target: 59 lines (+0/-35)
1 file modified
setup.py (+0/-35)
To merge this branch: bzr merge lp:~notmyname/swift/simplify_setup
Reviewer Review Type Date Requested Status
Swift Core security contacts Pending
Review via email: mp+72212@code.launchpad.net

Description of the change

simplified setup.py

It contained code to automatically build a change log from bzr. We are moving to git, and we don't use this function anyway--we manually maintain the change log.

I confirmed with Monty Taylor on IRC that the openstack packagers don't use this functionality either.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'setup.py'
2--- setup.py 2011-08-11 20:17:28 +0000
3+++ setup.py 2011-08-19 16:05:24 +0000
4@@ -15,47 +15,13 @@
5 # limitations under the License.
6
7 from setuptools import setup, find_packages
8-from setuptools.command.sdist import sdist
9-import os
10-import subprocess
11-try:
12- from babel.messages import frontend
13-except ImportError:
14- frontend = None
15
16 from swift import __canonical_version__ as version
17
18
19-class local_sdist(sdist):
20- """Customized sdist hook - builds the ChangeLog file from VC first"""
21-
22- def run(self):
23- if os.path.isdir('.bzr'):
24- # We're in a bzr branch
25-
26- log_cmd = subprocess.Popen(["bzr", "log", "--gnu"],
27- stdout=subprocess.PIPE)
28- changelog = log_cmd.communicate()[0]
29- with open("ChangeLog", "w") as changelog_file:
30- changelog_file.write(changelog)
31- sdist.run(self)
32-
33-
34 name = 'swift'
35
36
37-cmdclass = {'sdist': local_sdist}
38-
39-
40-if frontend:
41- cmdclass.update({
42- 'compile_catalog': frontend.compile_catalog,
43- 'extract_messages': frontend.extract_messages,
44- 'init_catalog': frontend.init_catalog,
45- 'update_catalog': frontend.update_catalog,
46- })
47-
48-
49 setup(
50 name=name,
51 version=version,
52@@ -66,7 +32,6 @@
53 url='https://launchpad.net/swift',
54 packages=find_packages(exclude=['test', 'bin']),
55 test_suite='nose.collector',
56- cmdclass=cmdclass,
57 classifiers=[
58 'Development Status :: 4 - Beta',
59 'License :: OSI Approved :: Apache Software License',