Merge lp:~not-used-anymore-deactivatedaccount/apport/fixes-bug-1422176 into lp:~apport-hackers/apport/trunk
Status: | Merged |
---|---|
Merged at revision: | 2920 |
Proposed branch: | lp:~not-used-anymore-deactivatedaccount/apport/fixes-bug-1422176 |
Merge into: | lp:~apport-hackers/apport/trunk |
Diff against target: |
29 lines (+3/-3) 2 files modified
gtk/apport-gtk (+2/-2) gtk/apport-gtk.ui (+1/-1) |
To merge this branch: | bzr merge lp:~not-used-anymore-deactivatedaccount/apport/fixes-bug-1422176 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Martin Pitt (community) | Approve | ||
Review via email:
|
Description of the change
Rationale: In apport gui, the error icon was not showing correctly. This needs to be fixed
Fix: in gui/apport-gtk, the constants used to reference the error dialog icon were legacy (deprecated). Changed from Gtk.STOCK_
Also, in gui/apport-gtk.ui, fixed legacy icon reference 'gtk-dialog-error' to be current 'dialog-error'
Test: I could not find a way to test from the source code directory of the branch I downloaded. So, I booted up a vivid Ubuntu-Gnome instance using the LiveCD in a VM and selected "Try Ubuntu," then altered the /usr/share/
LGTM, thank you!
For the record, I usually call PYTHONPATH=. gtk/apport-gtk [args], and also running "test/run ui_gtk" cannot hurt.