Merge lp:~noskcaj/ubuntu/vivid/beautifulsoup4/merge into lp:ubuntu/vivid/beautifulsoup4

Proposed by Jackson Doak
Status: Needs review
Proposed branch: lp:~noskcaj/ubuntu/vivid/beautifulsoup4/merge
Merge into: lp:ubuntu/vivid/beautifulsoup4
Diff against target: 96 lines (+65/-1)
4 files modified
debian/changelog (+17/-0)
debian/control (+1/-1)
debian/patches/python3.4-warnings (+46/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~noskcaj/ubuntu/vivid/beautifulsoup4/merge
Reviewer Review Type Date Requested Status
Daniel Holbach (community) Approve
Review via email: mp+239651@code.launchpad.net

Description of the change

Merge from debian

To post a comment you must log in.
Revision history for this message
Daniel Holbach (dholbach) wrote :
review: Approve

Unmerged revisions

16. By Jackson Doak

* Merge from debian. Remaining changes:
  - debian/control, debian/rules: Disable pypy-bs4 and Build-Depends on
    pypy since the latter is in universe, while beautifulsoup4 is being
    pulled into main via webtest.
* Patch +python3.4-warnings: Squash new warnings under Python 3.4, fixing
  the test suite, and preparing for Python 3.5. (Closes: #765142)
* Bump Standards-Version to 3.9.6, no changes needed.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== removed file '.pc/applied-patches'
2=== modified file 'debian/changelog'
3--- debian/changelog 2014-05-29 19:50:43 +0000
4+++ debian/changelog 2014-10-26 03:02:04 +0000
5@@ -1,3 +1,20 @@
6+beautifulsoup4 (4.3.2-2ubuntu1) vivid; urgency=medium
7+
8+ * Merge from debian. Remaining changes:
9+ - debian/control, debian/rules: Disable pypy-bs4 and Build-Depends on
10+ pypy since the latter is in universe, while beautifulsoup4 is being
11+ pulled into main via webtest.
12+
13+ -- Jackson Doak <noskcaj@ubuntu.com> Sun, 26 Oct 2014 13:41:16 +1100
14+
15+beautifulsoup4 (4.3.2-2) unstable; urgency=medium
16+
17+ * Patch +python3.4-warnings: Squash new warnings under Python 3.4, fixing
18+ the test suite, and preparing for Python 3.5. (Closes: #765142)
19+ * Bump Standards-Version to 3.9.6, no changes needed.
20+
21+ -- Stefano Rivera <stefanor@debian.org> Thu, 16 Oct 2014 22:57:41 -0700
22+
23 beautifulsoup4 (4.3.2-1ubuntu1) utopic; urgency=medium
24
25 * Merge from debian. Remaining changes:
26
27=== modified file 'debian/control'
28--- debian/control 2014-05-29 19:50:43 +0000
29+++ debian/control 2014-10-26 03:02:04 +0000
30@@ -15,7 +15,7 @@
31 python3-lxml,
32 python3-pkg-resources
33 X-Python-Version: >= 2.6
34-Standards-Version: 3.9.5
35+Standards-Version: 3.9.6
36 Homepage: http://www.crummy.com/software/BeautifulSoup
37 Vcs-Svn: svn://anonscm.debian.org/python-modules/packages/beautifulsoup4/trunk/
38 Vcs-Browser: http://anonscm.debian.org/viewvc/python-modules/packages/beautifulsoup4/trunk/
39
40=== added directory 'debian/patches'
41=== added file 'debian/patches/python3.4-warnings'
42--- debian/patches/python3.4-warnings 1970-01-01 00:00:00 +0000
43+++ debian/patches/python3.4-warnings 2014-10-26 03:02:04 +0000
44@@ -0,0 +1,46 @@
45+Description: Avoid warnings under Python 3.4
46+ Python 3.5 is tidying up the HTMLParser module a bit, and 3.4 is raising some
47+ warnings in preparation for the backwards-incompatible changes.
48+ .
49+ This squashes the warnings by specifically requesting the behaviour we want.
50+ .
51+ As there were tests, checking for an absense of warnings, this also gets the
52+ test suite passing, again, under 3.4.
53+Author: Stefano Rivera <stefanor@debian.org>
54+Bug-Debian: https://bugs.debian.org/765142
55+Bug-Upstream: https://bugs.launchpad.net/beautifulsoup/+bug/1375721
56+Forwarded: https://code.launchpad.net/~stefanor/beautifulsoup/python3.4/+merge/238642
57+
58+--- a/bs4/builder/_htmlparser.py
59++++ b/bs4/builder/_htmlparser.py
60+@@ -19,10 +19,8 @@
61+ # At the end of this file, we monkeypatch HTMLParser so that
62+ # strict=True works well on Python 3.2.2.
63+ major, minor, release = sys.version_info[:3]
64+-CONSTRUCTOR_TAKES_STRICT = (
65+- major > 3
66+- or (major == 3 and minor > 2)
67+- or (major == 3 and minor == 2 and release >= 3))
68++CONSTRUCTOR_TAKES_STRICT = major == 3 and minor == 2 and release >= 3
69++CONSTRUCTOR_TAKES_CONVERT_CHARREFS = major == 3 and minor >= 4
70+
71+ from bs4.element import (
72+ CData,
73+@@ -63,7 +61,7 @@
74+
75+ def handle_charref(self, name):
76+ # XXX workaround for a bug in HTMLParser. Remove this once
77+- # it's fixed.
78++ # it's fixed. http://bugs.python.org/issue13633
79+ if name.startswith('x'):
80+ real_name = int(name.lstrip('x'), 16)
81+ elif name.startswith('X'):
82+@@ -133,6 +131,8 @@
83+ def __init__(self, *args, **kwargs):
84+ if CONSTRUCTOR_TAKES_STRICT:
85+ kwargs['strict'] = False
86++ if CONSTRUCTOR_TAKES_CONVERT_CHARREFS:
87++ kwargs['convert_charrefs'] = False
88+ self.parser_args = (args, kwargs)
89+
90+ def prepare_markup(self, markup, user_specified_encoding=None,
91
92=== added file 'debian/patches/series'
93--- debian/patches/series 1970-01-01 00:00:00 +0000
94+++ debian/patches/series 2014-10-26 03:02:04 +0000
95@@ -0,0 +1,1 @@
96+python3.4-warnings

Subscribers

People subscribed via source and target branches

to all changes: