Merge lp:~noskcaj/ubuntu/vivid/appstream-glib/mir-fixes into lp:ubuntu/vivid/appstream-glib

Proposed by Jackson Doak
Status: Merged
Approved by: Didier Roche-Tolomelli
Approved revision: 9
Merged at revision: 9
Proposed branch: lp:~noskcaj/ubuntu/vivid/appstream-glib/mir-fixes
Merge into: lp:ubuntu/vivid/appstream-glib
Diff against target: 151 lines (+60/-22)
6 files modified
debian/changelog (+10/-0)
debian/control (+2/-2)
debian/copyright (+25/-16)
debian/patches/Fix_as-needed_linking.patch (+21/-0)
debian/patches/series (+1/-0)
debian/rules (+1/-4)
To merge this branch: bzr merge lp:~noskcaj/ubuntu/vivid/appstream-glib/mir-fixes
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
Review via email: mp+249562@code.launchpad.net

Description of the change

Fix various issues preventing the packaged from being MIRed

To post a comment you must log in.
9. By Jackson Doak

add patch header

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Looking good and what was needed!

review: Approve
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Building fine with the tests, sponsoring!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== removed file '.pc/applied-patches'
2=== modified file 'debian/changelog'
3--- debian/changelog 2015-02-03 20:38:42 +0000
4+++ debian/changelog 2015-02-13 05:27:44 +0000
5@@ -1,3 +1,13 @@
6+appstream-glib (0.3.4-1ubuntu1) vivid; urgency=medium
7+
8+ * Add upstream patch to fix tests
9+ * Enable tests
10+ * Disable silent rules, allows us to see compile results
11+ * Drop unneeded libqt4-dev b-dep
12+ * Update d/copyright
13+
14+ -- Jackson Doak <noskcaj@ubuntu.com> Thu, 12 Feb 2015 19:10:42 +1100
15+
16 appstream-glib (0.3.4-1) experimental; urgency=medium
17
18 * New upstream unstable release: 0.3.4
19
20=== modified file 'debian/control'
21--- debian/control 2015-02-03 20:38:42 +0000
22+++ debian/control 2015-02-13 05:27:44 +0000
23@@ -1,7 +1,8 @@
24 Source: appstream-glib
25 Section: admin
26 Priority: optional
27-Maintainer: Matthias Klumpp <mak@debian.org>
28+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
29+XSBC-Original-Maintainer: Matthias Klumpp <mak@debian.org>
30 Build-Depends: debhelper (>= 9.0.0),
31 dh-autoreconf (>= 4),
32 gtk-doc-tools,
33@@ -11,7 +12,6 @@
34 libgirepository1.0-dev (>= 1.32),
35 libglib2.0-dev (>= 2.40),
36 libgtk-3-dev,
37- libqt4-dev,
38 libsoup2.4-dev,
39 libsqlite3-dev,
40 libxml2-dev (>= 2.8.0),
41
42=== modified file 'debian/copyright'
43--- debian/copyright 2014-09-23 16:50:18 +0000
44+++ debian/copyright 2015-02-13 05:27:44 +0000
45@@ -8,6 +8,31 @@
46 License: GPL-2+
47 LGPL-2.1+
48
49+Files: ./libappstream-glib/as-cleanup.h
50+Copyright: 2012, Colin Walters <walters@verbum.org>
51+ 2014, Richard Hughes <richard@hughsie.com>
52+License: LGPL-2.1+
53+
54+Files: ./libappstream-glib/as-utils.c
55+Copyright: 2011 Paolo Bacchilega <paobac@src.gnome.org>
56+ 2014, Richard Hughes <richard@hughsie.com>
57+License: LGPL-2.1+
58+
59+Files: ./autogen.sh
60+ ./client/as-builder.c
61+ ./client/as-util.c
62+Copyright: 2014, Richard Hughes <richard@hughsie.com>
63+License: GPL-2+
64+
65+Files: ./libappstream-builder/asb-package-alpm.*
66+Copyright: 2014, Fabien Bourigault <bourigaultfabien@gmail.com>
67+License: LGPL-2.1+
68+
69+Files: ./libappstream-builder/*
70+ ./libappstream-glib/*
71+Copyright: 2014, Richard Hughes <richard@hughsie.com>
72+License: LGPL-2.1+
73+
74 License: GPL-2+
75 This package is free software; you can redistribute it and/or modify
76 it under the terms of the GNU General Public License as published by
77@@ -41,19 +66,3 @@
78 .
79 On Debian systems, the complete text of the GNU Lesser General
80 Public License version 2.1 can be found in "/usr/share/common-licenses/LGPL-2.1".
81-
82-Files: ./libappstream-glib/as-cleanup.h
83-Copyright: 2012, Colin Walters <walters@verbum.org>
84- 2014, Richard Hughes <richard@hughsie.com>
85-License: LGPL-2.1+
86-
87-Files: ./autogen.sh
88- ./client/as-builder.c
89- ./client/as-util.c
90-Copyright: 2014, Richard Hughes <richard@hughsie.com>
91-License: GPL-2+
92-
93-Files: ./libappstream-builder/*
94- ./libappstream-glib/*
95-Copyright: 2014, Richard Hughes <richard@hughsie.com>
96-License: LGPL-2.1+
97
98=== added directory 'debian/patches'
99=== added file 'debian/patches/Fix_as-needed_linking.patch'
100--- debian/patches/Fix_as-needed_linking.patch 1970-01-01 00:00:00 +0000
101+++ debian/patches/Fix_as-needed_linking.patch 2015-02-13 05:27:44 +0000
102@@ -0,0 +1,21 @@
103+From 8fea9d934fbfffbead04a1a6ec9e4344725af188 Mon Sep 17 00:00:00 2001
104+From: Tim Lunn <tim@feathertop.org>
105+Date: Wed, 11 Feb 2015 09:11:02 +1100
106+Subject: [PATCH] tests: Fix DSO Linking error when built with --as-needed
107+
108+---
109+ libappstream-builder/Makefile.am | 1 +
110+ 1 file changed, 1 insertion(+)
111+
112+diff --git a/libappstream-builder/Makefile.am b/libappstream-builder/Makefile.am
113+index 1837487..08318ef 100644
114+--- a/libappstream-builder/Makefile.am
115++++ b/libappstream-builder/Makefile.am
116+@@ -101,6 +101,7 @@ check_PROGRAMS = \
117+ asb_self_test_SOURCES = \
118+ asb-self-test.c
119+ asb_self_test_LDADD = \
120++ $(AS_GLIB_LIBS) \
121+ $(GLIB_LIBS) \
122+ $(GDKPIXBUF_LIBS) \
123+ $(SOUP_LIBS) \
124
125=== added file 'debian/patches/series'
126--- debian/patches/series 1970-01-01 00:00:00 +0000
127+++ debian/patches/series 2015-02-13 05:27:44 +0000
128@@ -0,0 +1,1 @@
129+Fix_as-needed_linking.patch
130
131=== modified file 'debian/rules'
132--- debian/rules 2014-09-23 16:50:18 +0000
133+++ debian/rules 2015-02-13 05:27:44 +0000
134@@ -2,7 +2,7 @@
135 # -*- makefile -*-
136 #export DH_VERBOSE=1
137
138-AS_CONFIGURE_ARGS = --enable-dep11
139+AS_CONFIGURE_ARGS = --enable-dep11 --disable-silent-rules
140
141 # Define install target dir
142 INSTALLDIR = $(CURDIR)/debian/tmp
143@@ -30,8 +30,5 @@
144 rm -f $(INSTALLDIR)/usr/share/gir-1.0/AppStreamBuilder*
145 rm -f $(INSTALLDIR)/usr/share/man/man1/appstream-builder*
146
147-override_dh_auto_test:
148- # Don't run tests, they are always failing at time (20140924)
149-
150 override_dh_install:
151 dh_install --list-missing

Subscribers

People subscribed via source and target branches

to all changes: