Merge lp:~noskcaj/ubuntu/utopic/sensors-applet/merge into lp:ubuntu/utopic/sensors-applet

Proposed by Jackson Doak
Status: Needs review
Proposed branch: lp:~noskcaj/ubuntu/utopic/sensors-applet/merge
Merge into: lp:ubuntu/utopic/sensors-applet
Diff against target: 389 lines (+35/-310)
7 files modified
.pc/applied-patches (+0/-1)
.pc/enable-deprecated/configure.ac (+0/-288)
configure.ac (+1/-1)
debian/changelog (+23/-0)
debian/patches/enable-deprecated (+0/-19)
debian/patches/enable-deprecated.patch (+10/-0)
debian/patches/series (+1/-1)
To merge this branch: bzr merge lp:~noskcaj/ubuntu/utopic/sensors-applet/merge
Reviewer Review Type Date Requested Status
Daniel Holbach (community) Approve
Review via email: mp+224011@code.launchpad.net

Description of the change

Merge from debian

To post a comment you must log in.
Revision history for this message
Daniel Holbach (dholbach) wrote :

Thanks. Uploaded.

review: Approve

Unmerged revisions

28. By Jackson Doak

* Merge from debian. Remaining changes:
  - debian/rules:
    + Enable nvidia compilation flag.
  - debian/control:
    + Build-depend on nvidia-settings and update description accordingly.
* Use debian's enable-deprecated patch

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== removed file '.pc/applied-patches'
2--- .pc/applied-patches 2013-12-18 06:03:22 +0000
3+++ .pc/applied-patches 1970-01-01 00:00:00 +0000
4@@ -1,1 +0,0 @@
5-enable-deprecated
6
7=== removed directory '.pc/enable-deprecated'
8=== removed file '.pc/enable-deprecated/configure.ac'
9--- .pc/enable-deprecated/configure.ac 2013-12-18 06:03:22 +0000
10+++ .pc/enable-deprecated/configure.ac 1970-01-01 00:00:00 +0000
11@@ -1,288 +0,0 @@
12-# ================= initialization =================== #
13-
14-# if doing version bump - make sure you update sensors-applet-gconf
15-# version checking to add old version if no changes to config
16-AC_INIT([GNOME Sensors Applet], [3.0.0], [murray.alex@gmail.com],
17-[sensors-applet])
18-
19-AC_CONFIG_SRCDIR([sensors-applet/main.c])
20-AM_CONFIG_HEADER([sensors-applet/config.h])
21-AM_INIT_AUTOMAKE
22-m4_ifdef([AM_SILENT_RULES],[AM_SILENT_RULES([yes])])
23-AM_MAINTAINER_MODE
24-
25-# ============== basic compiler settings ============= #
26-AC_PROG_CC
27-AC_HEADER_STDC
28-
29-# =================== for plugins ==================== #
30-AC_PROG_LIBTOOL
31-
32-# =========== take care of some localization ========= #
33-AH_TEMPLATE([GETTEXT_PACKAGE], [Package name for gettext])
34-GETTEXT_PACKAGE=sensors-applet
35-AC_DEFINE_UNQUOTED(GETTEXT_PACKAGE, "$GETTEXT_PACKAGE")
36-AC_SUBST(GETTEXT_PACKAGE)
37-ALL_LINGUAS="cs de es fi fr hu it pl pt_BR ro ru sv zh_CN"
38-AM_GLIB_GNU_GETTEXT
39-AC_PROG_INTLTOOL
40-
41-# ========== export compiler / linker options ======== #
42-CFLAGS+=" -DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DG_DISABLE_DEPRECATED"
43-AC_SUBST(CFLAGS)
44-AC_SUBST(CPPFLAGS)
45-AC_SUBST(LDFLAGS)
46-AC_SUBST(LIBS)
47-
48-# ============== look for dependencies =============== #
49-# check for headers needed for standard interfaces
50-AC_CHECK_HEADERS(
51- stdlib.h \
52- string.h \
53- stdio.h \
54- sys/types.h \
55- sys/socket.h \
56- netinet/in.h \
57- arpa/inet.h \
58- fcntl.h \
59- sys/ioctl.h \
60- unistd.h \
61- dlfcn.h
62-)
63-
64-GLIB_REQUIRED=2.22.0
65-GTK_REQUIRED=3.4.0
66-LIBPANEL_REQUIRED=3.0.0
67-LIBNOTIFY_REQUIRED=0.3.0
68-LIBCAIRO_REQUIRED=1.0.4
69-LIBDBUSGLIB_REQUIRED=0.80
70-LIBATASMART_REQUIRED=0.16
71-
72-PKG_CHECK_MODULES(GLIB, glib-2.0 >= $GLIB_REQUIRED)
73-AC_SUBST(GLIB_CFLAGS)
74-AC_SUBST(GLIB_LIBS)
75-
76-PKG_CHECK_MODULES(GTK, gtk+-3.0 >= $GTK_REQUIRED)
77-AC_SUBST(GTK_CFLAGS)
78-AC_SUBST(GTK_LIBS)
79-
80-PKG_CHECK_MODULES(GNOME, libpanelapplet-4.0 >= $LIBPANEL_REQUIRED)
81-AC_SUBST(GNOME_CFLAGS)
82-AC_SUBST(GNOME_LIBS)
83-
84-LIBPANEL_APPLET_DIR=`$PKG_CONFIG --variable=libpanel_applet_dir libpanelapplet-4.0`
85-AC_SUBST(LIBPANEL_APPLET_DIR)
86-
87-PKG_CHECK_MODULES(CAIRO, cairo >= $LIBCAIRO_REQUIRED)
88-AC_SUBST(CAIRO_CFLAGS)
89-AC_SUBST(CAIRO_LIBS)
90-
91-# enable support for udisks (via dbus) by default if its available
92-AC_ARG_ENABLE(udisks,
93- AS_HELP_STRING([--disable-udisks],
94- [Disable support for udisks sensor readings via DBUS.]),
95- enable_udisks=$enableval, enable_udisks="yes")
96-
97-if test "x$enable_udisks" = "xno" ; then
98- echo "Disabling udisks support"
99-else
100- PKG_CHECK_MODULES(DBUSGLIB, dbus-glib-1 >= $LIBDBUSGLIB_REQUIRED,
101- HAVE_DBUSGLIB="yes", HAVE_DBUSGLIB="no")
102- AC_SUBST(DBUSGLIB_CFLAGS)
103- AC_SUBST(DBUSGLIB_LIBS)
104-
105- PKG_CHECK_MODULES(LIBATASMART, libatasmart >= $LIBATASMART_REQUIRED,
106- HAVE_LIBATASMART="yes", HAVE_LIBATASMART="no")
107- AC_SUBST(LIBATASMART_CFLAGS)
108- AC_SUBST(LIBATASMART_LIBS)
109-fi
110-
111-AM_CONDITIONAL(UDISKS, test -n "$DBUSGLIB_CFLAGS" -a -n "$LIBATASMART_CFLAGS")
112-
113-# support for libnotify
114-LIBNOTIFY_CFLAGS=
115-LIBNOTIFY_LIBS=
116-
117-# enable support even if not specifically asked for
118-AC_ARG_ENABLE(libnotify, [ --enable-libnotify enable libnotify support], [
119- enable_libnotify=$enableval], [
120- enable_libnotify="yes"
121-])
122-
123-if test "x$enable_libnotify" = "xno"
124-then
125- echo "Disabling libnotify support"
126-else
127- PKG_CHECK_MODULES(LIBNOTIFY, libnotify >= $LIBNOTIFY_REQUIRED,
128- HAVE_LIBNOTIFY="yes", HAVE_LIBNOTIFY="no")
129-
130- if test "x$HAVE_LIBNOTIFY" = "xyes"
131- then
132- AC_DEFINE(HAVE_LIBNOTIFY, 1, [libnotify available])
133- fi
134-fi
135-
136-AM_CONDITIONAL(LIBNOTIFY, test -n "$LIBNOTIFY_LIBS")
137-
138-AC_SUBST(LIBNOTIFY_CFLAGS)
139-AC_SUBST(LIBNOTIFY_LIBS)
140-
141-
142-# allow user to specify libsensors support, but support it anyway if possible
143-AC_ARG_WITH(libsensors,
144-[ --with-libsensors[=DIR] use libsensors in DIR],[
145- if test "$withval" != "no" -a "$withval" != "yes"; then
146- SENSORS_DIR=$withval
147- CPPFLAGS="${CPPFLAGS} -I${SENSORS_DIR}/include/sensors"
148- LIBS="${LIBS} -L${SENSORS_DIR}/lib"
149- fi
150- with_libsensors=$withval],[
151- with_libsensors="yes"
152-])
153-
154-if test "$with_libsensors" = "no"; then
155- echo "Disabling lmsensors support"
156-else
157- # check for specfic headers needed for libsensors-sensors-interface
158- AC_CHECK_HEADERS(regex.h)
159- AC_CHECK_HEADERS(sensors/sensors.h,
160- AC_CHECK_LIB(sensors, sensors_init,[
161- AC_DEFINE(HAVE_LIBSENSORS,1,[libsensors is available])
162- if test "x${SENSORS_DIR}" != "x"; then
163- LIBSENSORS_CFLAGS="-I${SENSORS_DIR}/include"
164- LIBSENSORS_LIBS="-L${SENSORS_DIR}/lib -lsensors"
165- [case ${host} in
166- *-*-solaris*)
167- SENSORS_LIBS="-L${SENSORS_DIR}/lib -R${SENSORS_DIR}/lib -lsensors"
168- ;;
169- esac]
170- else
171- LIBSENSORS_LIBS="-lsensors"
172- fi]))
173-fi
174-
175-AM_CONDITIONAL(LIBSENSORS, test -n "$LIBSENSORS_LIBS")
176-
177-AC_SUBST(LIBSENSORS_CFLAGS)
178-AC_SUBST(LIBSENSORS_LIBS)
179-
180-# do nvidia by default if available
181-AC_ARG_WITH(nvidia,
182-[ --with-nvidia[=DIR] use nvidia in DIR],[
183- if test "$withval" != "no" -a "$withval" != "yes"; then
184- NVIDIA_DIR=$withval
185- CFLAGS="${CFLAGS} -I${NVIDIA_DIR}/include"
186- LIBS="${LIBS} -L${NVIDIA_DIR}/lib"
187- fi
188- with_nvidia=$withval],[
189- with_nvidia="yes"
190-])
191-
192-if test "$with_nvidia" = "no"; then
193- echo "Disabling nvidia support"
194-else
195- AC_ARG_WITH(x11,
196- [ --with-x11[=DIR] use x11 in DIR],[
197- if test "$withval" != "no" -a "$withval" != "yes"; then
198- X11_DIR=$withval
199- CFLAGS="${CFLAGS} -I${X11_DIR}/include"
200- LIBS="${LIBS} -L${X11_DIR}/lib"
201- fi
202- with_x11=$withval],[
203- with_x11="yes"
204- ])
205-
206- AC_CHECK_HEADERS(X11/Xlib.h,
207- AC_CHECK_LIB(X11, XOpenDisplay, [ HAVE_X11=true ]))
208- # can't embed next AC_CHECK_HEADERS in true case of AC_CHECK_LIB
209- if test "${HAVE_X11}" = "true"; then
210- LIBS="${LIBS} -lX11 -lXext"
211- # need to specifically include X11/Xlib header when
212- # doing checks for NVCtrl headers
213- AC_CHECK_HEADERS(NVCtrl/NVCtrl.h NVCtrl/NVCtrlLib.h, [ HAVE_NVIDIA=true ], [],
214- [
215- #include <X11/Xlib.h>
216- ])
217- if test "${HAVE_NVIDIA}" = "true"; then
218- AC_CHECK_LIB(XNVCtrl, XNVCTRLQueryExtension, [
219- NVIDIA_LIBS="-lXNVCtrl"
220- AC_DEFINE(HAVE_NVIDIA,1,[nvidia sensors available])
221- ])
222- fi
223- fi
224-fi
225-AM_CONDITIONAL(NVIDIA, test -n "$NVIDIA_LIBS")
226-
227-AC_SUBST(NVIDIA_CFLAGS)
228-AC_SUBST(NVIDIA_LIBS)
229-
230-AC_ARG_WITH(aticonfig, [
231- --with-aticonfig[=PATH] use aticonfig provided by PATH], [
232- if test "$withval" != "no" -a "$withval" != "yes"; then
233- aticonfig_exe=$withval
234- else
235- aticonfig_exe=aticonfig
236- fi
237- with_aticonfig=$withval ], [
238- aticonfig_exe=aticonfig
239- with_aticonfig="check"
240-])
241-
242-if test "x$with_aticonfig" == "xcheck"; then
243- AC_CHECK_PROG(ATICONFIG_EXE, ["$aticonfig_exe"], yes, no)
244- if test "x$ATICONFIG_EXE" = "xno"; then
245- with_aticonfig="no"
246- fi
247-fi
248-
249-AM_CONDITIONAL(ATICONFIG, test "$with_aticonfig" != "no")
250-if test "$with_aticonfig" = "no"; then
251- echo "Disabling aticonfig support"
252-else
253- AC_DEFINE(HAVE_ATICONFIG,1,[using aticonfig])
254- AC_DEFINE_UNQUOTED(ATICONFIG_EXE, ["$aticonfig_exe"], [aticonfig executable])
255-fi
256-
257-AC_SUBST(CFLAGS)
258-# for help docs stuff
259-AC_PATH_PROG(XSLTPROC, xsltproc, no)
260-if test x"$XSLTPROC" = xno; then
261- AC_MSG_ERROR([xsltproc executable not found in your path - should be installed with libxslt])
262-fi
263-
264-GNOME_COMPILE_WARNINGS(maximum)
265-
266-# ================ gnome-doc-utils stuff ============= #
267-GNOME_DOC_INIT
268-
269-# ==================== plugin stuff ================== #
270-PLUGIN_LIBTOOL_FLAGS="-module -avoid-version"
271-AC_SUBST(PLUGIN_LIBTOOL_FLAGS)
272-
273-# ================= generate files =================== #
274-AC_CONFIG_FILES([
275- Makefile
276- sensors-applet/Makefile
277- lib/Makefile
278- plugins/Makefile
279- plugins/acpi/Makefile
280- plugins/udisks/Makefile
281- plugins/eee/Makefile
282- plugins/hddtemp/Makefile
283- plugins/i2c-proc/Makefile
284- plugins/i2c-sys/Makefile
285- plugins/i8k/Makefile
286- plugins/ibm-acpi/Makefile
287- plugins/libsensors/Makefile
288- plugins/mbmon/Makefile
289- plugins/nvidia/Makefile
290- plugins/aticonfig/Makefile
291- plugins/omnibook/Makefile
292- plugins/pmu-sys/Makefile
293- plugins/smu-sys/Makefile
294- plugins/sonypi/Makefile
295- pixmaps/Makefile
296- po/Makefile.in
297- help/Makefile
298-])
299-AC_OUTPUT
300
301=== modified file 'configure.ac'
302--- configure.ac 2013-12-18 06:03:22 +0000
303+++ configure.ac 2014-06-21 03:22:27 +0000
304@@ -28,7 +28,7 @@
305 AC_PROG_INTLTOOL
306
307 # ========== export compiler / linker options ======== #
308-CFLAGS+=" -DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DG_DISABLE_DEPRECATED"
309+CFLAGS+=" -DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DG_DISABLE_DEPRECATED"
310 AC_SUBST(CFLAGS)
311 AC_SUBST(CPPFLAGS)
312 AC_SUBST(LDFLAGS)
313
314=== modified file 'debian/changelog'
315--- debian/changelog 2013-12-18 06:03:22 +0000
316+++ debian/changelog 2014-06-21 03:22:27 +0000
317@@ -1,3 +1,26 @@
318+sensors-applet (3.0.0+git4-4ubuntu1) utopic; urgency=medium
319+
320+ * Merge from debian. Remaining changes:
321+ - debian/rules:
322+ + Enable nvidia compilation flag.
323+ - debian/control:
324+ + Build-depend on nvidia-settings and update description accordingly.
325+ * Use debian's enable-deprecated patch
326+
327+ -- Jackson Doak <noskcaj@ubuntu.com> Sat, 21 Jun 2014 13:00:50 +1000
328+
329+sensors-applet (3.0.0+git4-4) unstable; urgency=medium
330+
331+ * enable-deprecated.patch: avoid removing AC_SUBST(CFLAGS).
332+
333+ -- Sam Morris <sam@robots.org.uk> Mon, 17 Mar 2014 19:36:59 +0000
334+
335+sensors-applet (3.0.0+git4-3) unstable; urgency=medium
336+
337+ * Re-enable deprecated GTK etc. features again. Closes: #741791.
338+
339+ -- Sam Morris <sam@robots.org.uk> Sun, 16 Mar 2014 20:20:30 +0000
340+
341 sensors-applet (3.0.0+git4-2ubuntu2) trusty; urgency=low
342
343 * d/p/enable-deprecated: permit use of deprecated parts of GTK to fix FTBFS,
344
345=== removed file 'debian/patches/enable-deprecated'
346--- debian/patches/enable-deprecated 2013-12-18 06:03:22 +0000
347+++ debian/patches/enable-deprecated 1970-01-01 00:00:00 +0000
348@@ -1,19 +0,0 @@
349-Description: enable deprecated GTK components
350- libpanel-applet-4-dev uses GtkActionGroup which is now deprecated since a recent GTK upload, so we need to
351- stop defining GTK_DISABLE_DEPRECATED to fix the FTBFS. I presume that this is
352- rather distro-specific due to upload ordering and is not required upstream.
353-Author: Robie Basak <robie.basak@ubuntu.com>
354-Forwarded: not-needed
355-Last-Update: 2013-12-18
356-
357---- a/configure.ac
358-+++ b/configure.ac
359-@@ -28,7 +28,7 @@
360- AC_PROG_INTLTOOL
361-
362- # ========== export compiler / linker options ======== #
363--CFLAGS+=" -DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DG_DISABLE_DEPRECATED"
364-+CFLAGS+=" -DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DG_DISABLE_DEPRECATED"
365- AC_SUBST(CFLAGS)
366- AC_SUBST(CPPFLAGS)
367- AC_SUBST(LDFLAGS)
368
369=== added file 'debian/patches/enable-deprecated.patch'
370--- debian/patches/enable-deprecated.patch 1970-01-01 00:00:00 +0000
371+++ debian/patches/enable-deprecated.patch 2014-06-21 03:22:27 +0000
372@@ -0,0 +1,10 @@
373+--- a/configure.ac
374++++ b/configure.ac
375+@@ -28,7 +28,6 @@
376+ AC_PROG_INTLTOOL
377+
378+ # ========== export compiler / linker options ======== #
379+-CFLAGS+=" -DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DG_DISABLE_DEPRECATED"
380+ AC_SUBST(CFLAGS)
381+ AC_SUBST(CPPFLAGS)
382+ AC_SUBST(LDFLAGS)
383
384=== modified file 'debian/patches/series'
385--- debian/patches/series 2013-12-18 06:03:22 +0000
386+++ debian/patches/series 2014-06-21 03:22:27 +0000
387@@ -1,1 +1,1 @@
388-enable-deprecated
389+enable-deprecated.patch

Subscribers

People subscribed via source and target branches

to all changes: