Merge lp:~noskcaj/ubuntu/trusty/xfce4-settings/1289411 into lp:ubuntu/trusty/xfce4-settings

Proposed by Jackson Doak
Status: Merged
Merge reported by: Sebastien Bacher
Merged at revision: not available
Proposed branch: lp:~noskcaj/ubuntu/trusty/xfce4-settings/1289411
Merge into: lp:ubuntu/trusty/xfce4-settings
Diff against target: 86 lines (+67/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/02_versioned-help-files.patch (+59/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~noskcaj/ubuntu/trusty/xfce4-settings/1289411
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Review via email: mp+212261@code.launchpad.net

Description of the change

Fix the help function, needed for xubuntu 14.04

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks

review: Approve
Revision history for this message
Sebastien Bacher (seb128) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-02-26 07:41:42 +0000
3+++ debian/changelog 2014-03-21 22:44:40 +0000
4@@ -1,3 +1,10 @@
5+xfce4-settings (4.11.2-1ubuntu2) trusty; urgency=medium
6+
7+ * Add 02_versioned-help-files.patch. (LP: #1289411)
8+ Thanks Eric Koegel
9+
10+ -- Jackson Doak <noskcaj@ubuntu.com> Sat, 22 Mar 2014 09:20:53 +1100
11+
12 xfce4-settings (4.11.2-1ubuntu1) trusty; urgency=medium
13
14 * Merge from Debian experimental, remaining changes:
15
16=== added file 'debian/patches/02_versioned-help-files.patch'
17--- debian/patches/02_versioned-help-files.patch 1970-01-01 00:00:00 +0000
18+++ debian/patches/02_versioned-help-files.patch 2014-03-21 22:44:40 +0000
19@@ -0,0 +1,59 @@
20+Author: Eric Koegel <eric.koegel@gmail.com>
21+Bug: https://bugzilla.xfce.org/show_bug.cgi?id=10740
22+Bug-Ubuntu: https://launchpad.net/bugs/1289411
23+Description: Add support for versioned help desktop files
24+
25+---
26+ xfce4-settings-manager/xfce-settings-manager-dialog.c | 13 ++++++++++---
27+ 1 file changed, 10 insertions(+), 3 deletions(-)
28+
29+--- a/xfce4-settings-manager/xfce-settings-manager-dialog.c
30++++ b/xfce4-settings-manager/xfce-settings-manager-dialog.c
31+@@ -79,6 +79,7 @@ struct _XfceSettingsManagerDialog
32+
33+ gchar *help_page;
34+ gchar *help_component;
35++ gchar *help_version;
36+ };
37+
38+ typedef struct
39+@@ -290,6 +291,7 @@ xfce_settings_manager_dialog_finalize (G
40+
41+ g_free (dialog->help_page);
42+ g_free (dialog->help_component);
43++ g_free (dialog->help_version);
44+
45+ g_free (dialog->filter_text);
46+
47+@@ -334,9 +336,11 @@ xfce_settings_manager_dialog_response (G
48+ else
49+ help_component = "xfce4-settings";
50+
51+- xfce_dialog_show_help (GTK_WINDOW (widget),
52+- help_component,
53+- dialog->help_page, NULL);
54++ xfce_dialog_show_help_with_version (GTK_WINDOW (widget),
55++ help_component,
56++ dialog->help_page,
57++ NULL,
58++ dialog->help_version);
59+ }
60+ else
61+ {
62+@@ -599,6 +603,8 @@ xfce_settings_manager_dialog_go_back (Xf
63+ dialog->help_page = NULL;
64+ g_free (dialog->help_component);
65+ dialog->help_component = NULL;
66++ g_free (dialog->help_version);
67++ dialog->help_version = NULL;
68+
69+ gtk_widget_set_sensitive (dialog->button_back, FALSE);
70+ gtk_widget_set_sensitive (dialog->button_help, TRUE);
71+@@ -844,6 +850,7 @@ xfce_settings_manager_dialog_spawn (Xfce
72+ {
73+ dialog->help_page = g_strdup (xfce_rc_read_entry (rc, "X-XfceHelpPage", NULL));
74+ dialog->help_component = g_strdup (xfce_rc_read_entry (rc, "X-XfceHelpComponent", NULL));
75++ dialog->help_version = g_strdup (xfce_rc_read_entry (rc, "X-XfceHelpVersion", NULL));
76+ }
77+
78+ xfce_rc_close (rc);
79
80=== modified file 'debian/patches/series'
81--- debian/patches/series 2013-08-28 22:55:21 +0000
82+++ debian/patches/series 2014-03-21 22:44:40 +0000
83@@ -1,2 +1,3 @@
84 01_use-tango-icon-theme.patch
85 xubuntu_vanilla-session-themes.patch
86+02_versioned-help-files.patch

Subscribers

People subscribed via source and target branches

to all changes: