Merge lp:~noskcaj/ubuntu/trusty/ristretto/bugfix into lp:ubuntu/trusty/ristretto

Proposed by Jackson Doak
Status: Merged
Merged at revision: 26
Proposed branch: lp:~noskcaj/ubuntu/trusty/ristretto/bugfix
Merge into: lp:ubuntu/trusty/ristretto
Diff against target: 83 lines (+53/-1)
4 files modified
debian/changelog (+7/-0)
debian/control (+2/-1)
debian/patches/git-large-numbers-overflow.patch (+43/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~noskcaj/ubuntu/trusty/ristretto/bugfix
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+214368@code.launchpad.net

Description of the change

Take a patch from upstream git to stop an overflow when filenames contain large numbers

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== removed file '.pc/applied-patches'
2=== modified file 'debian/changelog'
3--- debian/changelog 2013-05-22 07:32:36 +0000
4+++ debian/changelog 2014-04-05 03:55:42 +0000
5@@ -1,3 +1,10 @@
6+ristretto (0.6.3-2ubuntu1) trusty; urgency=medium
7+
8+ * Add git-large-numbers-overflow.patch from upstream git
9+ - Fixed an overflow when comparing filenames with large numbers in them.
10+
11+ -- Jackson Doak <noskcaj@ubuntu.com> Sat, 05 Apr 2014 14:52:07 +1100
12+
13 ristretto (0.6.3-2) unstable; urgency=low
14
15 * Upload to unstable.
16
17=== modified file 'debian/control'
18--- debian/control 2012-05-05 14:54:49 +0000
19+++ debian/control 2014-04-05 03:55:42 +0000
20@@ -1,7 +1,8 @@
21 Source: ristretto
22 Section: xfce
23 Priority: optional
24-Maintainer: Debian Xfce Maintainers <pkg-xfce-devel@lists.alioth.debian.org>
25+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
26+XSBC-Original-Maintainer: Debian Xfce Maintainers <pkg-xfce-devel@lists.alioth.debian.org>
27 Uploaders: Yves-Alexis Perez <corsac@debian.org>,
28 Lionel Le Folgoc <mrpouit@gmail.com>
29 Build-Depends: debhelper (>= 9), libexif-dev, libgtk2.0-dev,
30
31=== added file 'debian/patches/git-large-numbers-overflow.patch'
32--- debian/patches/git-large-numbers-overflow.patch 1970-01-01 00:00:00 +0000
33+++ debian/patches/git-large-numbers-overflow.patch 2014-04-05 03:55:42 +0000
34@@ -0,0 +1,43 @@
35+Origin: http://git.xfce.org/apps/ristretto/commit/?h=ristretto-0.6&id=1a5e3f1aade3d5d460510a31cbdf9e0fb5b648a3
36+Bug: https://bugzilla.xfce.org/show_bug.cgi?id=9485
37+Description: Fixed an overflow when comparing filenames with large numbers in them.
38+
39+---
40+ src/image_list.c | 12 ++++++------
41+ 1 file changed, 6 insertions(+), 6 deletions(-)
42+
43+--- a/src/image_list.c
44++++ b/src/image_list.c
45+@@ -1363,8 +1363,8 @@ cb_rstto_image_list_image_name_compare_f
46+ const gchar *bp = b_base;
47+
48+ gint result = 0;
49+- guint a_num = 0;
50+- guint b_num = 0;
51++ guint64 a_num = 0;
52++ guint64 b_num = 0;
53+
54+ /* try simple (fast) ASCII comparison first */
55+ for (;; ++ap, ++bp)
56+@@ -1404,8 +1404,8 @@ cb_rstto_image_list_image_name_compare_f
57+ */
58+ if (g_ascii_isdigit (ac) && g_ascii_isdigit (bc))
59+ {
60+- a_num = strtoul (ap, NULL, 10);
61+- b_num = strtoul (bp, NULL, 10);
62++ a_num = strtoull (ap, NULL, 10);
63++ b_num = strtoull (bp, NULL, 10);
64+
65+ if (a_num < b_num)
66+ result = -1;
67+@@ -1418,8 +1418,8 @@ cb_rstto_image_list_image_name_compare_f
68+ g_ascii_isdigit (*(ap -1)) &&
69+ g_ascii_isdigit (*(bp -1)) )
70+ {
71+- a_num = strtoul (ap-1, NULL, 10);
72+- b_num = strtoul (bp-1, NULL, 10);
73++ a_num = strtoull (ap-1, NULL, 10);
74++ b_num = strtoull (bp-1, NULL, 10);
75+
76+ if (a_num < b_num)
77+ result = -1;
78
79=== added file 'debian/patches/series'
80--- debian/patches/series 1970-01-01 00:00:00 +0000
81+++ debian/patches/series 2014-04-05 03:55:42 +0000
82@@ -0,0 +1,1 @@
83+git-large-numbers-overflow.patch

Subscribers

People subscribed via source and target branches

to all changes: