Merge lp:~noskcaj/ubuntu/trusty/juman/ftbfs into lp:ubuntu/trusty/juman

Proposed by Jackson Doak
Status: Needs review
Proposed branch: lp:~noskcaj/ubuntu/trusty/juman/ftbfs
Merge into: lp:ubuntu/trusty/juman
Diff against target: 171 lines (+67/-23)
6 files modified
debian/README.Debian (+4/-2)
debian/changelog (+18/-9)
debian/control (+10/-2)
debian/juman-dic.install (+3/-0)
debian/juman-server (+12/-0)
debian/rules (+20/-10)
To merge this branch: bzr merge lp:~noskcaj/ubuntu/trusty/juman/ftbfs
Reviewer Review Type Date Requested Status
Iain Lane Approve
Review via email: mp+208298@code.launchpad.net

Description of the change

Might fix the ftbfs. I couldn't reproduce the ftbfs locally, but this is the fix recommended in the debian RC bug. Builds fine locally and in ppa.

To post a comment you must log in.
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

+Package: libjuman-perl
+Architecture: all
+Depends: ${perl:Depends}, juman
+Description: Perl binding of JUMAN
+ This package provides Perl binding of Juman, that is a Japanese
+ morphological analysis system.

I think we should not add new binary packages after feature freeze. Is there any real need for that?

Revision history for this message
Jackson Doak (noskcaj) wrote :

I don't know if it's good to add this later, but it's been in proposed for some time

Revision history for this message
Iain Lane (laney) wrote :

You can reproduce the ftbfs by building an arch-only build (not indep packages). Building on i386 and nowhere else is a hint to that.

review: Approve

Unmerged revisions

9. By Jackson Doak

update maintainer

8. By Jackson Doak

Replace cp commands in d/rules with d/juman-doc.insall

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/README.Debian'
2--- debian/README.Debian 2004-04-03 23:47:16 +0000
3+++ debian/README.Debian 2014-02-26 08:35:23 +0000
4@@ -7,7 +7,9 @@
5 information (pronunciation, semantic information, etc).
6
7 Note: Juman can not process strings encoded in other coding systems
8-than EUC-JP, and also its outputs are encoded in EUC-JP.
9+than UTF-8, and also its outputs are encoded in UTF-8. This is a big
10+difference between the current version of Juman and the older
11+versions.
12
13 If you want to use Juman server, try these steps.
14
15@@ -16,4 +18,4 @@
16 update-rc.d juman-server defaults 99 1
17 /etc/init.t/juman-server start
18
19- -- TSUCHIYA Masatoshi <tsuchiya@namazu.org>, Fri Feb 20 14:24:18 2004
20+ -- TSUCHIYA Masatoshi <tsuchiya@namazu.org>, Wed, 25 Jan 2012 21:05:33 +0900
21
22=== modified file 'debian/changelog'
23--- debian/changelog 2012-10-07 17:05:06 +0000
24+++ debian/changelog 2014-02-26 08:35:23 +0000
25@@ -1,12 +1,21 @@
26-juman (7.0-1.1) unstable; urgency=low
27-
28- * Non-maintainer upload.
29-
30- [ Konstantinos Margaritis ]
31- * Create usr/share/doc/juman link in binary-arch build
32- This should fix the FTBFS reported for non i386 arches. Closes: #657688
33-
34- -- Christian Perrier <bubulle@debian.org> Sun, 07 Oct 2012 17:05:06 +0200
35+juman (7.0-3ubuntu1) trusty; urgency=medium
36+
37+ * Replace cp commands in d/rules with d/juman-doc.insall
38+
39+ -- Jackson Doak <noskcaj@ubuntu.com> Wed, 26 Feb 2014 19:18:25 +1100
40+
41+juman (7.0-3) unstable; urgency=low
42+
43+ * Call dh with "--with autotools_dev" option (closes: #727909).
44+ * Build depends to autotools-dev.
45+
46+ -- TSUCHIYA Masatoshi <tsuchiya@namazu.org> Wed, 30 Oct 2013 22:28:48 +0900
47+
48+juman (7.0-2) unstable; urgency=low
49+
50+ * Add libjuman-perl.
51+
52+ -- TSUCHIYA Masatoshi <tsuchiya@namazu.org> Mon, 23 Jan 2012 22:23:49 +0900
53
54 juman (7.0-1) unstable; urgency=low
55
56
57=== modified file 'debian/control'
58--- debian/control 2012-01-20 12:13:19 +0000
59+++ debian/control 2014-02-26 08:35:23 +0000
60@@ -1,8 +1,9 @@
61 Source: juman
62 Section: misc
63 Priority: optional
64-Maintainer: TSUCHIYA Masatoshi <tsuchiya@namazu.org>
65-Build-Depends: debhelper (>= 7), quilt
66+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
67+XSBC-Original-Maintainer: TSUCHIYA Masatoshi <tsuchiya@namazu.org>
68+Build-Depends: debhelper (>= 7), quilt, autotools-dev
69 Standards-Version: 3.9.2
70
71 Package: juman
72@@ -40,3 +41,10 @@
73 Description: Library of JUMAN
74 This package provides runtime libraries of Juman, that is a Japanese
75 morphological analysis system.
76+
77+Package: libjuman-perl
78+Architecture: all
79+Depends: ${perl:Depends}, juman
80+Description: Perl binding of JUMAN
81+ This package provides Perl binding of Juman, that is a Japanese
82+ morphological analysis system.
83
84=== added file 'debian/juman-dic.install'
85--- debian/juman-dic.install 1970-01-01 00:00:00 +0000
86+++ debian/juman-dic.install 2014-02-26 08:35:23 +0000
87@@ -0,0 +1,3 @@
88+dic/*.dic usr/share/juman/dic
89+autodic/*.dic usr/share/juman/autodic
90+wikipediadic/*.dic usr/share/juman/wikipediadic
91\ No newline at end of file
92
93=== modified file 'debian/juman-server'
94--- debian/juman-server 2012-01-20 12:13:19 +0000
95+++ debian/juman-server 2014-02-26 08:35:23 +0000
96@@ -4,6 +4,18 @@
97 # and call update-rc.d to install the links of the copied script.
98 #
99
100+### BEGIN INIT INFO
101+# Provides: juman
102+# Required-Start: $local_fs $network $syslog
103+# Required-Stop: $local_fs $network $syslog
104+# Should-Start:
105+# Should-Stop:
106+# Default-Start: 2 3 4 5
107+# Default-Stop: 0 1 6
108+# Short-Description: Juman init script
109+# Description: Init script for Juman server
110+### END INIT INFO
111+
112 NAME=juman
113 DAEMON="/usr/bin/$NAME"
114 DESC="Juman server"
115
116=== modified file 'debian/rules'
117--- debian/rules 2012-10-07 17:05:06 +0000
118+++ debian/rules 2014-02-26 08:35:23 +0000
119@@ -4,22 +4,30 @@
120 # Uncomment this to turn on verbose mode.
121 #export DH_VERBOSE=1
122
123+ifndef PERL
124+PERL = /usr/bin/perl
125+endif
126+PERL_OPTIMIZE = -O2 -Wall
127+ifneq (,$(findstring debug,$(DEB_BUILD_OPTIONS)))
128+PERL_OPTIMIZE += -g
129+endif
130+
131 %:
132- dh $@ --with quilt
133+ dh $@ --with quilt --with autotools_dev
134
135 override_dh_auto_configure:
136 dh_auto_configure -- --libexecdir=/usr/lib --datadir=/usr/lib
137-
138-override_dh_auto_install-arch:
139+ cd perl && $(PERL) Makefile.PL INSTALLDIRS=vendor
140+
141+override_dh_auto_build:
142+ dh_auto_build
143+ $(MAKE) -C perl OPTIMIZE="$(PERL_OPTIMIZE)" DICDIR=`pwd`/dic
144+
145+dicprefix=debian/juman-dic/usr/share/juman
146+override_dh_auto_install:
147 dh_auto_install
148-
149-dicprefix=debian/juman-dic/usr/share/juman
150-override_dh_auto_install-indep:
151 rm -rf debian/tmp/usr/lib/juman/doc
152 dh_link -pjuman usr/share/doc/juman usr/lib/juman/doc
153- cp -p dic/*.dic $(dicprefix)/dic
154- cp -p autodic/*.dic $(dicprefix)/autodic
155- cp -p wikipediadic/*.dic $(dicprefix)/wikipediadic
156 for d in dic autodic wikipediadic ; do \
157 for f in $(dicprefix)/$${d}/* ; do \
158 dh_link -pjuman-dic \
159@@ -27,10 +35,12 @@
160 `echo $$f|sed s,debian/juman-dic/usr/share/,usr/lib/,` ;\
161 done ;\
162 done
163+ $(MAKE) -C perl install PREFIX=`pwd`/debian/libjuman-perl/usr DICDIR=`pwd`/dic
164
165 override_dh_auto_clean:
166 dh_auto_clean
167- -rm -f dic/*.int dic/jumandic.*
168+ -$(MAKE) -C perl realclean
169+ -rm -f dic/*.int dic/jumandic.* dic/JUMAN.connect
170 -rm -f autodic/*.int autodic/jumandic.*
171 -rm -f wikipediadic/*.int wikipediadic/jumandic.*
172

Subscribers

People subscribed via source and target branches

to all changes: