Merge lp:~noskcaj/seahorse/merge into lp:~ubuntu-desktop/seahorse/ubuntu

Proposed by Jackson Doak
Status: Merged
Merged at revision: 70
Proposed branch: lp:~noskcaj/seahorse/merge
Merge into: lp:~ubuntu-desktop/seahorse/ubuntu
Diff against target: 239 lines (+99/-49)
7 files modified
debian/changelog (+42/-1)
debian/control (+18/-17)
debian/control.in (+16/-16)
debian/patches/30_preferences_menu.patch (+0/-13)
debian/patches/fix-desktop-path.patch (+21/-0)
debian/patches/series (+1/-1)
debian/rules (+1/-1)
To merge this branch: bzr merge lp:~noskcaj/seahorse/merge
Reviewer Review Type Date Requested Status
Robert Ancell Approve
Review via email: mp+223130@code.launchpad.net

Description of the change

Merge from debian

To post a comment you must log in.
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Looks great, thanks Jackson!

review: Approve
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Sorry, this was meant on the gnome-themes-standard review, reviewing this now...

Revision history for this message
Robert Ancell (robert-ancell) wrote :

This looks great too :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-01-08 16:29:07 +0000
3+++ debian/changelog 2014-06-13 21:47:22 +0000
4@@ -1,3 +1,45 @@
5+seahorse (3.12.2-1ubuntu1) utopic; urgency=medium
6+
7+ * Merge from Debian unstable. Remaining changes:
8+ - debian/patches/use-stable-libsecret.patch:
9+ + Use the stable libsecret.
10+ - debian/patches/use_valid_help_url:
11+ + Let help buttons point to valid documentation references.
12+ - debian/control: Update Vcs-* field.
13+
14+ -- Jackson Doak <noskcaj@ubuntu.com> Sat, 14 Jun 2014 07:32:29 +1000
15+
16+seahorse (3.12.2-1) unstable; urgency=medium
17+
18+ * New upstream release.
19+
20+ -- Andreas Henriksson <andreas@fatal.se> Fri, 16 May 2014 19:53:51 +0200
21+
22+seahorse (3.12.0-1) unstable; urgency=low
23+
24+ [ Jeremy Bicha ]
25+ * debian/control.in:
26+ - Update homepage
27+ - Drop obsolete build-depends on gnome-doc-utils and libgnome-keyring
28+
29+ [ Andreas Henriksson ]
30+ * New upstream release.
31+ * Update build-dependencies according to configure.ac changes:
32+ - bump libgck-1-dev to (>= 3.11.91)
33+ - bump libgcr-3-dev to (>= 3.11.91)
34+ - bump libsecret-1-dev to (>= 0.16)
35+ - bump libsoup2.4-dev to (>= 2.33.92)
36+ - add valac (>= 0.22)
37+ * debian/rules: set DEB_LDFLAGS_MAINT_APPEND instead of LDFLAGS
38+ * Bump Standards-Version to 3.9.5
39+ * Drop debian/patches/30_preferences_menu.patch
40+ - doesn't apply and likely of negliable use these days anyway.
41+ * Add debian/patches/fix-desktop-path.patch
42+ - work around broken desktop file generation while trying to figure
43+ out the real cause/solution.
44+
45+ -- Andreas Henriksson <andreas@fatal.se> Mon, 24 Mar 2014 20:34:51 +0100
46+
47 seahorse (3.10.2-0ubuntu1) trusty; urgency=medium
48
49 * New upstream version, fix pgp/ssh key export and SSH key generation
50@@ -1323,4 +1365,3 @@
51 * Initial Release.
52
53 -- Anthony Mulcahy <anthony@kcn.ne.jp> Mon, 10 Jan 2000 22:17:00 +0900
54-
55
56=== modified file 'debian/control'
57--- debian/control 2013-12-16 04:57:30 +0000
58+++ debian/control 2014-06-13 21:47:22 +0000
59@@ -2,42 +2,43 @@
60 #
61 # Modifications should be made to debian/control.in instead.
62 # This file is regenerated automatically in the clean target.
63+
64 Source: seahorse
65 Section: gnome
66 Priority: optional
67 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
68 XSBC-Original-Maintainer: Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>
69-Uploaders: Andreas Henriksson <andreas@fatal.se>, Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>
70+Uploaders: Andreas Henriksson <andreas@fatal.se>, Jordi Mallach <jordi@debian.org>, Michael Biebl <biebl@debian.org>
71 Build-Depends: cdbs (>= 0.4.41),
72 debhelper (>= 8),
73 dh-autoreconf,
74- valac (>= 0.18.0),
75- libgpgme11-dev (>= 1.0.0),
76- libgck-1-dev (>= 3.3.4),
77- libgcr-3-dev (>= 3.9.1),
78+ gnome-pkg-tools,
79+ gtk-doc-tools (>= 1.9),
80 intltool (>= 0.35),
81- libsoup2.4-dev (>= 2.33.92),
82- libldap2-dev,
83+ libavahi-client-dev (>= 0.6),
84 libavahi-glib-dev (>= 0.6),
85- libavahi-client-dev (>= 0.6),
86- gtk-doc-tools (>= 1.9),
87+ libgck-1-dev (>= 3.11.91),
88+ libgcr-3-dev (>= 3.11.91),
89 libglib2.0-dev (>= 2.10.0),
90+ libgpgme11-dev (>= 1.0.0),
91 libgtk-3-dev (>= 3.4.0),
92+ libldap2-dev,
93 libsecret-1-dev (>= 0.16),
94- gnome-pkg-tools,
95+ libsoup2.4-dev (>= 2.33.92),
96 openssh-client,
97+ valac (>= 0.22),
98 yelp-tools
99-Standards-Version: 3.9.4
100+Standards-Version: 3.9.5
101 Vcs-Bzr: https://code.launchpad.net/~ubuntu-desktop/seahorse/ubuntu
102-Homepage: http://live.gnome.org/Seahorse
103+Homepage: https://wiki.gnome.org/Seahorse
104
105 Package: seahorse
106 Architecture: any
107-Depends: ${shlibs:Depends},
108- ${misc:Depends},
109- gcr (>= 3.9.1),
110- gnupg (>= 1.4.7),
111- gnome-keyring (>= 3.4)
112+Depends: ${misc:Depends},
113+ ${shlibs:Depends},
114+ gcr (>= 3.4),
115+ gnome-keyring (>= 3.4),
116+ gnupg (>= 1.4.7)
117 Recommends: openssh-client
118 Description: GNOME front end for GnuPG
119 Seahorse is a front end for GnuPG - the GNU Privacy Guard program -
120
121=== modified file 'debian/control.in'
122--- debian/control.in 2013-12-16 04:57:30 +0000
123+++ debian/control.in 2014-06-13 21:47:22 +0000
124@@ -7,33 +7,33 @@
125 Build-Depends: cdbs (>= 0.4.41),
126 debhelper (>= 8),
127 dh-autoreconf,
128- valac (>= 0.18.0),
129- libgpgme11-dev (>= 1.0.0),
130- libgck-1-dev (>= 3.3.4),
131- libgcr-3-dev (>= 3.9.1),
132+ gnome-pkg-tools,
133+ gtk-doc-tools (>= 1.9),
134 intltool (>= 0.35),
135- libsoup2.4-dev (>= 2.33.92),
136- libldap2-dev,
137+ libavahi-client-dev (>= 0.6),
138 libavahi-glib-dev (>= 0.6),
139- libavahi-client-dev (>= 0.6),
140- gtk-doc-tools (>= 1.9),
141+ libgck-1-dev (>= 3.11.91),
142+ libgcr-3-dev (>= 3.11.91),
143 libglib2.0-dev (>= 2.10.0),
144+ libgpgme11-dev (>= 1.0.0),
145 libgtk-3-dev (>= 3.4.0),
146+ libldap2-dev,
147 libsecret-1-dev (>= 0.16),
148- gnome-pkg-tools,
149+ libsoup2.4-dev (>= 2.33.92),
150 openssh-client,
151+ valac (>= 0.22),
152 yelp-tools
153-Standards-Version: 3.9.4
154+Standards-Version: 3.9.5
155 Vcs-Bzr: https://code.launchpad.net/~ubuntu-desktop/seahorse/ubuntu
156-Homepage: http://live.gnome.org/Seahorse
157+Homepage: https://wiki.gnome.org/Seahorse
158
159 Package: seahorse
160 Architecture: any
161-Depends: ${shlibs:Depends},
162- ${misc:Depends},
163- gcr (>= 3.9.1),
164- gnupg (>= 1.4.7),
165- gnome-keyring (>= 3.4)
166+Depends: ${misc:Depends},
167+ ${shlibs:Depends},
168+ gcr (>= 3.4),
169+ gnome-keyring (>= 3.4),
170+ gnupg (>= 1.4.7)
171 Recommends: openssh-client
172 Description: GNOME front end for GnuPG
173 Seahorse is a front end for GnuPG - the GNU Privacy Guard program -
174
175=== removed file 'debian/patches/30_preferences_menu.patch'
176--- debian/patches/30_preferences_menu.patch 2013-12-16 04:57:30 +0000
177+++ debian/patches/30_preferences_menu.patch 1970-01-01 00:00:00 +0000
178@@ -1,13 +0,0 @@
179-Index: seahorse-3.8.2/src/seahorse.desktop.in.in
180-===================================================================
181---- seahorse-3.8.2.orig/src/seahorse.desktop.in.in 2013-05-21 13:27:58.782407458 +0200
182-+++ seahorse-3.8.2/src/seahorse.desktop.in.in 2013-05-21 13:27:58.778407458 +0200
183-@@ -6,7 +6,7 @@
184- Terminal=false
185- Type=Application
186- Icon=seahorse
187--Categories=GNOME;GTK;Security;Utility;DesktopSettings;X-XFCE-SettingsDialog;
188-+Categories=GNOME;GTK;Security;Settings;DesktopSettings;X-XFCE-SettingsDialog;
189- StartupNotify=true
190- X-GNOME-Bugzilla-Bugzilla=GNOME
191- X-GNOME-Bugzilla-Product=seahorse
192
193=== added file 'debian/patches/fix-desktop-path.patch'
194--- debian/patches/fix-desktop-path.patch 1970-01-01 00:00:00 +0000
195+++ debian/patches/fix-desktop-path.patch 2014-06-13 21:47:22 +0000
196@@ -0,0 +1,21 @@
197+From: Andreas Henriksson <andreas@fatal.se>
198+Subject: hack around broken variable expansion
199+
200+The final desktop file ended up with Exec=${exec_prefix}/bin/seahorse
201+and I could not figure out why the variable expansion didn't
202+expand fully.
203+
204+Added this patch until we figure it out to avoid generating
205+broken desktop files....
206+
207+--- a/src/seahorse.desktop.in.in
208++++ b/src/seahorse.desktop.in.in
209+@@ -2,7 +2,7 @@
210+ _Name=Passwords and Keys
211+ _Comment=Manage your passwords and encryption keys
212+ _Keywords=keyring;encryption;security;sign;ssh;
213+-Exec=@bindir@/seahorse
214++Exec=/usr/bin/seahorse
215+ Terminal=false
216+ Type=Application
217+ Icon=seahorse
218
219=== modified file 'debian/patches/series'
220--- debian/patches/series 2013-12-15 01:04:29 +0000
221+++ debian/patches/series 2014-06-13 21:47:22 +0000
222@@ -1,3 +1,3 @@
223-30_preferences_menu.patch
224+fix-desktop-path.patch
225 use-stable-libsecret.patch
226 use_valid_help_url.patch
227
228=== modified file 'debian/rules'
229--- debian/rules 2013-12-15 01:04:29 +0000
230+++ debian/rules 2014-06-13 21:47:22 +0000
231@@ -7,7 +7,7 @@
232 include /usr/share/gnome-pkg-tools/1/rules/gnome-version.mk
233 -include /usr/share/gnome-pkg-tools/1/rules/gnome-get-source.mk
234
235-LDFLAGS += -Wl,-O1 -Wl,--as-needed
236+DEB_LDFLAGS_MAINT_APPEND = -Wl,-O1 -Wl,--as-needed
237
238 DEB_CONFIGURE_EXTRA_FLAGS += --disable-scrollkeeper \
239 --enable-pgp

Subscribers

People subscribed via source and target branches

to all changes: