Merge lp:~noskcaj/seahorse/3.14.0-2 into lp:~ubuntu-desktop/seahorse/ubuntu

Proposed by Jackson Doak
Status: Merged
Merged at revision: 72
Proposed branch: lp:~noskcaj/seahorse/3.14.0-2
Merge into: lp:~ubuntu-desktop/seahorse/ubuntu
Diff against target: 106 lines (+70/-1)
5 files modified
debian/changelog (+19/-0)
debian/control (+1/-1)
debian/patches/01_ssh_ui.patch (+25/-0)
debian/patches/02_ssh_ui.patch (+23/-0)
debian/patches/series (+2/-0)
To merge this branch: bzr merge lp:~noskcaj/seahorse/3.14.0-2
Reviewer Review Type Date Requested Status
Robert Ancell Approve
Review via email: mp+244938@code.launchpad.net

Description of the change

Merge a ssh fix from debian

To post a comment you must log in.
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Thanks Jackson!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-11-11 10:20:06 +0000
3+++ debian/changelog 2014-12-17 02:22:18 +0000
4@@ -1,3 +1,22 @@
5+seahorse (3.14.0-2ubuntu1) vivid; urgency=medium
6+
7+ * Merge from Debian unstable. Remaining changes:
8+ - debian/patches/use-stable-libsecret.patch:
9+ + Use the stable libsecret.
10+ - debian/patches/use_valid_help_url:
11+ + Let help buttons point to valid documentation references.
12+ - debian/control:
13+ + Update Vcs-* field.
14+
15+ -- Jackson Doak <noskcaj@ubuntu.com> Wed, 17 Dec 2014 12:51:40 +1100
16+
17+seahorse (3.14.0-2) unstable; urgency=medium
18+
19+ * 01_ssh_ui.patch, 02_ssh_ui.patch: patches from upstream git. Fix the
20+ SSH key generation UI file. Closes: #770241.
21+
22+ -- Josselin Mouette <joss@debian.org> Tue, 02 Dec 2014 20:59:59 +0100
23+
24 seahorse (3.14.0-1ubuntu1) vivid; urgency=low
25
26 * Merge from Debian unstable. (LP: #1388425) Remaining changes:
27
28=== modified file 'debian/control'
29--- debian/control 2014-11-11 10:20:06 +0000
30+++ debian/control 2014-12-17 02:22:18 +0000
31@@ -7,7 +7,7 @@
32 Priority: optional
33 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
34 XSBC-Original-Maintainer: Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>
35-Uploaders: Andreas Henriksson <andreas@fatal.se>, Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>
36+Uploaders: Andreas Henriksson <andreas@fatal.se>, Jordi Mallach <jordi@debian.org>, Josselin Mouette <joss@debian.org>, Michael Biebl <biebl@debian.org>
37 Build-Depends: cdbs (>= 0.4.41),
38 debhelper (>= 8),
39 dh-autoreconf,
40
41=== added file 'debian/patches/01_ssh_ui.patch'
42--- debian/patches/01_ssh_ui.patch 1970-01-01 00:00:00 +0000
43+++ debian/patches/01_ssh_ui.patch 2014-12-17 02:22:18 +0000
44@@ -0,0 +1,25 @@
45+From 20536a1282bb506bb4a3f11a83ddb6d46669e552 Mon Sep 17 00:00:00 2001
46+From: Matthias Clasen <mclasen@redhat.com>
47+Date: Fri, 14 Nov 2014 04:38:00 -0500
48+Subject: ssh generation: Fix invalid ui file
49+
50+GtkGrid does not have :n-rows or :n-columns properties.
51+
52+https://bugzilla.gnome.org/show_bug.cgi?id=740138
53+
54+diff --git a/ssh/seahorse-ssh-generate.xml b/ssh/seahorse-ssh-generate.xml
55+index 03defd9..9cb9e04 100644
56+--- a/ssh/seahorse-ssh-generate.xml
57++++ b/ssh/seahorse-ssh-generate.xml
58+@@ -196,8 +196,6 @@
59+ <property name="can_focus">False</property>
60+ <property name="row_spacing">6</property>
61+ <property name="column_spacing">12</property>
62+- <property name="n_rows">2</property>
63+- <property name="n_columns">2</property>
64+ <child>
65+ <object class="GtkLabel" id="label46">
66+ <property name="visible">True</property>
67+--
68+cgit v0.10.1
69+
70
71=== added file 'debian/patches/02_ssh_ui.patch'
72--- debian/patches/02_ssh_ui.patch 1970-01-01 00:00:00 +0000
73+++ debian/patches/02_ssh_ui.patch 2014-12-17 02:22:18 +0000
74@@ -0,0 +1,23 @@
75+From e9917a0a81fd58e1555c71a29c9f5fea80e327b2 Mon Sep 17 00:00:00 2001
76+From: Matthias Clasen <mclasen@redhat.com>
77+Date: Sat, 15 Nov 2014 12:05:14 -0500
78+Subject: Remove more invalid properties
79+
80+This was overlooked in the previous commit.
81+
82+diff --git a/ssh/seahorse-ssh-generate.xml b/ssh/seahorse-ssh-generate.xml
83+index 9cb9e04..d918617 100644
84+--- a/ssh/seahorse-ssh-generate.xml
85++++ b/ssh/seahorse-ssh-generate.xml
86+@@ -279,8 +279,6 @@
87+ <property name="margin_left">20</property>
88+ <property name="row_spacing">6</property>
89+ <property name="column_spacing">12</property>
90+- <property name="n_rows">2</property>
91+- <property name="n_columns">2</property>
92+ <child>
93+ <object class="GtkLabel" id="label49">
94+ <property name="visible">True</property>
95+--
96+cgit v0.10.1
97+
98
99=== modified file 'debian/patches/series'
100--- debian/patches/series 2014-11-11 10:20:06 +0000
101+++ debian/patches/series 2014-12-17 02:22:18 +0000
102@@ -1,2 +1,4 @@
103+01_ssh_ui.patch
104+02_ssh_ui.patch
105 use-stable-libsecret.patch
106 use_valid_help_url.patch

Subscribers

People subscribed via source and target branches

to all changes: