Merge lp:~noskcaj/nautilus/new-document-on-all into lp:~ubuntu-desktop/nautilus/ubuntu

[Jackson Doak]

Enable the new document button on all DEs, see lp:1437502

[Sebastien Bacher (seb128)]

Shouldn't Ubuntu GNOME report a bug upstream if they think it makes sense on all environment including GNOME?

review: Needs Information

[Jackson Doak (noskcaj)]

It's a patch made by Ubuntu, that changed to not be only used on unity
On 3 Apr 2015 19:41, "Sebastien Bacher" <email address hidden> wrote:

> Review: Needs Information
>
> Shouldn't Ubuntu GNOME report a bug upstream if they think it makes sense
> on all environment including GNOME?
>
> --
>
> https://code.launchpad.net/~noskcaj/nautilus/new-document-on-all/+merge/254475
> You are the owner of lp:~noskcaj/nautilus/new-document-on-all.
>

[Sebastien Bacher (seb128)]

right, but I though that Ubuntu GNOME wanted to follow upstream and reduce Ubuntu local changes? If that's the case and you still want that change you should perhaps try to talk to upstream about having the feature there?

[Jackson Doak (noskcaj)]

I'll have a look into that in the coming days.
On 3 Apr 2015 20:10, "Sebastien Bacher" <email address hidden> wrote:

> right, but I though that Ubuntu GNOME wanted to follow upstream and reduce
> Ubuntu local changes? If that's the case and you still want that change you
> should perhaps try to talk to upstream about having the feature there?
> --
>
> https://code.launchpad.net/~noskcaj/nautilus/new-document-on-all/+merge/254475
> You are the owner of lp:~noskcaj/nautilus/new-document-on-all.
>

[Sebastien Bacher (seb128)]

no news, closing

Unmerged revisions

459. By Jackson Doak on 2015-03-28

debian/patches/16_unity_new_documents.patch: Enable the
new empty document button on all DEs. LP: #1437502

=== modified file 'debian/changelog'
--- debian/changelog	2015-03-25 15:39:29 +0000
+++ debian/changelog	2015-03-28 02:07:54 +0000
@@ -1,3 +1,10 @@
+nautilus (1:3.14.2-0ubuntu7) vivid; urgency=medium
+
+  * debian/patches/16_unity_new_documents.patch: Enable the
+    new empty document button on all DEs. LP: #1437502
+
+ -- Jackson Doak <[e-mail]>  Sat, 28 Mar 2015 12:55:26 +1100
+
 nautilus (1:3.14.2-0ubuntu6) vivid; urgency=medium
 
   * debian/nautilus.migrations, 

=== modified file 'debian/patches/16_unity_new_documents.patch'
--- debian/patches/16_unity_new_documents.patch	2014-03-11 14:42:13 +0000
+++ debian/patches/16_unity_new_documents.patch	2015-03-28 02:07:54 +0000
@@ -110,16 +110,12 @@
  	g_signal_connect_object (action_group, "pre-activate",
  				 G_CALLBACK (pre_activate), G_OBJECT (view),
  				 G_CONNECT_SWAPPED);
-@@ -8813,7 +8851,11 @@ real_update_menus (NautilusView *view)
+@@ -8813,7 +8851,7 @@ real_update_menus (NautilusView *view)
  	action = gtk_action_group_get_action (view->details->dir_action_group,
  					      NAUTILUS_ACTION_NEW_DOCUMENTS);
  	gtk_action_set_sensitive (action, can_create_files);
 -	gtk_action_set_visible (action, !selection_contains_recent && view->details->templates_present);
-+	
-+	if (g_strcmp0 (g_getenv ("XDG_CURRENT_DESKTOP"), "Unity") == 0)
-+		gtk_action_set_visible (action, TRUE);
-+	else
-+		gtk_action_set_visible (action, !selection_contains_recent && view->details->templates_present);
++	gtk_action_set_visible (action, TRUE);
  
  	action = gtk_action_group_get_action (view->details->dir_action_group,
  					      NAUTILUS_ACTION_COPY_TO);