Merge lp:~noskcaj/nautilus/new-document-on-all into lp:~ubuntu-desktop/nautilus/ubuntu

Proposed by Jackson Doak on 2015-03-28
Status: Rejected
Rejected by: Sebastien Bacher on 2015-11-05
Proposed branch: lp:~noskcaj/nautilus/new-document-on-all
Merge into: lp:~ubuntu-desktop/nautilus/ubuntu
Diff against target: 37 lines (+9/-6)
2 files modified
debian/changelog (+7/-0)
debian/patches/16_unity_new_documents.patch (+2/-6)
To merge this branch: bzr merge lp:~noskcaj/nautilus/new-document-on-all
Reviewer Review Type Date Requested Status
Sebastien Bacher 2015-03-28 Needs Information on 2015-04-03
Review via email: mp+254475@code.launchpad.net

Description of the change

Enable the new document button on all DEs, see lp:1437502

To post a comment you must log in.
Sebastien Bacher (seb128) wrote :

Shouldn't Ubuntu GNOME report a bug upstream if they think it makes sense on all environment including GNOME?

review: Needs Information
Jackson Doak (noskcaj) wrote :

It's a patch made by Ubuntu, that changed to not be only used on unity
On 3 Apr 2015 19:41, "Sebastien Bacher" <email address hidden> wrote:

> Review: Needs Information
>
> Shouldn't Ubuntu GNOME report a bug upstream if they think it makes sense
> on all environment including GNOME?
>
> --
>
> https://code.launchpad.net/~noskcaj/nautilus/new-document-on-all/+merge/254475
> You are the owner of lp:~noskcaj/nautilus/new-document-on-all.
>

Sebastien Bacher (seb128) wrote :

right, but I though that Ubuntu GNOME wanted to follow upstream and reduce Ubuntu local changes? If that's the case and you still want that change you should perhaps try to talk to upstream about having the feature there?

Jackson Doak (noskcaj) wrote :

I'll have a look into that in the coming days.
On 3 Apr 2015 20:10, "Sebastien Bacher" <email address hidden> wrote:

> right, but I though that Ubuntu GNOME wanted to follow upstream and reduce
> Ubuntu local changes? If that's the case and you still want that change you
> should perhaps try to talk to upstream about having the feature there?
> --
>
> https://code.launchpad.net/~noskcaj/nautilus/new-document-on-all/+merge/254475
> You are the owner of lp:~noskcaj/nautilus/new-document-on-all.
>

Sebastien Bacher (seb128) wrote :

no news, closing

Unmerged revisions

459. By Jackson Doak on 2015-03-28

debian/patches/16_unity_new_documents.patch: Enable the
new empty document button on all DEs. LP: #1437502

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2015-03-25 15:39:29 +0000
3+++ debian/changelog 2015-03-28 02:07:54 +0000
4@@ -1,3 +1,10 @@
5+nautilus (1:3.14.2-0ubuntu7) vivid; urgency=medium
6+
7+ * debian/patches/16_unity_new_documents.patch: Enable the
8+ new empty document button on all DEs. LP: #1437502
9+
10+ -- Jackson Doak <noskcaj@ubuntu.com> Sat, 28 Mar 2015 12:55:26 +1100
11+
12 nautilus (1:3.14.2-0ubuntu6) vivid; urgency=medium
13
14 * debian/nautilus.migrations,
15
16=== modified file 'debian/patches/16_unity_new_documents.patch'
17--- debian/patches/16_unity_new_documents.patch 2014-03-11 14:42:13 +0000
18+++ debian/patches/16_unity_new_documents.patch 2015-03-28 02:07:54 +0000
19@@ -110,16 +110,12 @@
20 g_signal_connect_object (action_group, "pre-activate",
21 G_CALLBACK (pre_activate), G_OBJECT (view),
22 G_CONNECT_SWAPPED);
23-@@ -8813,7 +8851,11 @@ real_update_menus (NautilusView *view)
24+@@ -8813,7 +8851,7 @@ real_update_menus (NautilusView *view)
25 action = gtk_action_group_get_action (view->details->dir_action_group,
26 NAUTILUS_ACTION_NEW_DOCUMENTS);
27 gtk_action_set_sensitive (action, can_create_files);
28 - gtk_action_set_visible (action, !selection_contains_recent && view->details->templates_present);
29-+
30-+ if (g_strcmp0 (g_getenv ("XDG_CURRENT_DESKTOP"), "Unity") == 0)
31-+ gtk_action_set_visible (action, TRUE);
32-+ else
33-+ gtk_action_set_visible (action, !selection_contains_recent && view->details->templates_present);
34++ gtk_action_set_visible (action, TRUE);
35
36 action = gtk_action_group_get_action (view->details->dir_action_group,
37 NAUTILUS_ACTION_COPY_TO);

Subscribers

People subscribed via source and target branches

to all changes: