Merge lp:~noorez-kassam/ubuntu/trusty/initramfs-tools/fix-for-1317437 into lp:ubuntu/trusty/initramfs-tools

Proposed by Noorez on 2016-03-14
Status: Needs review
Proposed branch: lp:~noorez-kassam/ubuntu/trusty/initramfs-tools/fix-for-1317437
Merge into: lp:ubuntu/trusty/initramfs-tools
Diff against target: 29 lines (+10/-1)
2 files modified
debian/changelog (+7/-0)
scripts/local (+3/-1)
To merge this branch: bzr merge lp:~noorez-kassam/ubuntu/trusty/initramfs-tools/fix-for-1317437
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre (community) 2016-03-14 Approve on 2017-03-29
Review via email: mp+288981@code.launchpad.net
To post a comment you must log in.
Mathieu Trudel-Lapierre (cyphermox) wrote :

This looks fine, but all changes meant to fix bugs in stable releases should first land in the development release. Can you please do a similar merge proposal for the zesty release?

Also, please make sure that in debian/changelog, lines are limited to 80 columns.

review: Approve
Noorez (noorez-kassam) wrote :

Will you be able to give me some guidance? I have lost my development environment and have almost got it setup..

As it has been a while since I have been here, how do I checkout the branch for the zesty release? It seems that the approach that I used before is not working. Has the location of the source changed? I cannot find it?...

Thanks!

Unmerged revisions

279. By Noorez on 2016-03-14

initramfs-tools/scripts/local: Correctly configure the loop device to allow remounting
as rw during boot (LP: #1317437)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-03-03 08:11:20 +0000
3+++ debian/changelog 2016-03-14 20:23:14 +0000
4@@ -1,3 +1,10 @@
5+initramfs-tools (0.103ubuntu5) UNRELEASED; urgency=medium
6+
7+ * initramfs-tools/scripts/local: Correctly configure the loop device to allow remounting
8+ as rw during boot (LP: #1317437)
9+
10+ -- Noorez Kassam <noorez.kassam@gmail.com> Mon, 14 Mar 2016 14:17:07 -0600
11+
12 initramfs-tools (0.103ubuntu4) trusty; urgency=medium
13
14 * Cherrypick v0.113 changes (LP: #1194370):
15
16=== modified file 'scripts/local'
17--- scripts/local 2011-07-12 07:22:11 +0000
18+++ scripts/local 2016-03-14 20:23:14 +0000
19@@ -135,7 +135,9 @@
20 modprobe ${FSTYPE}
21
22 # FIXME This has no error checking
23- mount ${roflag} -o loop -t ${FSTYPE} ${LOOPFLAGS} "/host/${LOOP#/}" ${rootmnt}
24+ loopdev=`losetup -f`
25+ losetup ${loopdev} "/host/${LOOP#/}"
26+ mount ${roflag} -t ${FSTYPE} ${LOOPFLAGS} ${loopdev} ${rootmnt}
27
28 if [ -d ${rootmnt}/host ]; then
29 mount -o move /host ${rootmnt}/host

Subscribers

People subscribed via source and target branches

to all changes: