Merge lp:~nononoha/command-not-found/command-not-found into lp:command-not-found

[Noah Gorny]

Fix file permissions of db on creation

As noted in https://bugs.launchpad.net/command-not-found/+bug/1824000
The db file is sometimes created with incorrect permissions, which causes crashes
This fixes the problem by chmoding the db file to 644 on creation.

[lp:~nononoha/command-not-found/command-not-found]

279. By Noah Gorny on 2020-10-16

db: creator: Fix file permissions of db on creation

[Noah Gorny (nononoha)]

I can not link to the bug for some reason, but it resolves https://bugs.launchpad.net/command-not-found/+bug/1824000

[Adrian Wilkins (adrian-wilkins)]

Looks good.

review: Approve

Unmerged revisions

279. By Noah Gorny on 2020-10-16

db: creator: Fix file permissions of db on creation

=== modified file 'CommandNotFound/db/creator.py'
--- CommandNotFound/db/creator.py	2018-03-20 11:31:18 +0000
+++ CommandNotFound/db/creator.py	2020-10-16 09:24:39 +0000
@@ -7,6 +7,7 @@
 import sqlite3
 import sys
 import time
+import stat
 
 import apt_pkg
 apt_pkg.init()
@@ -95,6 +96,9 @@
         rm_f(metadata_file)
         # put database in place
         os.rename(tmpdb, dbname)
+        # change mode to 644
+        mode = stat.S_IREAD | stat.S_IWRITE | stat.S_IRGRP | stat.S_IROTH
+        os.chmod(dbname, mode)
         # add new metadata
         with open(metadata_file, "w") as fp:
             json.dump(self._calc_input_metadata(), fp)