Merge lp:~nobuto/ubuntu/raring/ubuntu-defaults-builder/unify-apt-line into lp:ubuntu/raring/ubuntu-defaults-builder

Proposed by Nobuto Murata
Status: Merged
Merge reported by: Benjamin Drung
Merged at revision: not available
Proposed branch: lp:~nobuto/ubuntu/raring/ubuntu-defaults-builder/unify-apt-line
Merge into: lp:ubuntu/raring/ubuntu-defaults-builder
Diff against target: 18 lines (+2/-3)
1 file modified
bin/ubuntu-defaults-image (+2/-3)
To merge this branch: bzr merge lp:~nobuto/ubuntu/raring/ubuntu-defaults-builder/unify-apt-line
Reviewer Review Type Date Requested Status
Barry Warsaw (community) Approve
Ubuntu branches Pending
Review via email: mp+131793@code.launchpad.net

Description of the change

config/archives/*.{chroot,binary}.list were deprecated in current live-build, we should use *.list.{chroot,binary} syntax[1] instead as well as the change[2] of Rev.142.

[1] http://live.debian.net/manual/html/live-manual.en.html#371
[2] http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/raring/ubuntu-defaults-builder/raring/revision/142

But in cases of adding PPA, we don't have to separate the content into {chroot,binary}. This branch just unifies the content to fix duplicated apt-lines in generated ISO.

To post a comment you must log in.
Revision history for this message
Barry Warsaw (barry) wrote :

Seems reasonable to me. Thanks for the contribution to Ubuntu! I'll sponsor this change.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/ubuntu-defaults-image'
2--- bin/ubuntu-defaults-image 2012-10-17 10:50:21 +0000
3+++ bin/ubuntu-defaults-image 2012-10-28 17:39:20 +0000
4@@ -72,12 +72,11 @@
5 FINGERPRINT=${FINGERPRINT#'"'}
6
7 # fetch GPG key
8- gpg --no-default-keyring --primary-keyring config/archives/ubuntu-defaults.chroot.key --keyserver keyserver.ubuntu.com --recv-key "$FINGERPRINT"
9+ gpg --no-default-keyring --primary-keyring config/archives/ubuntu-defaults.key --keyserver keyserver.ubuntu.com --recv-key "$FINGERPRINT"
10
11 # add PPA apt source
12 local DEB_PPA="deb http://ppa.launchpad.net/$PPA/ubuntu $SUITE main"
13- echo "$DEB_PPA" > config/archives/ubuntu-defaults.chroot.list
14- echo "$DEB_PPA" > config/archives/ubuntu-defaults.binary.list
15+ echo "$DEB_PPA" > config/archives/ubuntu-defaults.list
16 }
17
18 eval set -- "$(getopt -o '' -l help,locale:,keep-apt,keep-apt-components:,package:,arch:,release:,components:,mirror:,security-mirror:,ppa: -- "$@")" || { help; exit 1; }

Subscribers

People subscribed via source and target branches

to all changes: