Merge lp:~nobuto/ubuntu/raring/ecryptfs-utils/fix-empty-window into lp:ubuntu/raring/ecryptfs-utils

Proposed by Nobuto Murata
Status: Merged
Merge reported by: Marc Deslauriers
Merged at revision: not available
Proposed branch: lp:~nobuto/ubuntu/raring/ecryptfs-utils/fix-empty-window
Merge into: lp:ubuntu/raring/ecryptfs-utils
Diff against target: 28 lines (+10/-0)
2 files modified
debian/changelog (+7/-0)
debian/rules (+3/-0)
To merge this branch: bzr merge lp:~nobuto/ubuntu/raring/ecryptfs-utils/fix-empty-window
Reviewer Review Type Date Requested Status
Marc Deslauriers Approve
Ubuntu branches Pending
Review via email: mp+149465@code.launchpad.net

Description of the change

The hook in debian/rules was added at 101-0ubuntu2 as a part of making an update-notifier window translatable.
 http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/raring/ecryptfs-utils/raring/revision/88#debian/rules

But it was removed at 102-0ubuntu1 accidentally on merge, I think.
http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/raring/ecryptfs-utils/raring/revision/90#debian/rules

This branch re-adds the part to fix an empty update-notifier window.

To post a comment you must log in.
Revision history for this message
Nobuto Murata (nobuto) wrote :

Why we have to remove translations markers after pot created is explained here:
 https://wiki.ubuntu.com/InteractiveUpgradeHooks

Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Looks good. ACK. Uploaded, thanks.

Could you please propose this for merging upstream also, so it doesn't get lost?:

https://code.launchpad.net/~ecryptfs/ecryptfs/trunk

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-01-25 12:58:56 +0000
3+++ debian/changelog 2013-02-20 05:25:22 +0000
4@@ -1,3 +1,10 @@
5+ecryptfs-utils (103-0ubuntu2) UNRELEASED; urgency=low
6+
7+ * fix an empty update-notifier window (LP: #1107650)
8+ - needed part was dropped accidentally at 102-0ubuntu1
9+
10+ -- Nobuto MURATA <nobuto@ubuntu.com> Wed, 20 Feb 2013 14:05:42 +0900
11+
12 ecryptfs-utils (103-0ubuntu1) raring; urgency=low
13
14 [ Tyler Hicks ]
15
16=== modified file 'debian/rules'
17--- debian/rules 2013-01-25 12:58:56 +0000
18+++ debian/rules 2013-02-20 05:25:22 +0000
19@@ -39,6 +39,9 @@
20 chmod 4755 debian/ecryptfs-utils/sbin/mount.ecryptfs_private
21
22 override_dh_install:
23+ # Removing translation markers to work as an update-notifier hook
24+ sed -i 's/^_//' debian/tmp/usr/share/ecryptfs-utils/ecryptfs-record-passphrase
25+
26 dh_install --fail-missing --sourcedir=debian/tmp
27
28 override_dh_python2:

Subscribers

People subscribed via source and target branches

to all changes: