Merge lp:~nobuto/maas-deployer/intel-amt into lp:~maas-deployers/maas-deployer/next

[Nobuto Murata]

Enabling Intel AMT enlistment support. But please note that the dependencies of amtterm is not tiny.

$ sudo apt install wsmancli
...
Need to get 158 kB of archives.
After this operation, 536 kB of additional disk space will be used.

$ sudo apt install amtterm
...
Need to get 22.0 MB of archives.
After this operation, 95.6 MB of additional disk space will be used.

I have tested the enlistment with the following yaml.
====
        nodes:
            - name: NODE_NAME
              tags: TAG
              architecture: amd64/generic
              mac_addresses:
                  - "MAC_ADDRESS"
              power:
                  type: amt
                  address: AMT_IP_ADDRESS
                  pass: AMT_PASSWORD
              sticky_ip_address:
                  mac_address: "MAC_ADDRESS"
                  requested_address: AMT_IP_ADDRESS

[Billy Olsen (billy-olsen)]

I think it'd be great to have the Intel AMT enlistment capabilities, however it feels like this dependency should be in MAAS not MAAS deployer. I think its a fine change and I'm happy to merge it if I can understand why the amtterm and wsmancli are not dependencies from MAAS.

review: Needs Information

[Nobuto Murata (nobuto)]

In MAAS, Intel AMT power type is somewhat optional. MAAS Web UI shows a warning to install amtterm and wsmancli packages when trying to configure Intel AMT power type. Also there is an API call to check missing packages.

$ maas PROFILE node-groups describe-power-types
...
    {
        "missing_packages": [
            "amtterm",
            "wsmancli"
        ],
        "fields": [
            {
                "field_type": "mac_address",
                "name": "mac_address",
                "default": "",
                "required": false,
                "choices": [],
                "label": "MAC Address"
            },
            {
                "field_type": "password",
                "name": "power_pass",
                "default": "",
                "required": false,
                "choices": [],
                "label": "Power password"
            },
            {
                "field_type": "string",
                "name": "power_address",
                "default": "",
                "required": false,
                "choices": [],
                "label": "Power address"
            }
        ],
        "name": "amt",
        "description": "Intel AMT"
    },
...

[Billy Olsen (billy-olsen)]

Hmm any other power types which are optional and require additional packages? Maybe we can make it more generic and handle other types, either by:

1. Allow optional packages to be specified
2. Specifying additional power types to be included

[Nobuto Murata (nobuto)]

This is the list of missing packages on generic MAAS installation.
$ maas maas node-groups describe-power-types | jq '.[] | {missing_packages, description, name}'
http://paste.ubuntu.com/14883288/

However libvirt-bin, ipmitool and wakeonlan were already added in maas_deployer/vmaas/templates/cloud-init.cfg.

[Billy Olsen (billy-olsen)]

Thanks for the info Nobuto. Approved.

review: Approve

=== modified file 'maas_deployer/vmaas/templates/cloud-init.cfg'
--- maas_deployer/vmaas/templates/cloud-init.cfg	2015-12-04 16:19:01 +0000
+++ maas_deployer/vmaas/templates/cloud-init.cfg	2016-02-04 19:20:52 +0000
@@ -50,6 +50,8 @@
   # Node management tools
   - ipmitool
   - wakeonlan
+  - amtterm
+  - wsmancli
   # Python libraries used for the maas configuration script
   - python-bson
   - python-httplib2