Merge ~nobuto/grok-exporter-snap:go-mod into grok-exporter-snap:master
Proposed by
Nobuto Murata
| Status: | Merged |
|---|---|
| Approved by: | Eric Chen |
| Approved revision: | f2e0c59e74c8abc5224052a3233667cfceec1b51 |
| Merged at revision: | f2e0c59e74c8abc5224052a3233667cfceec1b51 |
| Proposed branch: | ~nobuto/grok-exporter-snap:go-mod |
| Merge into: | grok-exporter-snap:master |
| Diff against target: |
20 lines (+2/-1) 2 files modified
.gitignore (+1/-0) snapcraft.yaml (+1/-1) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Erhan Sunar (community) | Approve | ||
| Eric Chen | Approve | ||
| BootStack Reviewers | Pending | ||
|
Review via email:
|
|||
Commit message
Bump the source tag to RC5
go.mod and go.sum updates are necessary to build with later Go versions.
https:/
Description of the change
There seems to be memory consumption spike with the snap.
It was built against Go 1.14 and with the version there is a known "issue" with the Go version and memory management method was changed at 1.16 by default.
$ go version bin/grok_exporter
bin/grok_exporter: go1.14.1
https:/
Could you please build the snap with Go 1.16 or later and publish it into the edge channel for testing?
To post a comment you must log in.
Revision history for this message
| Erhan Sunar (esunar) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM.
There is no lint/unit/func test in grok-exporter-snap.
No mergebot or snap package receipt.
We need to build it manually or setup the snap receipt in LP later.