Code review comment for lp:~nnewton-drupal/pressflow/pathalias
Revision history for this message
| David Strauss (davidstrauss) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
I think the remaining work is acceptable to shelve right now. I'll try to merge this today.
------Original Message------
From: Narayan Newton
Sender: <email address hidden>
To: Narayan Newton
ReplyTo: <email address hidden>
Subject: Re: [Merge] lp:~nnewton-drupal/pressflow/pathalias into lp:pressflow
Sent: Jan 13, 2010 23:31
Fixed up some issues with comments and changed 0 to FALSE in a few places for style.
Outstanding requests:
1) Check the front page alias cache on cache miss. I'm not going to implement that for this iteration. I believe that significant testing needs to go into that idea to ensure it actually has benefit.
2) Porting the drupal_static function to core. I'm interesting in this, but I think we should do it separately from this issue and then "port" this functionality.
--
https:/
You are requested to review the proposed merge of lp:~nnewton-drupal/pressflow/pathalias into lp:pressflow.