GTG

Merge lp:~nmu-sscheel/gtg/fix-open-link-while-selecting into lp:~gtg/gtg/old-trunk

Proposed by Steve Scheel
Status: Merged
Merged at revision: 1135
Proposed branch: lp:~nmu-sscheel/gtg/fix-open-link-while-selecting
Merge into: lp:~gtg/gtg/old-trunk
Diff against target: 35 lines (+7/-1) (has conflicts)
3 files modified
AUTHORS (+4/-0)
CHANGELOG (+2/-0)
GTG/gtk/editor/taskview.py (+1/-1)
Text conflict in AUTHORS
To merge this branch: bzr merge lp:~nmu-sscheel/gtg/fix-open-link-while-selecting
Reviewer Review Type Date Requested Status
Izidor Matušov running, code Approve
Review via email: mp+99434@code.launchpad.net

Description of the change

I added to the conditionals when the link is to clicked to check and make sure that the link isn't currently selected for copying/pasting/etc. This stops it from opening a link if a user releases on the link while selecting the link, but they will need to double click on the link if there is a piece of the link selected in order to open it.

To post a comment you must log in.
Revision history for this message
Izidor Matušov (izidor) wrote :

Awesome, it fixes the problem! No more annoying opened webpages when selecting a link! Thank you

review: Approve (running, code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'AUTHORS'
2--- AUTHORS 2012-03-26 22:18:17 +0000
3+++ AUTHORS 2012-03-26 22:20:29 +0000
4@@ -98,4 +98,8 @@
5 * huxuan <i@huxuan.org>
6 * Nimit Shah <nimit.svnit@gmail.com>
7 * Abdul Rauf <abdulraufhaseeb@gmail.com>
8+<<<<<<< TREE
9 * Radina Matic <radina.matic@gmail.com>
10+=======
11+* Steve Scheel <nmu.sscheel@gmail.com>
12+>>>>>>> MERGE-SOURCE
13
14=== modified file 'CHANGELOG'
15--- CHANGELOG 2012-03-22 13:50:35 +0000
16+++ CHANGELOG 2012-03-26 22:20:29 +0000
17@@ -1,3 +1,5 @@
18+2012-03-26
19+ * Stopped links from opening when accidently letting go of mouse button while selecting them
20 2012-0?-?? Getting Things GNOME! 0.3
21 * Hide tasks with due date someday, #931376
22 * New Date class by Paul Kishimoto and Izidor Matušov
23
24=== modified file 'GTG/gtk/editor/taskview.py'
25--- GTG/gtk/editor/taskview.py 2012-03-22 13:32:49 +0000
26+++ GTG/gtk/editor/taskview.py 2012-03-26 22:20:29 +0000
27@@ -1330,7 +1330,7 @@
28 if typ == "subtask":
29 self.open_task(anchor)
30 elif typ == "http":
31- if button == 1 and self.check_link(anchor):
32+ if button == 1 and self.check_link(anchor) and self.buff.get_has_selection() == False:
33 openurl(anchor)
34 else:
35 print "Unknown link type for %s" %anchor

Subscribers

People subscribed via source and target branches

to status/vote changes: