Merge lp:~nmb/bzr/fix-358821 into lp:bzr

Proposed by Neil Martinsen-Burrell
Status: Merged
Approved by: Ian Clatworthy
Approved revision: not available
Merged at revision: not available
Proposed branch: lp:~nmb/bzr/fix-358821
Merge into: lp:bzr
Diff against target: 17 lines (+4/-3)
1 file modified
bzrlib/builtins.py (+4/-3)
To merge this branch: bzr merge lp:~nmb/bzr/fix-358821
Reviewer Review Type Date Requested Status
Ian Clatworthy Approve
Martin Pool Approve
Review via email: mp+15160@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Neil Martinsen-Burrell (nmb) wrote :

This clarifies (hopefully) when revert will delete files and when it will make backups.

Revision history for this message
Martin Pool (mbp) wrote :

That looks good except that 'the' should be 'they'.

review: Approve
Revision history for this message
Ian Clatworthy (ian-clatworthy) wrote :

I'll merge.

review: Approve
Revision history for this message
Robert Collins (lifeless) wrote :

Neil, I don't have you on file as having signed the contributor agreement. This is covered at http://www.canonical.com/contributors. Please CC me and Martin on the mail, and I'll land your merges once received.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bzrlib/builtins.py'
2--- bzrlib/builtins.py 2009-11-23 00:57:38 +0000
3+++ bzrlib/builtins.py 2009-11-23 15:50:31 +0000
4@@ -4065,9 +4065,10 @@
5 name. If you name a directory, all the contents of that directory will be
6 reverted.
7
8- Any files that have been newly added since that revision will be deleted,
9- with a backup kept if appropriate. Directories containing unknown files
10- will not be deleted.
11+ If you have newly added files since the target revision, the will be
12+ removed. If the files to be removed have been changed, backups will be
13+ created as above. Directories containing unknown files will not be
14+ deleted.
15
16 The working tree contains a list of pending merged revisions, which will
17 be included as parents in the next commit. Normally, revert clears that