Merge lp:~nmb/bzr/fix-213184 into lp:bzr

Proposed by Neil Martinsen-Burrell
Status: Merged
Approved by: John A Meinel
Approved revision: not available
Merged at revision: not available
Proposed branch: lp:~nmb/bzr/fix-213184
Merge into: lp:bzr
Diff against target: 70 lines (+26/-5)
2 files modified
bzrlib/conflicts.py (+3/-5)
bzrlib/help_topics/en/conflicts.txt (+23/-0)
To merge this branch: bzr merge lp:~nmb/bzr/fix-213184
Reviewer Review Type Date Requested Status
John A Meinel Approve
Robert Collins (community) Approve
Review via email: mp+15158@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Neil Martinsen-Burrell (nmb) wrote :

This adds documentation about fixing tag conflicts to bzr help conflicts. It should take a step towards fixing 213184. I did not add a mention of this to ``bzr pull`` since I think that ``bzr help conflicts`` is a reasonable response to "Conflicting tags", but I could add that if desired.

Revision history for this message
Robert Collins (lifeless) wrote :

Looks good. Perhaps it should say 'apply the tag you want to win to one of the branches - either the source or target.'. Also, pull --overwrite will overwrite all tags, I think.

review: Approve
Revision history for this message
Neil Martinsen-Burrell (nmb) wrote :

Updated in that branch.

Revision history for this message
John A Meinel (jameinel) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bzrlib/conflicts.py'
2--- bzrlib/conflicts.py 2009-03-23 14:59:43 +0000
3+++ bzrlib/conflicts.py 2009-11-25 16:45:24 +0000
4@@ -53,13 +53,12 @@
5 instead. (This is useful for editing all files with text conflicts.)
6
7 Use bzr resolve when you have fixed a problem.
8-
9- See also bzr resolve.
10 """
11 takes_options = [
12 Option('text',
13 help='List paths of files with text conflicts.'),
14 ]
15+ _see_also = ['resolve']
16
17 def run(self, text=False):
18 from bzrlib.workingtree import WorkingTree
19@@ -82,16 +81,15 @@
20 before you should commit.
21
22 Once you have fixed a problem, use "bzr resolve" to automatically mark
23- text conflicts as fixed, resolve FILE to mark a specific conflict as
24+ text conflicts as fixed, "bzr resolve FILE" to mark a specific conflict as
25 resolved, or "bzr resolve --all" to mark all conflicts as resolved.
26-
27- See also bzr conflicts.
28 """
29 aliases = ['resolved']
30 takes_args = ['file*']
31 takes_options = [
32 Option('all', help='Resolve all conflicts in this tree.'),
33 ]
34+ _see_also = ['conflicts']
35 def run(self, file_list=None, all=False):
36 from bzrlib.workingtree import WorkingTree
37 if all:
38
39=== modified file 'bzrlib/help_topics/en/conflicts.txt'
40--- bzrlib/help_topics/en/conflicts.txt 2007-12-25 04:17:50 +0000
41+++ bzrlib/help_topics/en/conflicts.txt 2009-11-25 16:45:24 +0000
42@@ -79,6 +79,29 @@
43 FILE". Bazaar cannot auto-detect when conflicts of this kind have been
44 resolved.
45
46+Tag conflicts
47+-------------
48+
49+Typical message::
50+
51+ Conflicting tags:
52+ version-0.1
53+
54+When pulling from or pushing to another branch, Bazaar informs you about tags
55+that conflict between the two branches; that is the same tag points to two
56+different revisions. You need not resolve these conflicts, but subsequent
57+uses of pull or push will result in the same message.
58+
59+To resolve the conflict, you must apply the correct tags to either the target
60+branch or the source branch as appropriate. Use "bzr tags --show-ids -d
61+SOURCE_URL" to see the tags in the source branch. If you want to make the
62+target branch's tags match the source branch, then in the target branch do
63+``bzr tag --force -r revid:REVISION_ID CONFLICTING_TAG`` for each of the
64+CONFLICTING_TAGs, where REVISION_ID comes from the list of tags in the source
65+branch. You need not call "bzr resolve" after doing this. To resolve in favor of the target branch, you need to similarly use ``tag --force`` in the source
66+branch. (Note that pulling or pushing using --overwrite will overwrite all
67+tags as well.)
68+
69 Duplicate paths
70 ---------------
71