Merge lp:~njpatel/unity/panel-dash-fixes into lp:unity
Proposed by
Neil J. Patel
Status: | Merged |
---|---|
Approved by: | Gord Allott |
Approved revision: | no longer in the source branch. |
Merged at revision: | 1562 |
Proposed branch: | lp:~njpatel/unity/panel-dash-fixes |
Merge into: | lp:unity |
Diff against target: | 0 lines |
To merge this branch: | bzr merge lp:~njpatel/unity/panel-dash-fixes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gord Allott (community) | Approve | ||
Review via email: mp+75548@code.launchpad.net |
Description of the change
99% of the icons we are getting from the indicators right now are pixbufs, which made this way more difficult that it could have been (and not as nice).
For now, to cover all themes instead of just Radiance, I'm doing some cairo magic in the code when the dash is up to convert the pixbufs into white-based icons. This works pretty well for symbolic-type icons, however it's not so great if the icon has tons of detail.
As we don't, by default, have any icon that looks bad, and because the icons still look at least somewhat recognisable, I'm going for this as the right approach for Oneiric.
To post a comment you must log in.
http:// i.imgur. com/SlQZC. png is a pic with all the normal icons and one crappy one (guess which one!).
http:// i.imgur. com/Tx27k. png is without the icon fix. (ignore the battery, even that ends up black normally).