Merge lp:~njpatel/unity-lens-music/fix-initial-results into lp:unity-lens-music

Proposed by Neil J. Patel
Status: Merged
Merged at revision: 33
Proposed branch: lp:~njpatel/unity-lens-music/fix-initial-results
Merge into: lp:unity-lens-music
Diff against target: 21 lines (+1/-5)
1 file modified
src/banshee-scope.vala (+1/-5)
To merge this branch: bzr merge lp:~njpatel/unity-lens-music/fix-initial-results
Reviewer Review Type Date Requested Status
Mikkel Kamstrup Erlandsen (community) Approve
Review via email: mp+74507@code.launchpad.net

Description of the change

Fixes displaying initial results, where old_search would be null.

To post a comment you must log in.
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Discussed on IRC

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/banshee-scope.vala'
2--- src/banshee-scope.vala 2011-09-02 17:42:32 +0000
3+++ src/banshee-scope.vala 2011-09-07 19:50:25 +0000
4@@ -227,10 +227,6 @@
5
6 if (old_search == null)
7 {
8- s1 = new_search.search_string;
9- if (s1 == null || s1.strip() == "")
10- return false;
11- else
12 return true;
13 }
14 else if (new_search == null)
15@@ -264,4 +260,4 @@
16 }
17 }
18 }
19-}
20\ No newline at end of file
21+}

Subscribers

People subscribed via source and target branches

to all changes: