~nitrokey/nitrokey/+git/libnitrokey:pr_115

Last commit made on 2018-06-20
Get this branch:
git clone -b pr_115 https://git.launchpad.net/~nitrokey/nitrokey/+git/libnitrokey

Branch merges

Branch information

Name:
pr_115
Repository:
lp:~nitrokey/nitrokey/+git/libnitrokey

Recent commits

1226891... by Szczepan

fixup add second series

Signed-off-by: Szczepan Zalega <email address hidden>

4941392... by Szczepan

Add test

Signed-off-by: Szczepan Zalega <email address hidden>

5910ec7... by Robin Krahl

Correct return value for NitrokeyManager::connect()

NitrokeyManager::connect() currently returns true if the device pointer
is set. Yet this does not mean that the connection was successful. For
example, NitrokeyManger::connect(const char*) sets the device pointer
even if it was not successful.

This patch introduces a variable that keeps track of the connection
instead of checking the device pointer. This corrects the return value
without changing the behavior of the connect method (returning the
Storage device if both a Pro and a Storage device are present).

e91e21d... by Szczepan

Merge branch 'pr_113'

Mark unused parameters in TOTP code getter in the C API.

Closes #113

ecd0a69... by Robin Krahl

Mark NK_get_totp_code arguments as unused

According to the GetTOTP class in stick10_commands_0.8.h and after
firmware inspection, the challenge, last_totp_time and last_interval
arguments for the get_TOTP_code method are unused. This patch adds this
information to the doc comment for NK_get_totp_code and
NK_get_totp_code_PIN.

d0155ee... by Szczepan

Merge branch 'pr_112'

Fix broken include

Closes #112

8cbcf66... by Robin Krahl

Fix include path for NK_C_API.h in test_strdup.cpp

391a276... by Szczepan

Merge branch '110-mixed_strings'

Make sure all C API strings are deallocable.

Tested with Python's 3.6.5 'pytest -sv test_{pro,storage}.py' on Storage v0.50,
Ubuntu 18.04

Closes #110

9ab13fd... by Szczepan

Correct NK_status() reply length

Signed-off-by: Szczepan Zalega <email address hidden>

d2db195... by Szczepan

Implement suggested tests

Signed-off-by: Szczepan Zalega <email address hidden>