119-qmake_version_getter : lp:~nitrokey/nitrokey/+git/libnitrokey : Git : Code : Nitrokey App

Get this branch:: git clone -b 119-qmake_version_getter https://git.launchpad.net/~nitrokey/nitrokey/+git/libnitrokey

Branch merges

Branch information

Name:: 119-qmake_version_getter

Repository:: lp:~nitrokey/nitrokey/+git/libnitrokey

Recent commits

f00638b... by Szczepan on 2018-06-19

DEBUG Initial idea for #119. Better would be having default values in version.cc in repository and overwriting it with CMake via configure file.

Signed-off-by: Szczepan Zalega <email address hidden>

e1ef8d7... by Szczepan on 2018-06-19

Merge branch 'pr_114'

Cleanup API related to device's TOTP time management

Fixes #114

9a4e5a3... by Szczepan on 2018-06-19

Remove NK_totp_get_time implementation, since it always results in error on device's side

Signed-off-by: Szczepan Zalega <email address hidden>

2cbea6c... by Szczepan on 2018-06-19

Add "deprecated" tags to get_time and NK_totp_get_time functions

Signed-off-by: Szczepan Zalega <email address hidden>

81a2880... by Robin Krahl on 2018-05-18

Add set_time_soft to replace get_time

The SetTime command supports two modes: set the time without checking
the currently set time, or verify that the currently set time is not
zero and not larger than the new time (see cmd_set_time(uint8_t*,
uint8_t*) in src/keyboard/report_protocol.c, lines 678--710, in the
Nitrokey Pro firmware).

NitrokeyManager called these two modes set_time(uint64_t) and
get_time(uint64_t), which is highly misleading -- the command does never
get the time. Furthermore, the get_time method per default calls the
command with the time zero, which will always result in an error.

The C API has the methods NK_totp_set_time(uint64_t) and
NK_totp_get_time(). NK_totp_get_time() calls get_time(uint64_t) with
the time zero, leading to an error, and is therefore useless.

This patch proposes a new wording. While it would make sense to call
the first mode “reset” and the second mode “set”, this would break
compatibility. Therefore, new methods set_time_soft(uint64_t) and
NK_totp_set_time_soft(uint64_t) are introduced to represent the
difference between a hard and a soft setting of the time.

The old methods, get_time(uint64_t) and NK_totp_get_time(), are not
removed but marked as deprecated. They should be removed in an upcoming
major release.

b46dbfa... by Szczepan on 2018-06-19