GTG

Merge lp:~nimit-svnit/gtg/bug-1043457 into lp:~gtg/gtg/old-trunk

Proposed by Nimit Shah
Status: Merged
Approved by: Izidor Matušov
Approved revision: 1232
Merged at revision: 1243
Proposed branch: lp:~nimit-svnit/gtg/bug-1043457
Merge into: lp:~gtg/gtg/old-trunk
Diff against target: 31 lines (+6/-4)
2 files modified
CHANGELOG (+1/-0)
gtcli (+5/-4)
To merge this branch: bzr merge lp:~nimit-svnit/gtg/bug-1043457
Reviewer Review Type Date Requested Status
Lionel Dricot (community) Approve
Izidor Matušov code Approve
Review via email: mp+123404@code.launchpad.net

Description of the change

Fix for bug-1043457: gtcli search returns closed tasks

Added one check for open tasks before displaying the tasks

To post a comment you must log in.
Revision history for this message
Izidor Matušov (izidor) wrote :

It looks good. I will merge it after release of GTG 0.3

review: Approve (code)
Revision history for this message
Nimit Shah (nimit-svnit) wrote :

Okay!

Revision history for this message
Nimit Shah (nimit-svnit) wrote :

Just a reminder :) Can we merge it now?

Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CHANGELOG'
2--- CHANGELOG 2012-08-27 11:39:18 +0000
3+++ CHANGELOG 2012-09-08 07:59:19 +0000
4@@ -52,6 +52,7 @@
5 * Fix for bug #897425: Write manpage for gtcli and update other manpages as well
6 * Fix for bug-1037051 (Due date is not set for a new subtask), by Nimit Shah
7 * Fix for bug #1036955: Due date is not preselected when start date is filled, by Steve Scheel
8+ * Fix for bug #1043457: gtcli search returns closed tasks, by Nimit Shah
9
10 2012-02-13 Getting Things GNOME! 0.2.9
11 * Big refractorization of code, now using liblarch
12
13=== modified file 'gtcli'
14--- gtcli 2012-07-23 12:04:01 +0000
15+++ gtcli 2012-09-08 07:59:19 +0000
16@@ -352,10 +352,11 @@
17 gtg = connect_to_gtg()
18 tasks = gtg.SearchTasks(expression)
19 for task in tasks:
20- text = textwrap.fill(task['title'],
21- initial_indent='',
22- subsequent_indent=' ' * 40)
23- print " %-36s %s" % (task['id'], text)
24+ if task['status'] == 'Active':
25+ text = textwrap.fill(task['title'],
26+ initial_indent='',
27+ subsequent_indent=' ' * 40)
28+ print " %-36s %s" % (task['id'], text)
29
30
31 def run_command(args):

Subscribers

People subscribed via source and target branches

to status/vote changes: