Merge lp:~nikwen/ubuntu-terminal-app/improve-list-item-design into lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot

Proposed by Niklas Wenzel
Status: Merged
Approved by: Niklas Wenzel
Approved revision: 163
Merged at revision: 163
Proposed branch: lp:~nikwen/ubuntu-terminal-app/improve-list-item-design
Merge into: lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot
Diff against target: 53 lines (+11/-6)
2 files modified
src/app/qml/ColorSchemePage.qml (+1/-1)
src/app/qml/SettingsPage.qml (+10/-5)
To merge this branch: bzr merge lp:~nikwen/ubuntu-terminal-app/improve-list-item-design
Reviewer Review Type Date Requested Status
Stefano Verzegnassi Approve
Jenkins Bot continuous-integration Approve
Ubuntu Terminal Developers Pending
Review via email: mp+285274@code.launchpad.net

Commit message

Tweak the design of the ListItems in the settings

Description of the change

Tweak the design of the ListItems in the settings

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Stefano Verzegnassi (verzegnassi-stefano) wrote :

Looks good to me. Thanks!

review: Approve
Revision history for this message
Niklas Wenzel (nikwen) wrote :

Thanks for the review, Stefano. :)

Shall we pull the top-level approve trigger?

Revision history for this message
Stefano Verzegnassi (verzegnassi-stefano) wrote :

Yes, +1!

Revision history for this message
Niklas Wenzel (nikwen) wrote :

Then let's do it. :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/ColorSchemePage.qml'
2--- src/app/qml/ColorSchemePage.qml 2016-01-22 18:29:56 +0000
3+++ src/app/qml/ColorSchemePage.qml 2016-02-06 17:00:20 +0000
4@@ -32,7 +32,7 @@
5 model: settings.profilesList
6 delegate: ListItem {
7 ListItemLayout {
8- anchors.fill: parent
9+ anchors.verticalCenter: parent.verticalCenter
10 title.text: modelData
11
12 Icon {
13
14=== modified file 'src/app/qml/SettingsPage.qml'
15--- src/app/qml/SettingsPage.qml 2016-01-22 18:37:29 +0000
16+++ src/app/qml/SettingsPage.qml 2016-02-06 17:00:20 +0000
17@@ -34,16 +34,16 @@
18 Column {
19 id: mainColumn
20 anchors { left: parent.left; right: parent.right }
21- spacing: units.gu(1)
22
23 ListItem {
24 ListItemLayout {
25- anchors.fill: parent
26+ anchors.verticalCenter: parent.verticalCenter
27 title.text: i18n.tr("Layouts")
28
29 Icon {
30 SlotsLayout.position: SlotsLayout.Trailing
31- width: units.gu(2); height: width
32+ width: units.gu(2)
33+ height: width
34 name: "go-next"
35 }
36 }
37@@ -84,10 +84,15 @@
38 }
39
40 ListItem {
41- height: units.gu(12)
42+ height: units.gu(13)
43
44 Label {
45- anchors { left: parent.left; margins: units.gu(2) }
46+ anchors {
47+ top: parent.top
48+ left: parent.left
49+ right: parent.right
50+ margins: units.gu(2)
51+ }
52 text: i18n.tr("Font Size:")
53 }
54

Subscribers

People subscribed via source and target branches