Merge lp:~nikwen/ubuntu-system-settings/update-label-center-fix into lp:ubuntu-system-settings

[Niklas Wenzel]

Center the "No updates" label properly. Fixes LP: #1429280

Attempt to center the "No updates" label properly. See LP: #1429280.

I haven't tested it yet (didn't compile on Utopic), but I hope that it will work.
If not, we can try to center it in the Flickable directly.

[Sebastien Bacher (seb128)]

Thanks, could you explain the logic behind the change/what do you think is buggy at the moment? The change doesn't seem to address the issue...

review: Needs Information

[Sebastien Bacher (seb128)]

in fact it seems that the issue is that the flickable anchors.top target the top of the screen and not the bottom of the title/header...

[Niklas Wenzel (nikwen)]

Have you actually given this a try yet? I've had this fix the issue for some other apps I worked on so I hoped it might work here as well. If not, I'll adjust it.

(I wasn't able to compile it on Utopic so I can't test myself.)

[Sebastien Bacher (seb128)]

Yes, I tried it, and no need to compile it's a change to a plugin qml, you can edit it in place on the disk...

[Niklas Wenzel (nikwen)]

Ok, thanks. If it's that easy I will try to fix it properly tomorrow.
I'll have an exam tomorrow, so I don't have time to do it right now. ;)

[Sebastien Bacher (seb128)]

No hurry, thanks for working on the issue and good luck for tomorrow! ;-)

[lp:~nikwen/ubuntu-system-settings/update-label-center-fix]

1346. By Niklas Wenzel on 2015-04-10

Revert last changes

1347. By Niklas Wenzel on 2015-04-10

Another approach

1348. By Niklas Wenzel on 2015-04-10

Fix flickable value

1349. By Niklas Wenzel on 2015-04-10

Fix app header height calculation

[Niklas Wenzel (nikwen)]

I haven't tried this yet but I used the same approach in my Forum Browser app and it worked fine there.
Since I still haven't got my chroot set up properly, would you mind giving this a try again? Thank you in advance. :)

[Sebastien Bacher (seb128)]

Thanks, you don't need a chroot to test the qml change, there is no compilation needed, you can directly edit on the device

the issue has to do with the flickable, using "flickable: none" makes it properly center

Not sure I like adding a workaround though, we should understand the issue/real problem with the toolkit and fix it properly if we can

review: Needs Fixing

[Sebastien Bacher (seb128)]

one way that seems to fix it is using that anchoring for the "notification" object

" top: flickable.top
            topMargin: flickable.topMargin
..."

[Sebastien Bacher (seb128)]

I've also opened bug #1445016 on the uitk, ideally they would give us access to the header to anchor to its bottom for cases like that are not automatically handled

[Niklas Wenzel (nikwen)]

Thank you for your replies, Sebastian.

The reason why I didn't test the code was that afaik I'd have to make my image writable for that, which I'd prefer not to do at the moment.
Your fix looks much nicer than the one I found. It's simply much less of a change. Looks like I'll use that one in my Forum Browser app as well. Thanks!

If you submit a MP with your change, I'll happily approve it after testing.

Btw, I commented on the bug you opened. ;)

[Sebastien Bacher (seb128)]

changing to "work in progress", that's not ready to land and doesn't need to be on the reviews list

[Niklas Wenzel (nikwen)]

In my opinion we can also close this as the workaround I provided was rejected. The one fixing this will probably open a new MP anyway.

Unmerged revisions

1349. By Niklas Wenzel on 2015-04-10

Fix app header height calculation

1348. By Niklas Wenzel on 2015-04-10

Fix flickable value

1347. By Niklas Wenzel on 2015-04-10

Another approach

1346. By Niklas Wenzel on 2015-04-10

Revert last changes

1345. By Niklas Wenzel on 2015-03-06

Attempt to center Label properly

1344. By Launchpad Translations on behalf of system-settings-touch on 2015-03-06

Launchpad automatic translations update.

=== modified file 'plugins/system-update/PageComponent.qml'
--- plugins/system-update/PageComponent.qml	2015-03-16 13:51:36 +0000
+++ plugins/system-update/PageComponent.qml	2015-04-10 20:10:45 +0000
@@ -35,7 +35,7 @@
     objectName: "systemUpdatesPage"
 
     title: installingImageUpdate.visible ? "" : i18n.tr("Updates")
-    flickable: installingImageUpdate.visible ? null : scrollWidget
+    flickable: (installingImageUpdate.visible || appHeaderHeight === 0) ? null : scrollWidget
 
     property bool installAll: false
     property bool includeSystemUpdate: false
@@ -47,6 +47,9 @@
     property var notificationAction;
     property string errorDialogText: ""
 
+    //Needed for workaround to truly center the "No updates available" label in the free area, excluding the area covered by the header (see the updateNotification definition below)
+    property real appHeaderHeight: 0
+
     onUpdatesAvailableChanged: {
         if (updatesAvailable < 1 && root.state != "SEARCHING")
             root.state = "NOUPDATES";
@@ -690,11 +693,21 @@
         color: "transparent"
 
         Label {
-            anchors.centerIn: updateNotification
             text: updateNotification.text
             width: updateNotification.width
             horizontalAlignment: Text.AlignHCenter
             wrapMode: Text.Wrap
+
+            //Workaround to truly center the label in the free area, excluding the area covered by the header
+
+            anchors {
+                centerIn: updateNotification
+                verticalCenterOffset: appHeaderHeight / 2
+            }
+
+            Component.onCompleted: { //Determines header height (needed for offset), which automatically sets the flickable above
+                appHeaderHeight = main.height - root.height //main is the MainView
+            }
         }
     }