Ubuntu Push Notifications

Merge lp:~nikwen/ubuntu-push/gmail-messages-missed-fix into lp:ubuntu-push

  1. gmail-messages-missed-fix
  2. Merge into trunk
Proposed by Niklas Wenzel
Status: Superseded
Proposed branch: lp:~nikwen/ubuntu-push/gmail-messages-missed-fix
Merge into: lp:ubuntu-push
Diff against target: 12 lines (+1/-1)
1 file modified
messaging/messaging.go (+1/-1)
To merge this branch: bzr merge lp:~nikwen/ubuntu-push/gmail-messages-missed-fix
Reviewer Review Type Date Requested Status
Ubuntu Push Hackers Pending
Review via email: mp+258206@code.launchpad.net

This proposal has been superseded by a proposal from 2015-05-04.

Commit message

Do not pass cleared messages to account-polld (LP: #1451510)

Description of the change

Do not pass cleared messages to account-polld

Fixes a bug where no notifications are shown for emails which arrive directly after clearing existing notifications from the messaging menu.

To post a comment you must log in.

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'messaging/messaging.go'
2--- messaging/messaging.go 2015-01-22 09:52:07 +0000
3+++ messaging/messaging.go 2015-05-04 19:57:07 +0000
4@@ -125,7 +125,7 @@
5 mmu.lock.RLock()
6 defer mmu.lock.RUnlock()
7 for _, payload := range mmu.notifications {
8- if payload.App.Original() == orig {
9+ if payload.App.Original() == orig && !payload.Gone {
10 tags = append(tags, payload.Tag)
11 }
12 }

Subscribers

People subscribed via source and target branches