Merge lp:~nikwen/ubuntu-calculator-app/reboot-white-splash-screen into lp:ubuntu-calculator-app
| Status: | Merged |
|---|---|
| Approved by: | Bartosz Kosiorek on 2015-04-13 |
| Approved revision: | 159 |
| Merged at revision: | 163 |
| Proposed branch: | lp:~nikwen/ubuntu-calculator-app/reboot-white-splash-screen |
| Merge into: | lp:ubuntu-calculator-app |
| Diff against target: |
9 lines (+1/-1) 1 file modified
app/ubuntu-calculator-app.desktop.in.in (+1/-1) |
| To merge this branch: | bzr merge lp:~nikwen/ubuntu-calculator-app/reboot-white-splash-screen |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve on 2015-04-13 | |
| Riccardo Padovani | 2015-04-11 | Approve on 2015-04-12 | |
|
Review via email:
|
|||
Commit Message
Add white splash screen
Description of the Change
Add white splash screen.
Why I used a white splash screen:
1) Showing a fake MainView with a header does not make any sense since the application hides the header on startup.
2) Displaying another image: Why?
3) The application uses a white background so it makes sense to make the splash screen white as well. (I stole the color from the clock app. :p)
FAILED: Continuous integration, rev:159
http://
Executed test runs:
UNSTABLE: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Niklas Wenzel (nikwen) wrote : | # |
The Jenkins bot seems to be running all tests twice for me and failing the second time. Same behaviour could be seen on my other branch.
| Riccardo Padovani (rpadovani) wrote : | # |
I already reported the Jenkins fail, it tries to run both for trunk and for reboot.
Anyway, shouldn't be better to take a screenshot of the app without any calc and use it as splash screen? So it seems it has only to load calcs :-)
| Niklas Wenzel (nikwen) wrote : | # |
Thank you for your answer, Riccardo.
I sent a mail to nskaggs yesterday as well. Let's see what he says.
However, I wouldn't vote for using a screenshot as a splash screen for various reasons:
1) The screenshot wouldn't be resized (that's not supported by the splash screen). Now if you take a screenshot on a Nexus 4, it would be too big on the Aquaris while a one from the Aquaris would be too small on a Nexus 4.
2) The user would see the UI but it would be unresponsive. Not the best first impression.
3) You'd have to update the screenshot whenever you tweak the UI.
| Riccardo Padovani (rpadovani) wrote : | # |
While I don't think 2 and 3 are blockers, the first one is a problem. Thanks for the explanation, I approve this branch, so thanks also for the contribution :-)
| Niklas Wenzel (nikwen) wrote : | # |
You're welcome, and thanks for approving. :)
FAILED: Autolanding.
More details in the following jenkins job:
http://
Executed test runs:
UNSTABLE: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
FAILED: Autolanding.
Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot.
http://
Executed test runs:
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
| Niklas Wenzel (nikwen) wrote : | # |
Ok, so merging failed because the old tests were finished before the reboot ones.
Should we try it again (it worked for yesterday's MP) or wait until the issue is fixed?
FAILED: Autolanding.
More details in the following jenkins job:
http://
Executed test runs:
UNSTABLE: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
FAILED: Autolanding.
More details in the following jenkins job:
http://
Executed test runs:
UNSTABLE: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
FAILED: Autolanding.
More details in the following jenkins job:
http://
Executed test runs:
UNSTABLE: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
| Niklas Wenzel (nikwen) wrote : | # |
Thanks for trying to get this merged. Seems like the system doesn't want us to do that. I suggest waiting until that Jenkins issue is fixed.
FAILED: Autolanding.
More details in the following jenkins job:
http://
Executed test runs:
UNSTABLE: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
FAILED: Autolanding.
Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot.
http://
Executed test runs:
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
| Niklas Wenzel (nikwen) wrote : | # |
Thanks for finally getting this merged. :)
Btw, Nicholas just notified me that the issue has been resolved. :)
PASSED: Continuous integration, rev:159
http://
Executed test runs:
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://