Merge lp:~nik90/unav/0.59-minor-fixes into lp:unav

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 51
Merged at revision: 47
Proposed branch: lp:~nik90/unav/0.59-minor-fixes
Merge into: lp:unav
Diff against target: 162 lines (+18/-17)
9 files modified
qml/Main.qml (+4/-4)
qml/Nearby.qml (+2/-2)
qml/PoiListPage.qml (+0/-1)
qml/PoiPage.qml (+0/-2)
qml/RoutePage.qml (+1/-1)
qml/SearchPage.qml (+0/-1)
qml/SettingsPage.qml (+9/-1)
qml/tuto/Slide3.qml (+1/-1)
qml/tuto/components/Walkthrough.qml (+1/-4)
To merge this branch: bzr merge lp:~nik90/unav/0.59-minor-fixes
Reviewer Review Type Date Requested Status
costales Approve
Review via email: mp+291909@code.launchpad.net

Description of the change

Just minor fixes

To post a comment you must log in.
lp:~nik90/unav/0.59-minor-fixes updated
50. By Nekhelesh Ramananthan

minor fix

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Waiting on Marcos's update welcome wizard images. Don't merge before that.

lp:~nik90/unav/0.59-minor-fixes updated
51. By Nekhelesh Ramananthan

Fixed link not clickable in the warn radar dialog

Revision history for this message
costales (costales) wrote :

Nice touch :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Main.qml'
2--- qml/Main.qml 2016-04-13 17:52:10 +0000
3+++ qml/Main.qml 2016-04-14 16:55:42 +0000
4@@ -168,8 +168,8 @@
5
6 Action {
7 id: routeAction
8- iconName: "send"
9- text: i18n.tr("Route")
10+ iconName: "view-grid-symbolic"
11+ text: i18n.tr("Menu")
12 enabled: navigationPage.buttonsEnabled
13 onTriggered: {
14 mainPageStack.push(Qt.resolvedUrl("RoutePage.qml"))
15@@ -383,7 +383,7 @@
16 opacity: navigationPage.buttonsEnabled ? 1.0 : 0.3
17
18 ActionIcon {
19- icon.name: "send"
20+ icon.name: "view-grid-symbolic"
21 enabled: navigationPage.buttonsEnabled
22 onClicked: mainPageStack.push(Qt.resolvedUrl("RoutePage.qml"))
23 }
24@@ -487,7 +487,7 @@
25 icon.height: units.gu(3)
26 highlightSize: units.gu(-1)
27 onClicked: {
28- mainPageStack.push(Qt.resolvedUrl("./PoiPage.qml"), {"fromPage": "Main.qml", "lat": mainPageStack.clickedLat, "lng": mainPageStack.clickedLng})
29+ mainPageStack.push(Qt.resolvedUrl("PoiPage.qml"), {"lat": mainPageStack.clickedLat, "lng": mainPageStack.clickedLng})
30 }
31 }
32
33
34=== modified file 'qml/Nearby.qml'
35--- qml/Nearby.qml 2016-04-10 09:43:33 +0000
36+++ qml/Nearby.qml 2016-04-14 16:55:42 +0000
37@@ -71,9 +71,9 @@
38
39 onClicked: {
40 if (model.mode === "CURRENT") {
41- mainPageStack.push(Qt.resolvedUrl("./PoiPage.qml"), {"fromPage": "Nearby.qml", "lat": mainPageStack.currentLat, "lng": mainPageStack.currentLng})
42+ mainPageStack.push(Qt.resolvedUrl("PoiPage.qml"), {"lat": mainPageStack.currentLat, "lng": mainPageStack.currentLng})
43 } else if (model.mode === "DESTINATION") {
44- mainPageStack.push(Qt.resolvedUrl("./PoiPage.qml"), {"fromPage": "Nearby.qml", "lat": mainPageStack.endLat, "lng": mainPageStack.endLng})
45+ mainPageStack.push(Qt.resolvedUrl("PoiPage.qml"), {"lat": mainPageStack.endLat, "lng": mainPageStack.endLng})
46 } else if (model.mode === "MAP") {
47 mainPageStack.clear(); // Show map
48 mainPageStack.executeJavaScript("force_show_map()");
49
50=== modified file 'qml/PoiListPage.qml'
51--- qml/PoiListPage.qml 2016-04-12 12:43:05 +0000
52+++ qml/PoiListPage.qml 2016-04-14 16:55:42 +0000
53@@ -25,7 +25,6 @@
54 Page {
55 id: poiListPage
56
57- property var fromPage
58 property var lat
59 property var lng
60 property string poiType: ""
61
62=== modified file 'qml/PoiPage.qml'
63--- qml/PoiPage.qml 2016-04-10 10:28:45 +0000
64+++ qml/PoiPage.qml 2016-04-14 16:55:42 +0000
65@@ -26,7 +26,6 @@
66 Page {
67 id: poiPage
68
69- property var fromPage
70 property var lat
71 property var lng
72 property string unit: navApp.settings.unit === 0 ? "km" : "mi"
73@@ -187,7 +186,6 @@
74 poiSearchField.text = ""
75 poiPage.header = standardHeader
76 mainPageStack.push(Qt.resolvedUrl("PoiListPage.qml"), {
77- fromPage: poiPage,
78 lat: poiPage.lat,
79 lng: poiPage.lng,
80 poiType: model.label,
81
82=== modified file 'qml/RoutePage.qml'
83--- qml/RoutePage.qml 2016-04-11 19:28:39 +0000
84+++ qml/RoutePage.qml 2016-04-14 16:55:42 +0000
85@@ -23,7 +23,7 @@
86 id: routePage
87
88 header: UNavHeader {
89- title: i18n.tr("Route")
90+ title: i18n.tr("Menu")
91 flickable: flickable
92
93 // #FIXME: This back button is only here to allow the user to press Escape keyboard key to go back.
94
95=== modified file 'qml/SearchPage.qml'
96--- qml/SearchPage.qml 2016-04-10 15:45:29 +0000
97+++ qml/SearchPage.qml 2016-04-14 16:55:42 +0000
98@@ -390,7 +390,6 @@
99 if (model.title === i18n.tr("Nearby history")) {
100 mainPageStack.push(Qt.resolvedUrl("PoiListPage.qml"),
101 {
102- fromPage: searchPage,
103 lat: mainPageStack.currentLat,
104 lng: mainPageStack.currentLng,
105 poiType: model.name,
106
107=== modified file 'qml/SettingsPage.qml'
108--- qml/SettingsPage.qml 2016-04-10 09:43:33 +0000
109+++ qml/SettingsPage.qml 2016-04-14 16:55:42 +0000
110@@ -306,7 +306,15 @@
111 Dialog {
112 id: dialogueRadars
113 title: i18n.tr("Speed Camera alerts and the law")
114- text: i18n.tr("uNav is only reading the OpenStreetMap database.\nuNav will show a max speed notification and a Speed Camera marker (marker hidden for French users because of law).\n\nIn a few countries Speed Camera alerts are illegal, then enable this option only if it's legal in the country.\n\nRead more about it here:\n%1").arg("http://goo.gl/ulXvG8")
115+ text: i18n.tr("uNav is only reading the OpenStreetMap database.\nuNav will show a max speed notification and a Speed Camera marker (marker hidden for French users because of law).\n\nIn a few countries Speed Camera alerts are illegal, then enable this option only if it's legal in the country.")
116+ Label {
117+ width: parent.width
118+ color: UbuntuColors.slate
119+ wrapMode: Text.WordWrap
120+ horizontalAlignment: Text.AlignHCenter
121+ text: i18n.tr("Read more about it %1.").arg("<a href=\"http://goo.gl/ulXvG8\">here</a>")
122+ onLinkActivated: Qt.openUrlExternally(link)
123+ }
124 Button {
125 text: i18n.tr("OK")
126 color: UbuntuColors.red
127
128=== modified file 'qml/tuto/Slide3.qml'
129--- qml/tuto/Slide3.qml 2016-03-26 18:53:17 +0000
130+++ qml/tuto/Slide3.qml 2016-04-14 16:55:42 +0000
131@@ -40,7 +40,7 @@
132 elide: Text.ElideRight
133 fontSize: "x-large"
134 maximumLineCount: 2
135- text: i18n.tr("Flick Results")
136+ text: i18n.tr("Swipe Results")
137 horizontalAlignment: Text.AlignHCenter
138 width: parent.width
139 wrapMode: Text.WordWrap
140
141=== modified file 'qml/tuto/components/Walkthrough.qml'
142--- qml/tuto/components/Walkthrough.qml 2016-03-26 18:53:17 +0000
143+++ qml/tuto/components/Walkthrough.qml 2016-04-14 16:55:42 +0000
144@@ -42,10 +42,6 @@
145 // Property to signal walkthrough completion
146 signal finished
147
148- // Disable automatic orientation during welcome wizard since it is not landscape friendly yet.
149- // Component.onCompleted: podbird.automaticOrientation = false
150- // Component.onDestruction: podbird.automaticOrientation = true
151-
152 header: PageHeader {
153 id: headerTuto
154 visible: false
155@@ -92,6 +88,7 @@
156 wrapMode: Text.WordWrap
157 text: i18n.tr("Skip")
158 horizontalAlignment: Text.AlignRight
159+ visible: listView.currentIndex !== listView.count-1
160
161 anchors {
162 top: parent.top

Subscribers

People subscribed via source and target branches